From d70a8b17e23f85d4283c555eb57714142d9e06c7 Mon Sep 17 00:00:00 2001 From: Quick104 <31828688+Quick104@users.noreply.github.com> Date: Fri, 20 Nov 2026 13:55:34 -0500 Subject: [PATCH 01/11] feat(config): set backups, Discord, MDBList and more from the environment Thirteen more server settings can be set from environment variables, with the checks an admin save runs: the nightly backup schedule and contents (SILO_BACKUP_*), the Discord application (SILO_DISCORD_*), the MDBList key, the Meilisearch index, the web media origin, the prepared-download budget and realtime library monitoring. A deployment kept in version control no longer needs the admin UI for them. The web admin shows each of these fields read-only with the variable that sets it, as it does for the existing variables. The Discord card leaves keys the environment sets out of its saves and its clear action, which the server would refuse. Co-Authored-By: Claude Opus 5.5 --- .env.example | 13 +++++ cmd/silo/backup_wiring.go | 36 +++++++++++- cmd/silo/backup_wiring_test.go | 22 +++++++- cmd/silo/main.go | 2 +- .../api/handlers/admin_settings_env_test.go | 51 +++++++++++++++++ internal/config/env_settings.go | 16 ++++++ web/src/components/settings/LimitField.tsx | 16 +++++- web/src/components/settings/SecretField.tsx | 8 ++- .../pages/admin-backups/BackupSettings.tsx | 9 +++ .../admin-settings/DownloadsSettings.tsx | 1 + .../LibraryMetadataSettings.tsx | 1 + .../NotificationsAdminSettings.tsx | 55 ++++++++++++------- .../admin-settings/ProvidersSettings.tsx | 30 ++++++---- .../pages/admin-settings/SearchSettings.tsx | 1 + 14 files changed, 223 insertions(+), 38 deletions(-) diff --git a/.env.example b/.env.example index f90e22957d..1f2c26c541 100644 --- a/.env.example +++ b/.env.example @@ -173,6 +173,7 @@ SILO_DATA_ROOT=/opt/silo # SILO_SERVER_NAME=Silo # SILO_PUBLIC_URL=https://silo.example.com # SILO_LOCAL_URL=http://192.168.1.20:8080 +# SILO_WEB_MEDIA_URL=https://media.example.com # SILO_LAN_DISCOVERY=true # SILO_LOG_LEVEL=info # SILO_LOG_FORMAT=json @@ -189,13 +190,25 @@ SILO_DATA_ROOT=/opt/silo # SILO_SMTP_PASSWORD= # SILO_SMTP_FROM_ADDRESS=silo@example.com # SILO_SMTP_FROM_NAME=Silo +# SILO_DISCORD_CLIENT_ID= +# SILO_DISCORD_CLIENT_SECRET= +# SILO_DISCORD_BOT_TOKEN= # SILO_FFMPEG_PATH=/usr/lib/jellyfin-ffmpeg/ffmpeg # SILO_HW_ACCEL=vaapi # SILO_HW_DEVICE=/dev/dri/renderD128 # SILO_TRANSCODE_ENABLED=true # SILO_TRANSCODE_DIR=/transcode # SILO_DOWNLOAD_ARTIFACT_DIR= +# SILO_DOWNLOAD_ARTIFACT_MAX_BYTES=0 +# SILO_SCANNER_REALTIME_MONITORING=true +# SILO_BACKUP_ENABLED=true +# SILO_BACKUP_TIME=04:00 +# SILO_BACKUP_KEEP=7 +# SILO_BACKUP_INCLUDE_SUBTITLES=true +# SILO_BACKUP_INCLUDE_INTRO_FINGERPRINTS=false # SILO_TMDB_API_KEY= +# SILO_MDBLIST_API_KEY= +# SILO_MEILISEARCH_INDEX=silo_media_items # Storage: SILO_ARTWORK_STORAGE (auto, local or s3), SILO_ARTWORK_PATH, and # SILO_S3_PUBLIC_* and SILO_S3_PRIVATE_* with ENDPOINT, REGION, BUCKET, # KEY_PREFIX, PATH_STYLE, ACCESS_KEY and SECRET_KEY, plus diff --git a/cmd/silo/backup_wiring.go b/cmd/silo/backup_wiring.go index 2b2800afc8..b4a516aaff 100644 --- a/cmd/silo/backup_wiring.go +++ b/cmd/silo/backup_wiring.go @@ -63,7 +63,7 @@ func newBackupService(pool *pgxpool.Pool, bc *config.BootstrapConfig, settings * // through the migrations. It runs before this release's schema exists, so // it reads only the server_settings rows the previous release left, with // defaults for the rest, and publishes no status. -func beforeMigrateBackup(bc *config.BootstrapConfig, pool *pgxpool.Pool, cipher *secret.Cipher, wait time.Duration) func(context.Context) (database.Guard, error) { +func beforeMigrateBackup(bc *config.BootstrapConfig, pool *pgxpool.Pool, cipher *secret.Cipher, wait time.Duration, env config.EnvSettings) func(context.Context) (database.Guard, error) { return func(ctx context.Context) (database.Guard, error) { skip := backup.SkipBeforeUpgradeFromEnv() opts, err := upgradeBackupOptions(ctx, pool, bc, cipher) @@ -75,6 +75,9 @@ func beforeMigrateBackup(bc *config.BootstrapConfig, pool *pgxpool.Pool, cipher // Skipping needs only the lock the migrations run under. opts = backup.Options{Pool: pool, Locker: backup.PostgresLocker{Pool: pool}} } + if opts.Settings != nil { + opts.Settings = withEnvBackupSettings(opts.Settings, env) + } // Rotation after the backup keeps a queued restore's source, read // from the admin jobs (Options.ActiveRestore). On a schema the job // repository cannot read, rotation is skipped with a warning; the @@ -92,6 +95,37 @@ func beforeMigrateBackup(bc *config.BootstrapConfig, pool *pgxpool.Pool, cipher } } +// envBackupSettings lays the backup settings the environment sets +// (SILO_BACKUP_*) over the stored ones. The backup before migrations runs +// before startup stores the environment's values, so without it a variable +// set in the same deploy, such as SILO_BACKUP_ENABLED=false, would not apply +// to that backup. A --migrate-only run reads no environment settings, as no +// maintenance command does, so it backs up by the stored ones. +type envBackupSettings struct { + backup.SettingsReader + values map[string]string +} + +func withEnvBackupSettings(stored backup.SettingsReader, env config.EnvSettings) backup.SettingsReader { + values := map[string]string{} + for key, value := range env.Values(config.EnvScopeStored) { + if strings.HasPrefix(key, "backup.") { + values[key] = value + } + } + if len(values) == 0 { + return stored + } + return envBackupSettings{SettingsReader: stored, values: values} +} + +func (s envBackupSettings) Get(ctx context.Context, key string) (string, error) { + if value, ok := s.values[key]; ok { + return value, nil + } + return s.SettingsReader.Get(ctx, key) +} + // upgradeBackupOptions builds the backup service's options from the // configuration the database holds now, as the previous release left it. func upgradeBackupOptions(ctx context.Context, pool *pgxpool.Pool, bc *config.BootstrapConfig, cipher *secret.Cipher) (backup.Options, error) { diff --git a/cmd/silo/backup_wiring_test.go b/cmd/silo/backup_wiring_test.go index cba64e1b8b..f5c7a534a1 100644 --- a/cmd/silo/backup_wiring_test.go +++ b/cmd/silo/backup_wiring_test.go @@ -154,7 +154,7 @@ func TestBeforeMigrateBackupOnAnOldSchemaDB(t *testing.T) { if err != nil { t.Fatal(err) } - hook := beforeMigrateBackup(bc, db.pool, cipher, time.Minute) + hook := beforeMigrateBackup(bc, db.pool, cipher, time.Minute, nil) otherServer := backup.New(backup.Options{Pool: db.pool, Locker: backup.PostgresLocker{Pool: db.pool}}) var checked bool err = database.MigrateAtStartup(ctx, db.pool, migrations.FS, "sql", database.StartupOptions{ @@ -260,3 +260,23 @@ func passwordless(t *testing.T, raw string) string { } return u.String() } + +type storedBackupSettings map[string]string + +func (s storedBackupSettings) Get(_ context.Context, key string) (string, error) { return s[key], nil } + +// A SILO_BACKUP_* variable set in the deploy that also upgrades applies to the +// backup taken before the migrations, which runs before startup stores it. +func TestEnvBackupSettingsOverlayStored(t *testing.T) { + values := map[string]string{"SILO_BACKUP_ENABLED": "false", "SILO_SMTP_HOST": "smtp.example.com"} + env, err := config.ReadEnvSettings(func(name string) string { return values[name] }) + if err != nil { + t.Fatal(err) + } + settings := withEnvBackupSettings(storedBackupSettings{"backup.enabled": "true", "backup.keep": "9", "email.smtp_host": "stored"}, env) + for key, want := range map[string]string{"backup.enabled": "false", "backup.keep": "9", "email.smtp_host": "stored"} { + if got, _ := settings.Get(t.Context(), key); got != want { + t.Errorf("%s = %q, want %q", key, got, want) + } + } +} diff --git a/cmd/silo/main.go b/cmd/silo/main.go index fd4dc53e4f..0c6676904c 100644 --- a/cmd/silo/main.go +++ b/cmd/silo/main.go @@ -978,7 +978,7 @@ func main() { migrationWait := database.MigrationWait() startupMigrations := database.StartupOptions{ Wait: migrationWait, - BeforeMigrate: beforeMigrateBackup(bc, pool, dataCipher, migrationWait), + BeforeMigrate: beforeMigrateBackup(bc, pool, dataCipher, migrationWait, envSettings), } if *migrateOnly { diff --git a/internal/api/handlers/admin_settings_env_test.go b/internal/api/handlers/admin_settings_env_test.go index 75e9e91e1e..7df1f74fd3 100644 --- a/internal/api/handlers/admin_settings_env_test.go +++ b/internal/api/handlers/admin_settings_env_test.go @@ -56,3 +56,54 @@ func TestCheckEnvironmentSettingsKeepsRecordedStorage(t *testing.T) { t.Errorf("recorded location with other storage settings: %v", err) } } + +// Backups, the Discord application, MDBList, the Meilisearch index, the +// web media origin, prepared-download budget and realtime monitoring can be +// set from the environment, with an admin save's checks. +func TestCheckEnvironmentSettingsDeploymentSettings(t *testing.T) { + checked, err := CheckEnvironmentSettings(nil, readEnv(t, map[string]string{ + "SILO_WEB_MEDIA_URL": "https://media.example.com/", + "SILO_MEILISEARCH_INDEX": "silo-home", + "SILO_MDBLIST_API_KEY": "mdblist-key", + "SILO_DISCORD_CLIENT_ID": "123456789012345678", + "SILO_DISCORD_CLIENT_SECRET": "discord-secret", + "SILO_DISCORD_BOT_TOKEN": "discord-token", + "SILO_DOWNLOAD_ARTIFACT_MAX_BYTES": "10737418240", + "SILO_SCANNER_REALTIME_MONITORING": "false", + "SILO_BACKUP_ENABLED": "false", + "SILO_BACKUP_TIME": "04:30", + "SILO_BACKUP_KEEP": "14", + "SILO_BACKUP_INCLUDE_SUBTITLES": "false", + "SILO_BACKUP_INCLUDE_INTRO_FINGERPRINTS": "true", + }), false) + if err != nil { + t.Fatal(err) + } + want := map[string]string{ + "server.web_media_url": "https://media.example.com", + "catalog.search.meilisearch.index": "silo-home", + "mdblist.api_key": "mdblist-key", + "discord.client_id": "123456789012345678", + "discord.client_secret": "discord-secret", + "discord.bot_token": "discord-token", + "download.artifact_max_bytes": "10737418240", + "scanner.realtime_monitoring": "false", + "backup.enabled": "false", + "backup.time": "04:30", + "backup.keep": "14", + "backup.include_subtitles": "false", + "backup.include_intro_fingerprints": "true", + } + got := checked.Values(config.EnvScopeStored) + for key, value := range want { + if got[key] != value { + t.Errorf("%s = %q, want %q", key, got[key], value) + } + } + + // An invalid value stops startup with the variable's name. + env := map[string]string{"SILO_BACKUP_TIME": "25:00"} + if _, err := config.ReadEnvSettings(func(name string) string { return env[name] }); err == nil || !strings.Contains(err.Error(), "SILO_BACKUP_TIME") { + t.Errorf("SILO_BACKUP_TIME=25:00: error = %v, want a refusal naming it", err) + } +} diff --git a/internal/config/env_settings.go b/internal/config/env_settings.go index 714d412ac7..91aca06dc1 100644 --- a/internal/config/env_settings.go +++ b/internal/config/env_settings.go @@ -39,6 +39,7 @@ var envSettingVars = []EnvSettingVar{ {"SILO_SERVER_NAME", "branding.server_name", EnvScopeStored}, {"SILO_PUBLIC_URL", "server.public_url", EnvScopeStored}, {"SILO_LOCAL_URL", ServerLocalURLSettingKey, EnvScopeStored}, + {"SILO_WEB_MEDIA_URL", WebMediaURLSettingKey, EnvScopeStored}, {"SILO_LAN_DISCOVERY", ServerLANDiscoverySettingKey, EnvScopeStored}, {"SILO_LOG_LEVEL", "server.log_level", EnvScopeStored}, {"SILO_LOG_FORMAT", serverLogFormatSettingKey, EnvScopeStored}, @@ -53,6 +54,7 @@ var envSettingVars = []EnvSettingVar{ {"SILO_SEARCH_PROVIDER", "catalog.search.provider", EnvScopeStored}, {"SILO_MEILISEARCH_URL", "catalog.search.meilisearch.url", EnvScopeStored}, {"SILO_MEILISEARCH_API_KEY", "catalog.search.meilisearch.api_key", EnvScopeStored}, + {"SILO_MEILISEARCH_INDEX", "catalog.search.meilisearch.index", EnvScopeStored}, {"SILO_ARTWORK_STORAGE", "artwork.storage_backend", EnvScopeStored}, {"SILO_ARTWORK_PATH", "artwork.local_path", EnvScopeStored}, @@ -85,14 +87,28 @@ var envSettingVars = []EnvSettingVar{ {"SILO_SMTP_FROM_ADDRESS", "email.from_address", EnvScopeStored}, {"SILO_SMTP_FROM_NAME", "email.from_name", EnvScopeStored}, + {"SILO_DISCORD_CLIENT_ID", "discord.client_id", EnvScopeStored}, + {"SILO_DISCORD_CLIENT_SECRET", "discord.client_secret", EnvScopeStored}, + {"SILO_DISCORD_BOT_TOKEN", "discord.bot_token", EnvScopeStored}, + {"SILO_FFMPEG_PATH", "playback.ffmpeg_path", EnvScopeStored}, {"SILO_HW_ACCEL", "playback.hw_accel", EnvScopeStored}, {"SILO_HW_DEVICE", "playback.hw_device", EnvScopeStored}, {"SILO_TRANSCODE_DIR", playbackTranscodeDirSettingKey, EnvScopeStored}, {"SILO_TRANSCODE_ENABLED", "playback.transcode_enabled", EnvScopeStored}, {"SILO_DOWNLOAD_ARTIFACT_DIR", downloadArtifactDirSettingKey, EnvScopeStored}, + {"SILO_DOWNLOAD_ARTIFACT_MAX_BYTES", "download.artifact_max_bytes", EnvScopeStored}, + + {"SILO_SCANNER_REALTIME_MONITORING", "scanner.realtime_monitoring", EnvScopeStored}, + + {"SILO_BACKUP_ENABLED", BackupEnabledSettingKey, EnvScopeStored}, + {"SILO_BACKUP_TIME", BackupTimeSettingKey, EnvScopeStored}, + {"SILO_BACKUP_KEEP", BackupKeepSettingKey, EnvScopeStored}, + {"SILO_BACKUP_INCLUDE_SUBTITLES", BackupIncludeSubtitlesSettingKey, EnvScopeStored}, + {"SILO_BACKUP_INCLUDE_INTRO_FINGERPRINTS", BackupIncludeIntroFingerprintsSettingKey, EnvScopeStored}, {"SILO_TMDB_API_KEY", "tmdb.api_key", EnvScopeStored}, + {"SILO_MDBLIST_API_KEY", "mdblist.api_key", EnvScopeStored}, {"SILO_DB_MAX_CONNECTIONS", "database.max_connections", EnvScopeProcess}, {"SILO_USERDB_POOL_MAX_OPEN", "userdb.pool_max_open", EnvScopeProcess}, diff --git a/web/src/components/settings/LimitField.tsx b/web/src/components/settings/LimitField.tsx index c97d33ca2c..7920b03def 100644 --- a/web/src/components/settings/LimitField.tsx +++ b/web/src/components/settings/LimitField.tsx @@ -2,6 +2,7 @@ import { useId, useState } from "react"; import { Input } from "@/components/ui/input"; import { useT } from "@/i18n"; +import { cn } from "@/lib/utils"; import { SETTINGS_NUMBER_WIDTH, SettingFieldRow } from "@/pages/admin-settings/SettingField"; export interface LimitFieldProps { @@ -26,6 +27,8 @@ export interface LimitFieldProps { min?: number; disabled?: boolean; restartRequired?: boolean; + /** The variable that sets this limit from the server's environment; disables the control. */ + managedByEnv?: string; } /** @@ -69,9 +72,11 @@ export function LimitField({ scale = 1, hint, min = 0, - disabled = false, + disabled: disabledProp = false, restartRequired = false, + managedByEnv, }: LimitFieldProps) { + const disabled = disabledProp || managedByEnv != null; const t = useT(); const unlimitedLabel = unlimitedLabelProp ?? t("web.settings.limitField.unlimited"); const controlId = useId(); @@ -110,13 +115,20 @@ export function LimitField({ descriptionId={hintId} restartRequired={restartRequired} unit={unit} + managedByEnv={managedByEnv} >
{/* Ahead of the input, not after it: the row's unit slot sits to the right of the control edge, so anything between the input and that edge would knock this field's box out of line with the plain number fields it is stacked against. */} -
@@ -716,6 +726,7 @@ function DiscordAppCredentials({ onChange={setClientSecret} hint={t("web.admin.settings.notifications.discord.fromOAuth2Page")} restartRequired={restartKeys.has("discord.client_secret")} + managedByEnv={envVar("discord.client_secret")} />
- + {editableKeys.length > 0 && ( + + )} @@ -1118,6 +1132,7 @@ export default function NotificationsAdminSettings() { savedClientId={form.getValue("discord.client_id")} sensitiveConfigured={form.sensitiveConfigured} restartKeys={restartKeys} + envVar={form.envVar} /> {t("web.admin.settings.notifications.discord.delivery")} diff --git a/web/src/pages/admin-settings/ProvidersSettings.tsx b/web/src/pages/admin-settings/ProvidersSettings.tsx index 8221a762c6..846e6b943a 100644 --- a/web/src/pages/admin-settings/ProvidersSettings.tsx +++ b/web/src/pages/admin-settings/ProvidersSettings.tsx @@ -452,6 +452,7 @@ function SubtitleProviderTile({ function MDBListTile({ sensitiveConfigured, + managedByEnv, restartKeys, expanded, onExpand, @@ -460,6 +461,8 @@ function MDBListTile({ onTested, }: { sensitiveConfigured: string[]; + /** The variable that sets the key from the server's environment, if any. */ + managedByEnv?: string; restartKeys: RestartKeyMatcher; expanded: boolean; onExpand: () => void; @@ -474,6 +477,7 @@ function MDBListTile({ const [testing, setTesting] = useState(false); const configured = sensitiveConfigured.includes("mdblist.api_key"); + const managed = managedByEnv != null; const hasDraft = apiKey.trim() !== ""; useReportUnsavedChanges(hasDraft); @@ -580,18 +584,21 @@ function MDBListTile({ setApiKey(next); }} restartRequired={restartKeys.has("mdblist.api_key")} + managedByEnv={managedByEnv} /> - + {managed ? null : ( + + )}
)} {hint &&

{hint}

} + {envNote} ); } @@ -198,6 +210,7 @@ function RecSettingField({ className="w-40" /> {hint &&

{hint}

} + {envNote} ); } @@ -223,6 +236,7 @@ function RecSettingField({ placeholder={hint} /> {hint && type === "duration" &&

{hint}

} + {envNote} ); } @@ -347,7 +361,7 @@ function RecJobStatusCard({ export default function AdminRecommendations() { const t = useT(); const { data: settings, isLoading } = useAdminServerSettings(); - const { data: sensitiveData } = useAdminSensitiveStatus(); + const { data: sensitiveData, isLoading: sensitiveLoading } = useAdminSensitiveStatus(); const updateSettings = useUpdateServerSettings(); const checkConnection = useCheckAdminSettingsConnection(); const { data: status } = useRecommendationsStatus(); @@ -485,7 +499,9 @@ export default function AdminRecommendations() { } } - if (isLoading) + // Until the server says which settings its environment sets, a field could + // offer an edit the server would refuse. + if (isLoading || sensitiveLoading) return (
@@ -500,6 +516,7 @@ export default function AdminRecommendations() { ); const sensitiveConfigured = sensitiveData?.configured ?? []; + const envVars = sensitiveData?.managed_by_env_vars ?? {}; const serverSettings: Record = settings ?? {}; const embeddingLock = parseRecommendationEmbeddingLock( serverSettings["recommendations.embedding_lock"], @@ -635,6 +652,7 @@ export default function AdminRecommendations() { { setConnectionResult(null); void handleCommit(EMBEDDING_PROVIDER_KEY, id).then((saved) => { @@ -658,9 +676,13 @@ export default function AdminRecommendations() { kind="embeddings" value={embeddingModel} placeholder={EMBEDDING_MODEL_EXAMPLES} + managedByEnv={envVars[EMBEDDING_MODEL_KEY]} onChange={(next) => handleLocalChange(EMBEDDING_MODEL_KEY, next)} onCommit={(next) => { - if (next !== (serverSettings[EMBEDDING_MODEL_KEY] ?? "")) { + if ( + !envVars[EMBEDDING_MODEL_KEY] && + next !== (serverSettings[EMBEDDING_MODEL_KEY] ?? "") + ) { void handleCommit(EMBEDDING_MODEL_KEY, next); } }} @@ -677,6 +699,7 @@ export default function AdminRecommendations() { localValues={localValues} sensitiveConfigured={sensitiveConfigured} isPending={updateSettings.isPending} + managedByEnv={envVars[field.key]} onLocalChange={handleLocalChange} onCommit={(key, value) => void handleCommit(key, value)} onToggle={handleToggle} diff --git a/web/src/pages/admin-settings/AIModelField.tsx b/web/src/pages/admin-settings/AIModelField.tsx index d5ddb88dd7..5c97d3851a 100644 --- a/web/src/pages/admin-settings/AIModelField.tsx +++ b/web/src/pages/admin-settings/AIModelField.tsx @@ -31,6 +31,7 @@ export function ModelField({ onChange, onCommit, placeholder, + managedByEnv, }: { label: string; description?: ReactNode; @@ -41,15 +42,20 @@ export function ModelField({ /** Called when focus leaves the field, for pages that save each field. */ onCommit?: (value: string) => void; placeholder?: string; + /** The variable that sets this model on the server; disables the field. */ + managedByEnv?: string; }) { const t = useT(); const inputID = useId(); const inputRef = useRef(null); const pickerOpen = useRef(false); - const models = useAIProviderModels(providerID); + // A model the environment sets can't be picked here, so its provider's + // models aren't fetched. + const listedProviderID = managedByEnv != null ? "" : providerID; + const models = useAIProviderModels(listedProviderID); const suggestions = (models.data?.models ?? []).filter((model) => model.kind === kind); const status = - providerID === "" ? undefined : models.isError ? ( + listedProviderID === "" ? undefined : models.isError ? ( {t("web.admin.settings.ai.modelField.loadFailed")} @@ -62,7 +68,13 @@ export function ModelField({ ) : undefined; return ( - +
{ @@ -79,9 +91,10 @@ export function ModelField({ placeholder={placeholder} autoComplete="off" spellCheck={false} + disabled={managedByEnv != null} className="font-mono text-[13px]" /> - {suggestions.length > 0 && ( + {suggestions.length > 0 && managedByEnv == null && ( model.id === value) ? value : ""} onOpenChange={(open) => { From 5d3bc97f69c8f62fa751a64ae9041ddf0d0b35a5 Mon Sep 17 00:00:00 2001 From: Quick104 <31828688+Quick104@users.noreply.github.com> Date: Fri, 20 Nov 2026 16:55:37 -0500 Subject: [PATCH 08/11] fix(config): refuse empty capabilities and blank keys in declarations - `capabilities: []` passed the schema and a known type then silently took its own set; the schema now asks for at least one capability. - A key file or variable holding only whitespace became no key at all, which a provider with an optional key accepted without a word; it now stops startup. - Test that the admin API lists a declared provider with its variable and refuses to edit or remove it. Co-Authored-By: Claude Opus 5.5 --- contracts/plugins/provisioning/v1/schema.json | 1 + .../api/handlers/admin_settings_env_test.go | 27 +++++++++++++++++++ internal/plugins/provision_document.go | 5 ++++ internal/plugins/provision_document_test.go | 7 +++-- 4 files changed, 38 insertions(+), 2 deletions(-) diff --git a/contracts/plugins/provisioning/v1/schema.json b/contracts/plugins/provisioning/v1/schema.json index 44dbce14f3..34f61596a8 100644 --- a/contracts/plugins/provisioning/v1/schema.json +++ b/contracts/plugins/provisioning/v1/schema.json @@ -63,6 +63,7 @@ "base_url": { "type": "string", "minLength": 1 }, "capabilities": { "type": "array", + "minItems": 1, "uniqueItems": true, "items": { "enum": ["chat", "embeddings", "speech"] } }, diff --git a/internal/api/handlers/admin_settings_env_test.go b/internal/api/handlers/admin_settings_env_test.go index 5b24e23b33..790e803491 100644 --- a/internal/api/handlers/admin_settings_env_test.go +++ b/internal/api/handlers/admin_settings_env_test.go @@ -1,6 +1,7 @@ package handlers import ( + "errors" "strings" "testing" @@ -134,3 +135,29 @@ func TestCheckDeploymentSettingsBindsDeclaredProvider(t *testing.T) { t.Errorf("provider not declared: error = %v, want one naming SILO_RECOMMENDATIONS_PROVIDER", err) } } + +// A provider the deployment declares is listed with its variable, and the +// admin API refuses to edit or remove it until a document releases it. +func TestAdminAIProvidersRefuseDeclaredProvider(t *testing.T) { + embed, err := config.NewDeclaredAIProvider("local-embed", config.AIProviderCustom, "Local embeddings", "http://embed:8080/v1", "", []config.AICapability{config.AICapabilityEmbeddings}) + if err != nil { + t.Fatal(err) + } + registry, err := config.ApplyDeclaredAIProviders("", []config.AIProvider{embed}, "SILO_CONFIG_FILE") + if err != nil { + t.Fatal(err) + } + handler := &AdminHandler{SettingsRepo: newSerializedSettingsStore(map[string]string{config.AIProvidersSettingKey: registry})} + + views, err := handler.ListAIProviders(t.Context()) + if err != nil || len(views) != 1 || views[0].ManagedByEnvVar != "SILO_CONFIG_FILE" { + t.Fatalf("views = %+v, error = %v; want the declared provider with its variable", views, err) + } + name := "Renamed" + if _, err := handler.UpdateAIProvider(t.Context(), "local-embed", AdminAIProviderInput{Name: &name}); !errors.Is(err, ErrAIProviderManaged) { + t.Errorf("update: error = %v, want ErrAIProviderManaged", err) + } + if err := handler.DeleteAIProvider(t.Context(), "local-embed"); !errors.Is(err, ErrAIProviderManaged) { + t.Errorf("delete: error = %v, want ErrAIProviderManaged", err) + } +} diff --git a/internal/plugins/provision_document.go b/internal/plugins/provision_document.go index 3adff0c8ff..d306e1c384 100644 --- a/internal/plugins/provision_document.go +++ b/internal/plugins/provision_document.go @@ -184,6 +184,11 @@ func (d *ProvisionDocument) resolveAIProviderKey(value map[string]any) (string, if err := d.captureSecret(ref, &d.secretBytes); err != nil { return "", err } + // A key that is only whitespace would be stored as no key at all, which a + // provider that takes an optional key would accept without a word. + if strings.TrimSpace(d.secrets[ref]) == "" { + return "", errors.New("the referenced secret holds only whitespace") + } return d.secrets[ref], nil } diff --git a/internal/plugins/provision_document_test.go b/internal/plugins/provision_document_test.go index c657a6edfd..56dcd65951 100644 --- a/internal/plugins/provision_document_test.go +++ b/internal/plugins/provision_document_test.go @@ -89,9 +89,12 @@ func TestProvisionDocumentAIProviders(t *testing.T) { t.Error("a plugins-only document declares AI providers, or no plugins") } + t.Setenv("TEST_SILO_BLANK_KEY", " ") for name, input := range map[string]string{ - "literal key": `{"apiVersion":1,"ai_providers":{"openai-main":{"type":"openai","api_key":"sk-private-literal"}}}`, - "key it requires": `{"apiVersion":1,"ai_providers":{"openai-main":{"type":"openai"}}}`, + "literal key": `{"apiVersion":1,"ai_providers":{"openai-main":{"type":"openai","api_key":"sk-private-literal"}}}`, + "key it requires": `{"apiVersion":1,"ai_providers":{"openai-main":{"type":"openai"}}}`, + "blank key": `{"apiVersion":1,"ai_providers":{"local":{"type":"ollama","api_key":{"fromEnv":"TEST_SILO_BLANK_KEY"}}}}`, + "empty capabilities": `{"apiVersion":1,"ai_providers":{"local":{"type":"ollama","capabilities":[]}}}`, } { doc, err := parseProvisionDocument([]byte(input), false) if err == nil { From de5b0fd90762de6e9547dc11236e8e0d8abf876e Mon Sep 17 00:00:00 2001 From: Quick104 <31828688+Quick104@users.noreply.github.com> Date: Fri, 20 Nov 2026 17:04:11 -0500 Subject: [PATCH 09/11] fix(web): keep env-taken drafts and a chatgpt id from steering AI settings - The text provider select used "chatgpt" for the ChatGPT plan, so a provider declared with that id read as the plan. The select's value is now "__chatgpt__"; the auth mode keeps "chatgpt". - A provider panel remounts when the deployment takes the provider over or releases it, so no draft or test result from before carries across; a locked panel shows the stored provider. - The Recommendations page ignores a provider or model draft for a key the environment took over, in what it shows and in Check Connection. - A name clash suggests taking the other provider over only when it has the declared type, and the type-change error asks for a new name as well as a new id, since the released provider keeps its name. Co-Authored-By: Claude Opus 5.5 --- internal/config/ai_providers_declared.go | 7 ++++++- web/src/pages/AdminRecommendations.tsx | 18 +++++++++++++----- web/src/pages/admin-settings/AIProviders.tsx | 9 ++++++--- web/src/pages/admin-settings/AISettings.tsx | 10 +++++++--- 4 files changed, 32 insertions(+), 12 deletions(-) diff --git a/internal/config/ai_providers_declared.go b/internal/config/ai_providers_declared.go index baf70f1dda..adb677ffe3 100644 --- a/internal/config/ai_providers_declared.go +++ b/internal/config/ai_providers_declared.go @@ -72,7 +72,7 @@ func ApplyDeclaredAIProviders(raw string, declared []AIProvider, managedBy strin // As for an admin's edit: the models bound to a provider are its // type's, so a new type takes a new id. if stored := registry.Providers[i]; stored.Type != provider.Type { - return "", fmt.Errorf("%s: a provider's type cannot change (it is %s, declared as %s); declare the %s provider under a new id", + return "", fmt.Errorf("%s: a provider's type cannot change (it is %s, declared as %s); declare the %s provider under a new id with a name of its own", provider.ID, stored.Type, provider.Type, provider.Type) } registry.Providers[i] = provider @@ -87,6 +87,11 @@ func ApplyDeclaredAIProviders(raw string, declared []AIProvider, managedBy strin } func nameTakenError(declared, stored AIProvider) error { + // Taking the other provider over is a way out only when it keeps its type. + if stored.Type != declared.Type { + return fmt.Errorf("%s: another AI provider, %s, is already named %q; give the declared provider a name of its own", + declared.ID, stored.ID, stored.Name) + } return fmt.Errorf("%s: another AI provider, %s, is already named %q; give the declared provider a name of its own, or declare %s to take that provider over", declared.ID, stored.ID, stored.Name, stored.ID) } diff --git a/web/src/pages/AdminRecommendations.tsx b/web/src/pages/AdminRecommendations.tsx index 787ee312af..41a7da6fd6 100644 --- a/web/src/pages/AdminRecommendations.tsx +++ b/web/src/pages/AdminRecommendations.tsx @@ -466,14 +466,23 @@ export default function AdminRecommendations() { setCollapsed((prev) => ({ ...prev, [id]: !prev[id] })); } + // A draft for a key the environment took over since it was typed is + // ignored wherever the page reads it, so the page and the connection check + // use the environment's value. + function draftFor(key: string): string | undefined { + return sensitiveData?.managed_by_env_vars?.[key] ? undefined : localValues[key]; + } + function buildEmbeddingCheckRequest( serverSettings: Record, ): AdminSettingsConnectionCheckRequest { return { values: Object.fromEntries( - EMBEDDING_CHECK_KEYS.map((key) => [key, localValues[key] ?? serverSettings[key] ?? ""]), + EMBEDDING_CHECK_KEYS.map((key) => [key, draftFor(key) ?? serverSettings[key] ?? ""]), + ), + dirty_keys: EMBEDDING_CHECK_KEYS.filter( + (key) => dirtyKeys.has(key) && draftFor(key) !== undefined, ), - dirty_keys: EMBEDDING_CHECK_KEYS.filter((key) => dirtyKeys.has(key)), }; } @@ -519,9 +528,8 @@ export default function AdminRecommendations() { serverSettings["recommendations.embedding_lock"], ); const embeddingProviderID = - localValues[EMBEDDING_PROVIDER_KEY] ?? serverSettings[EMBEDDING_PROVIDER_KEY] ?? ""; - const embeddingModel = - localValues[EMBEDDING_MODEL_KEY] ?? serverSettings[EMBEDDING_MODEL_KEY] ?? ""; + draftFor(EMBEDDING_PROVIDER_KEY) ?? serverSettings[EMBEDDING_PROVIDER_KEY] ?? ""; + const embeddingModel = draftFor(EMBEDDING_MODEL_KEY) ?? serverSettings[EMBEDDING_MODEL_KEY] ?? ""; return (
diff --git a/web/src/pages/admin-settings/AIProviders.tsx b/web/src/pages/admin-settings/AIProviders.tsx index 8c037c763f..5b84a60cc6 100644 --- a/web/src/pages/admin-settings/AIProviders.tsx +++ b/web/src/pages/admin-settings/AIProviders.tsx @@ -214,7 +214,10 @@ function ProviderRow({ primaryAction={{ label: t("web.admin.settings.ai.tile.manage"), onClick: onExpand }} > {expanded && type ? ( + // Remounted when the deployment takes the provider over or releases + // it, so no draft or test result from before carries across. candidate.id === providerID); const selected = chatGPT ? CHATGPT_PROVIDER : providerID; const supportsServiceTier = !chatGPT && provider?.type === "openai" && serviceTiers.length > 0; From 461a39fa7038aa9b537bf66faf4cb8f57f395de4 Mon Sep 17 00:00:00 2001 From: Quick104 <31828688+Quick104@users.noreply.github.com> Date: Sat, 21 Nov 2026 02:12:44 +0000 Subject: [PATCH 10/11] fix(config): check only bindings the deployment can break at startup A document that changes the AI provider registry, or a recommendations variable, made startup check every stored provider binding, so one a restore into another deployment left naming a removed provider stopped the server, which an admin can't fix while it's down. Startup now checks the bindings the environment sets and those naming a provider the document declares; declaring never removes a provider, so the rest are as valid as before. A text binding the ChatGPT plan leaves idle is no longer checked against its provider, as AIProviderUsers already treats it, and the auth mode joins the binding group. The Recommendations page also replaced a draft for a key only while the environment set it, so the draft came back, and could be saved on blur, once the variable was removed. A key the environment sets now takes the server's value over any draft. docs/admin-settings-api.md says how declared providers are released. Co-Authored-By: Claude Opus 5.5 --- docs/admin-settings-api.md | 12 +++++++-- internal/api/handlers/admin.go | 5 ++-- internal/api/handlers/admin_settings_env.go | 25 +++++++++++++++++++ .../api/handlers/admin_settings_env_test.go | 19 ++++++++++++++ internal/config/ai_providers.go | 5 ++++ web/src/pages/AdminRecommendations.tsx | 13 ++++++++-- 6 files changed, 73 insertions(+), 6 deletions(-) diff --git a/docs/admin-settings-api.md b/docs/admin-settings-api.md index 3123b4b0f1..761048ed93 100644 --- a/docs/admin-settings-api.md +++ b/docs/admin-settings-api.md @@ -126,13 +126,21 @@ warning naming the legacy setting. HTTP Basic authentication through the URL is not supported; such a proxy needs to accept the provider's API key. The deployment can also declare providers, in the `ai_providers` section of -its deployment document (`SILO_CONFIG` or `SILO_CONFIG_FILE`). Each API server +its deployment document (`SILO_CONFIG` or `SILO_CONFIG_FILE`, or the older +names `SILO_PLUGINS` and `SILO_PLUGINS_FILE`). Each API server that reads the document stores them when it starts, in the same transaction as the settings its environment sets, so the last server to start wins, as for those settings: give every API server that reads the document the same one. A declared provider carries `managed_by_env_var`, the document's variable, and the update and delete operations below refuse it with `422` and code -`managed_by_environment`. The user manual covers writing the document. +`managed_by_environment`. A provider stays declared until an API server starts +with a document whose `ai_providers` section leaves it out, and +`ai_providers: {}` releases them all; a server that starts without the +document, or with one that has no `ai_providers` section, changes nothing, so +removing the variable leaves the providers locked. At startup the provider +bindings are checked only where the start can change them: those the +environment sets and those naming a provider the document declares. The user +manual covers writing the document. The following operations require an acting administrator: diff --git a/internal/api/handlers/admin.go b/internal/api/handlers/admin.go index 844a22385d..ac2ddcd1aa 100644 --- a/internal/api/handlers/admin.go +++ b/internal/api/handlers/admin.go @@ -1340,8 +1340,9 @@ var adminSettingDependencyGroups = [][]string{ {"matcher.enable_tv_series_root_queue", "matcher.enable_tv_series_group_queue"}, {"ai.max_concurrent_jobs", "subtitle_ai.max_concurrent_jobs"}, {"ai.chat_model", "subtitle_ai.chat_model", "ai.reasoning_effort"}, //nolint:goconst // Keep the complete setting dependency explicit. - // A provider binding is checked against the registry it names. - append([]string{config.AIProvidersSettingKey}, config.AIProviderBindingKeys()...), + // A provider binding is checked against the registry it names, and the + // text binding against the auth mode that can leave it idle. + append([]string{config.AIProvidersSettingKey, config.AIAuthModeSettingKey}, config.AIProviderBindingKeys()...), { diagnostics.KeyMaxBundleBytes, diagnostics.KeyMaxUncompressedBytes, diff --git a/internal/api/handlers/admin_settings_env.go b/internal/api/handlers/admin_settings_env.go index 8fdd475f1e..7dd5699976 100644 --- a/internal/api/handlers/admin_settings_env.go +++ b/internal/api/handlers/admin_settings_env.go @@ -68,6 +68,8 @@ func CheckDeploymentSettings(stored map[string]string, env config.EnvSettings, d } } + skipBindingsOutsideDeclaration(prospective, normalized, declaredBy) + if err := validateProspectiveAdminSettings(adminSettingsValidationSnapshot(prospective, normalized), redisBootstrapAvailable); err != nil { vars := checked.VarsFor(nil) if declaredChanged { @@ -78,6 +80,29 @@ func CheckDeploymentSettings(stored map[string]string, env config.EnvSettings, d return checked, nil } +// skipBindingsOutsideDeclaration leaves out of the startup check each stored +// provider binding the deployment can't have broken: one the environment +// doesn't set that names a provider the document doesn't declare (with no +// document, every stored binding). Declaring never removes a provider, so +// such a binding is as valid as it was, and one already naming a missing +// provider (as a restore into another deployment can leave) stays the +// admin's to fix instead of stopping startup. +func skipBindingsOutsideDeclaration(prospective, fromEnvironment map[string]string, declaredBy string) { + registry, err := config.ParseAIProviderRegistry(prospective[config.AIProvidersSettingKey]) + if err != nil { + return // The registry check reports it. + } + for _, key := range config.AIProviderBindingKeys() { + if _, set := fromEnvironment[key]; set { + continue + } + provider, found := registry.Find(strings.TrimSpace(prospective[key])) + if !found || declaredBy == "" || provider.ManagedBy != declaredBy { + prospective[key] = "" + } + } +} + // storageLocationKeys are the settings rejectArtworkIdentityChange compares. var storageLocationKeys = map[string]bool{ artworkStorageBackendKey: true, diff --git a/internal/api/handlers/admin_settings_env_test.go b/internal/api/handlers/admin_settings_env_test.go index 790e803491..6b3f255ae5 100644 --- a/internal/api/handlers/admin_settings_env_test.go +++ b/internal/api/handlers/admin_settings_env_test.go @@ -134,6 +134,25 @@ func TestCheckDeploymentSettingsBindsDeclaredProvider(t *testing.T) { if _, err := CheckEnvironmentSettings(nil, env, false); err == nil || !strings.Contains(err.Error(), "SILO_RECOMMENDATIONS_PROVIDER") { t.Errorf("provider not declared: error = %v, want one naming SILO_RECOMMENDATIONS_PROVIDER", err) } + + // A stored binding the document can't have broken, such as one a restore + // into another deployment left naming a provider that's gone, doesn't stop + // startup; one to a declared provider that can't serve it does. + if _, err := CheckDeploymentSettings(map[string]string{config.AITextProviderSettingKey: "openai-1a2b3c"}, env, declared, "SILO_CONFIG_FILE", false); err != nil { + t.Errorf("stored binding to a missing provider: %v", err) + } + if _, err := CheckDeploymentSettings(map[string]string{config.AITextProviderSettingKey: "local-embed"}, env, declared, "SILO_CONFIG_FILE", false); err == nil || !strings.Contains(err.Error(), "SILO_CONFIG_FILE") { + t.Errorf("stored binding to a declared provider that can't serve it: error = %v, want one naming SILO_CONFIG_FILE", err) + } + // The same holds with no document, when only the variables touch the + // bindings, and for a text binding the ChatGPT plan leaves idle. + connected := config.AIProviderRegistry{Providers: []config.AIProvider{embed}}.Encode() + if _, err := CheckDeploymentSettings(map[string]string{config.AIProvidersSettingKey: connected, config.AITextProviderSettingKey: "openai-1a2b3c"}, env, nil, "", false); err != nil { + t.Errorf("variables only, stored binding to a missing provider: %v", err) + } + if _, err := CheckDeploymentSettings(map[string]string{config.AIAuthModeSettingKey: "chatgpt", config.AITextProviderSettingKey: "local-embed"}, env, declared, "SILO_CONFIG_FILE", false); err != nil { + t.Errorf("idle text binding under the ChatGPT plan: %v", err) + } } // A provider the deployment declares is listed with its variable, and the diff --git a/internal/config/ai_providers.go b/internal/config/ai_providers.go index 44c6a2e486..6c84c5dbdf 100644 --- a/internal/config/ai_providers.go +++ b/internal/config/ai_providers.go @@ -418,6 +418,11 @@ func ValidateAIProviderBindings(values map[string]string) error { if id == "" { continue } + // The text binding is idle while the ChatGPT plan serves text, as in + // AIProviderUsers, so it needs no provider until the plan is left. + if binding.job == AIJobText && strings.TrimSpace(values[AIAuthModeSettingKey]) == aiAuthModeChatGPT { + continue + } provider, ok := registry.Find(id) if !ok { return fmt.Errorf("the %s provider %q is not connected", binding.label, id) diff --git a/web/src/pages/AdminRecommendations.tsx b/web/src/pages/AdminRecommendations.tsx index 41a7da6fd6..d51e355f14 100644 --- a/web/src/pages/AdminRecommendations.tsx +++ b/web/src/pages/AdminRecommendations.tsx @@ -378,23 +378,32 @@ export default function AdminRecommendations() { useEffect(() => { if (!settings) return; + // A key the environment sets takes the server's value over any draft, so + // a draft from before the takeover can't come back, and be saved on + // blur, once the variable is removed. + const managed = sensitiveData?.managed_by_env_vars ?? {}; const next: RecLocalValues = {}; for (const field of getAllRecommendationFields()) { if (field.type === "password" || field.type === "toggle") continue; const serverVal = settings[field.key] || field.defaultValue || ""; - if (!(field.key in localValues)) { + if (!(field.key in localValues) || managed[field.key]) { next[field.key] = serverVal; } } setLocalValues((prev) => { const merged: RecLocalValues = { ...prev }; for (const [key, value] of Object.entries(next)) { - if (!(key in merged)) { + if (!(key in merged) || managed[key]) { merged[key] = value; } } return merged; }); + setDirtyKeys((prev) => + [...prev].some((key) => managed[key]) + ? new Set([...prev].filter((key) => !managed[key])) + : prev, + ); // eslint-disable-next-line react-hooks/exhaustive-deps -- seeds only keys missing from localValues; depending on it would rerun on every edit }, [settings, sensitiveData]); From 8982f78009f6948083aea9f08fbf2605fdd2bfc1 Mon Sep 17 00:00:00 2001 From: Quick104 <31828688+Quick104@users.noreply.github.com> Date: Sat, 21 Nov 2026 03:23:05 +0000 Subject: [PATCH 11/11] chore(apiv2): drop the approvals #4757 left that this change doesn't use #4757 approved its own restore change enums, which main now has, so against main those approvals match nothing and the contract check refuses them. Co-Authored-By: Claude Opus 5.5 --- contracts/api/v2/breaking-approvals.json | 311 +---------------------- 1 file changed, 1 insertion(+), 310 deletions(-) diff --git a/contracts/api/v2/breaking-approvals.json b/contracts/api/v2/breaking-approvals.json index 8f8bdc1b10..08ac789b35 100644 --- a/contracts/api/v2/breaking-approvals.json +++ b/contracts/api/v2/breaking-approvals.json @@ -1,312 +1,3 @@ { - "approvals": [ - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "04893a4903cb32e93db8f53ca78507369c0090fb9434bdc27a8de73cfea46408", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "0640ac17953947c7cf8a021233021ba0b63257a6cd60777345d58c9a1cd73d31", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "0eb201b6c8fcb978e3f8d4043b3b025cd7a8194b32bb60a8675793658f16ba16", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "22b23b95e8386bc904c1d1496fe19b734f4db8a203ebc12322610e9efd8f04a3", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "2cc1b21bf7e5c5dfe5cdacddb6b05f728933d388e79ffeff8db9b1350c98e159", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "3cd452ed2c4b4f39c90014dec94498fbc26c5f3a92e4c9fb5e733ec21b1e975b", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "3cf289e9b77f4f30c39e0299dd56c922b95c1bf1b2913b8c1610da3d8499e518", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "45ad808ef852a80758bcf2a52a9eb803fa051661420fc4e1ca7fac348e8fb330", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "4d113f878b6a5a984970ffebaf3b5d44b9f3300f693f69f7d9dcb81846e06029", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "515c17343fb176bbc3f4bd8f83d7ff70f5082a4a67cfcdb3415a8a1f9859e561", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "5354d4218f29088dd60995f67b9305688ddeb2512237d315a86d40d4684efadc", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "535b1583e64cfa3862282a6d23f9a0155c13a1e19ec8dd8f14104873a0cb4506", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "64a111ac5c1b10aac3a66adc7f277669dff290006c160eaa99052e6955b4fa03", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "77f687943992cff51cd0a6665638f2f0761c93dabd8e2752ab511aa8c93f1d21", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "889177b078585e6930d8951b34e32af184ded7bafb0d87ef32ed104e0a32043c", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "93980f5715d6eed73c4695c363366ec95fe8c8f7090249c2931227a1bb538d2f", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "cb4f56ec73e069dfc5181951062ee8a49fb8da6338e82c946c83a0ff67bb5f4e", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "d11ad09ae2c119cae710d08a6152f2fb27e40c0b80430549b81ef319d0f1757b", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "d888874218dedb368705e1a83058b91ce3474cd9388e52130880ab756d054639", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "e392d86727872f9be9f15a4776330812e20fb402976281f4260c4ca6b5956962", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "f49144772bca3e7fe25089eb1f761fa834b02505ddc21d20a005c5531fff891a", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupUploadRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "f59900fbdec9eeaaa36055ad096a3144ab894db1146fed7b526fd780a02c4d04", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "0a908a853b27b557bac7cbed9e18eaa79607a633595d5c600869f405bd6619a7", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "1f081a9e8ae554fc3796b0f2dd276e7a76a73d731231203ee0d6eab47d79c127", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "3cfda317beaa61e3f6418a91f979b0dbebf5bae9382e037bcc5237cfe4c92989", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "4322f7e2eda949af6b584fb0c358107399b70304fec80cdce3890ce599df68b8", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "525ae100c57b281a3dd784c81ec704a1dc2f5520002c2a6dd5934cb29ee16c36", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "5e88e6c8140ce76c15caf4094e7bb91ff49a3878d1b798d3399bc4df385a8b8e", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "6126053e1117a34083030f41639e7a00753ebc87e703e8262af0f8e3b0c2fb92", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "6629c381edc0a2f6a34e693406c66e1338d454b2f3c8a82c49c1d15ceca0bcb1", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "6d35dc88858e9f71d49d1a2557b4fe244fd6f9332df5fa3e9b91ff1f386002a2", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "783b2ceb5c17f99a37f70ca56557023e51739243c2b3e857696684353cfa954d", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "8c63110ffb50638e230b407aac33a7a10c79ccbca15197b8849fabd3db0d14f3", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "920575d9028120baa304d17d2add72169d4fdf996870191102329a02e9769137", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "9278baf88e918940f1c80813e8cf7d839a42a87b31bbc6ce2f3e1e3a78bfce8f", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "94305e1ea3a2d496e14a9362fb3966be3dfda853faaf3bca0a8fee5a04cc19a3", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "9ca15be7fbe8673ff3f5cdc995d630b5e163b812de8f4c2a484b8ae8af9beb6b", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "b27759a5ad5115ab9b622f04505742c3c45147c664f05bacc83eefe736f8fdfd", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "b29239a0b91f2bd6991cfe24f2f2ed935599b74f9c80ddb3af40beb678e961f6", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "b3e08e56303617dff5992aada1f4b5a6bad2d284c90b8400c7b6d6f905c8ca72", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "b56fe69d4dcba185b3750f685e285ddc7f8ce9d2d4ea6c67e76b384a0572ef1f", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "c886ab23e8efc3cfc55778608b078f5e2063b7235be8c08cd3007667b82e9f82", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "e65ecdcc42e9dc7a7f606f14a333d0760110fc886d1ef4263c004ebc16e1c8a7", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - }, - { - "operation_id": "getAdminBackupRestoreSet", - "change_id": "response-property-enum-value-added", - "fingerprint": "fa82f174ee7896d7a5265070a2eac33017f5d55948111619c422f97ed4387f95", - "reason": "Selective restore change lists become declared codes that the web shows in the interface language, instead of English display words. Only the web restore flow reads them (silo-apple, silo-android and silo-roku have no backup restore screens); it is updated in the same change.", - "approved_in": "#4757" - } - ] + "approvals": [] }