SurfaceOperationalStatusV1Msg.getAirplaneLength and SurfaceOperationalStatusV1Msg.getAirplaneWidth are commented with
According to DO-260B Table 2-74. Compatible with ADS-B version 1 and 2
This is not wrong, but could be more elaborate:
Actually, code 0 meant something else for V1 (DO-260A). Now in DO-260B code 0 was redefined (see note below Table N-13) for V1 targets, arguing that there might be V1 transmitters using code 0 for what it was redefined now (i.e. "no data").
So the functions' return value is now compatible with v1 under a v2 decoder (which the lib1090 is), but only because of this redefinition.
Table N-13 should be mentioned as well, because Table 2-74 is only valid for V2, though its contents coincide with N-13.
Also, the comments do not carry the fact that length and width are not independent from each other but are chosen from a set of categories where the larger of length/width wins.
The comment does not even say that the return values are upper bounds.
Method getAirplaneWidth also misses mentioning special value -1
SurfaceOperationalStatusV1Msg.getAirplaneLengthandSurfaceOperationalStatusV1Msg.getAirplaneWidthare commented withThis is not wrong, but could be more elaborate:
Actually, code 0 meant something else for V1 (DO-260A). Now in DO-260B code 0 was redefined (see note below Table N-13) for V1 targets, arguing that there might be V1 transmitters using code 0 for what it was redefined now (i.e. "no data").
So the functions' return value is now compatible with v1 under a v2 decoder (which the lib1090 is), but only because of this redefinition.
Table N-13 should be mentioned as well, because Table 2-74 is only valid for V2, though its contents coincide with N-13.
Also, the comments do not carry the fact that length and width are not independent from each other but are chosen from a set of categories where the larger of length/width wins.
The comment does not even say that the return values are upper bounds.
Method
getAirplaneWidthalso misses mentioning special value-1