From 07d0f122422733b637416be524e36d35e59804e5 Mon Sep 17 00:00:00 2001 From: Deterous <138427222+Deterous@users.noreply.github.com> Date: Tue, 7 Jul 2026 15:38:15 +0900 Subject: [PATCH 1/3] Pre-compress subcode files with Zstd --- CHANGELIST.md | 3 +++ MPF.Processors/Redumper.cs | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELIST.md b/CHANGELIST.md index 138d1dc22..94df41831 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -1,3 +1,6 @@ +### WIP (xxxx-xx-xx) +- Pre-compress subcode files with Zstd + ### 3.8.3 (2026-07-06) - Add live tool output console for the Linux GUI (gmipf) diff --git a/MPF.Processors/Redumper.cs b/MPF.Processors/Redumper.cs index 930ec58e8..bafbebd68 100644 --- a/MPF.Processors/Redumper.cs +++ b/MPF.Processors/Redumper.cs @@ -127,6 +127,8 @@ public override void GenerateSubmissionInfo(SubmissionInfo info, PhysicalMediaTy _ = CompressZstandard($"{basePath}.skeleton"); if (File.Exists($"{basePath}.state")) _ = CompressZstandard($"{basePath}.state"); + if (File.Exists($"{basePath}.subcode")) + _ = CompressZstandard($"{basePath}.subcode"); // Pre-compress all skeletons for multi-track CDs if (File.Exists($"{basePath}.cue")) @@ -571,7 +573,7 @@ internal override List GetOutputFiles(PhysicalMediaType? mediaType, new($"{outputFilename}.state.zst", OutputFileFlags.Binary | OutputFileFlags.Zippable, "state_zst"), - new($"{outputFilename}.subcode", OutputFileFlags.Required + new([$"{outputFilename}.subcode", $"{outputFilename}.subcode.zst"], OutputFileFlags.Required | OutputFileFlags.Binary | OutputFileFlags.Zippable, "subcode"), From 707737ff1fba16a5ba2e74fcaee28a5efb53c3b2 Mon Sep 17 00:00:00 2001 From: Deterous <138427222+Deterous@users.noreply.github.com> Date: Tue, 7 Jul 2026 22:02:38 +0900 Subject: [PATCH 2/3] subcode isnt required --- CHANGELIST.md | 1 + MPF.Processors/Redumper.cs | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELIST.md b/CHANGELIST.md index 94df41831..0af9fddd8 100644 --- a/CHANGELIST.md +++ b/CHANGELIST.md @@ -1,4 +1,5 @@ ### WIP (xxxx-xx-xx) + - Pre-compress subcode files with Zstd ### 3.8.3 (2026-07-06) diff --git a/MPF.Processors/Redumper.cs b/MPF.Processors/Redumper.cs index bafbebd68..5a1dd342d 100644 --- a/MPF.Processors/Redumper.cs +++ b/MPF.Processors/Redumper.cs @@ -573,8 +573,10 @@ internal override List GetOutputFiles(PhysicalMediaType? mediaType, new($"{outputFilename}.state.zst", OutputFileFlags.Binary | OutputFileFlags.Zippable, "state_zst"), - new([$"{outputFilename}.subcode", $"{outputFilename}.subcode.zst"], OutputFileFlags.Required - | OutputFileFlags.Binary + new($"{outputFilename}.subcode", OutputFileFlags.Binary + | OutputFileFlags.Zippable, + "subcode"), + new($"{outputFilename}.subcode.zst", OutputFileFlags.Binary | OutputFileFlags.Zippable, "subcode"), new($"{outputFilename}.toc", OutputFileFlags.Required From 67c077f75da39cbe37c305d7a89f2c2d77a0361f Mon Sep 17 00:00:00 2001 From: Deterous <138427222+Deterous@users.noreply.github.com> Date: Tue, 7 Jul 2026 22:10:10 +0900 Subject: [PATCH 3/3] fix tests --- MPF.Processors.Test/RedumperTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MPF.Processors.Test/RedumperTests.cs b/MPF.Processors.Test/RedumperTests.cs index 8d234993f..9298cac4c 100644 --- a/MPF.Processors.Test/RedumperTests.cs +++ b/MPF.Processors.Test/RedumperTests.cs @@ -103,7 +103,7 @@ public void GetOutputFiles_CDROM_Populated() var processor = new Redumper(PhysicalSystem.IBMPCcompatible); var actual = processor.GetOutputFiles(PhysicalMediaType.CDROM, outputDirectory, outputFilename); - Assert.Equal(19, actual.Count); + Assert.Equal(20, actual.Count); } [Fact] @@ -161,7 +161,7 @@ public void FoundAllFiles_Invalid_Filled() string outputFilename = string.Empty; var processor = new Redumper(PhysicalSystem.IBMPCcompatible); var actual = processor.FoundAllFiles(PhysicalMediaType.CDROM, outputDirectory, outputFilename); - Assert.Equal(5, actual.Count); + Assert.Equal(4, actual.Count); } [Fact]