Skip to content

GrammarOK function differ from C# and C++ #2

Description

@mingodad

Comparing the TestSuite output between Java and C++ I noticed some differences and looking through the code and comparing with C# and C++ the Java version seems to be wrong:
This repo has this:

	public boolean GrammarOk() {
		boolean ok = NtsComplete()
			&& NoCircularProductions()
			&& AllNtToTerm();
		if (ok) { AllNtReached(); CheckResolvers(); CheckLL1(); }
		return ok;
	}

But accordling to C# and C++ it should be this:

	public boolean GrammarOk() {
		boolean ok = NtsComplete()
			&& AllNtReached()
			&& NoCircularProductions()
			&& AllNtToTerm();
		if (ok) { CheckResolvers(); CheckLL1(); }
		return ok;
	}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions