From 7fd218de949c402a68d440e7d59cfb3aa1717aa5 Mon Sep 17 00:00:00 2001 From: Matthew Tiscareno Date: Wed, 5 Nov 2025 17:15:44 -0800 Subject: [PATCH] First draft of ISS/VIMS review page --- .../coiss-covims-peer-reviews/NOTES.txt | 530 ++++++++++++++++++ .../coiss-review-chen-2019-10-11.txt | 35 ++ .../coiss-review-spitale-2019-12-13.txt | 3 + .../coiss-review-waldron-2019-10-10.txt | 43 ++ .../coiss-covims-peer-reviews/index.html | 53 ++ website/reviews/index.html | 1 + 6 files changed, 665 insertions(+) create mode 100644 website/reviews/coiss-covims-peer-reviews/NOTES.txt create mode 100644 website/reviews/coiss-covims-peer-reviews/coiss-review-chen-2019-10-11.txt create mode 100644 website/reviews/coiss-covims-peer-reviews/coiss-review-spitale-2019-12-13.txt create mode 100644 website/reviews/coiss-covims-peer-reviews/coiss-review-waldron-2019-10-10.txt create mode 100755 website/reviews/coiss-covims-peer-reviews/index.html diff --git a/website/reviews/coiss-covims-peer-reviews/NOTES.txt b/website/reviews/coiss-covims-peer-reviews/NOTES.txt new file mode 100644 index 000000000..d75d193c1 --- /dev/null +++ b/website/reviews/coiss-covims-peer-reviews/NOTES.txt @@ -0,0 +1,530 @@ + +cassini_iss_cruise/bundle.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:mission.cassini +- This file and collection_data_raw.xml both have lid_reference to + urn:nasa:pds:context:target:planetary_system.jupiter_system +Mitch has discussed this, as this doesn't exist yet. Your call. + +cassini_iss_cruise/data_raw/.../*.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:cassini_iss_cruise:data_raw:cum-index +Only bundle.xml does not have it. +- For the , disp:horizontal_display_axis and +disp:vertical_display_axis should have the values of + Array_2D_Image/Axis_Array/axis_name, e.g. Line +not + Array_2D_Image/Axis_Array/sequence_number, e.g. 1 +I.e. change + 2 + 1 +to + Sample + Line +- If you want tools to visualize the (not the ), +add 1) Array_2D/local_identifier and 2) a second disp:Display_Settings +with local_identifier_reference set to the new local_identifier. + +cassini_iss_cruise/data_raw/13699xxxxx/1369908674n.xml & 77 others +- These have lid_reference to + urn:nasa:pds:context:target:star_cluster.pleiades +LIDs for star clusters are based on simbad. For the Pleiades, + urn:nasa:pds:context:target:star_cluster.cl_melotte_22 + +cassini_iss_cruise/data_raw/13735xxxxx/1373566539n.xml & 11 others +- These have lid_reference to + urn:nasa:pds:context:target:star.cw_leo +LIDs for stars are based on simbad. For CW Leo, the LID will be + urn:nasa:pds:context:target:star.irc_+10216 + +cassini_iss_cruise/data_raw/13738xxxxx/1373843727w.xml & 294 others +- These have lid_reference to + urn:nasa:pds:context:target:star.78_tau +Per simbad, use + urn:nasa:pds:context:target:star.tet02_tau + +cassini_iss_cruise/data_raw/13903xxxxx/1390389694n.xml & many others +- The value is illegal. + +Perhaps it should be CRUISE SCIENCE like the others + +cassini_iss_cruise/data_raw/14053xxxxx/1405398456n.xml & 180 others +- These have lid_reference to + urn:nasa:pds:context:target:sun.sun +Per Guide to PDS4 Context Products V1.4 17 May 2019, use + urn:nasa:pds:context:target:star.sun +though we have no context product yet + +cassini_iss_cruise//data_raw/14057xxxxx/1405767110w.xml +cassini_iss_cruise//data_raw/14057xxxxx/1405779412w.xml +- These have lid_reference to + urn:nasa:pds:context:target:star.nml_tau +Per simbad, use + urn:nasa:pds:context:target:star.ik_tau + +cassini_iss_cruise/data_raw/collection_data_raw.xml & 2129 others +- These have lid_reference to + urn:nasa:pds:context:target:ring.saturn_rings +No context products for type=ring exist yet. As in the type=planetary_system +debate, if there will later be context products for the individual rings, e.g. + urn:nasa:pds:context:target:ring.saturn.f_ring +there is no good mechanism for associating the two. + +cassini_iss_cruise/document/collection_document.csv +- Line 1 has a typo (urn:urn:nasa:): + S,urn:urn:nasa:pds:cassini_iss_saturn:document:iss-data-user-guide + +cassini_iss_cruise/metadata_raw/ +- This directory needs a collection.xml and .csv +- PDS Standards' Table 2B-1 lists allowable top-level directories, and this is +not there. miscellaneous/ seems appropriate: "A miscellaneous collection +contains supplementary information deemed by the data provider to be useful +in the interpretation and use of other collections in the bundle but which +does not fit within the scope of the other collections. For example, +meta-data catalogs, data base dumps, and records of modification history +could be included." + +cassini_iss_cruise/xml_schema/collection_xml_schema.csv +- The VID seems low in + S,urn:nasa:pds:system_bundle:xml_schema:cassini-xml_schema::1.13 +The PDS4_CASSINI_* files provided in the top-level schema/ is newer than +the version at pds.nasa.gov, which has VID 1.17. + + + +cassini_iss_saturn/browse_raw/collection_browse_raw.csv +- Lines 399874 and 399875 are: + P,urn:nasa:pds:cassini_iss_saturn:browse_raw:1877548388n-full::1.0 + P,urn:nasa:pds:cassini_iss_saturn:browse_raw:1881830414n-full::1.0 +I.e. the collection.csv is missing 4184 with LIDs + urn:nasa:pds:cassini_iss_saturn:browse_raw:1877634459n-full to + urn:nasa:pds:cassini_iss_saturn:browse_raw:1881830006n-full + +cassini_iss_saturn/bundle.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:mission.cassini +- This file and collection_data_raw.xml both have lid_reference to + urn:nasa:pds:context:target:planetary_system.saturn_system +Mitch has discussed this, as this doesn't exist yet. Your call. + +cassini_iss_saturn/data_raw/.../*.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:cassini_iss_saturn:data_raw:cum-index +Only bundle.xml does not have it (assuming collection.xml had a typo) +- For the , disp:horizontal_display_axis and +disp:vertical_display_axis should have the values of + Array_2D_Image/Axis_Array/axis_name, e.g. Line +not + Array_2D_Image/Axis_Array/sequence_number, e.g. 1 +I.e. change + 2 + 1 +to + Sample + Line +- If you want tools to visualize the (not the ), +add 1) Array_2D/local_identifier and 2) a second disp:Display_Settings +with local_identifier_reference set to the new local_identifier. + +cassini_iss_saturn/data_raw/14595xxxxx/1459575784n.xml & 119525 others +- These have lid_reference to + urn:nasa:pds:context:target:ring.saturn_rings +No context products for type=ring exist yet. As in the type=planetary_system +debate, if there will later be context products for the individual rings, e.g. + urn:nasa:pds:context:target:ring.saturn.f_ring +there is no good mechanism for associating the two. + +cassini_iss_saturn/data_raw/15530xxxxx/1553075119n.xml & 5 others +- These have lid_reference to + urn:nasa:pds:context:target:star.bet_sgr +Simbad only has these as separate stars, so please use + urn:nasa:pds:context:target:star.bet01_sgr + urn:nasa:pds:context:target:star.bet02_sgr + +cassini_iss_saturn/data_raw/14631xxxxx/1463134433w.xml & 84 others +- These have lid_reference to + urn:nasa:pds:context:target:star.cw_leo +LIDs for stars are based on simbad. For CW Leo, the LID will be + urn:nasa:pds:context:target:star.irc_+10216 + +cassini_iss_saturn/data_raw/14619xxxxx/1461910009n.xml & 796 others +- These have lid_reference to + urn:nasa:pds:context:target:star.hr_996 +Per simbad, please use + urn:nasa:pds:context:target:star.kap01_cet + +cassini_iss_saturn/data_raw/18821xxxxx/1882154660n.xml & 55 others +- These have lid_reference to + urn:nasa:pds:context:target:star.lmc_303 +What is that? LMC is a galaxy. What is LMC 303? Is it a star? Simbad doesn't +know about it. Is it a star cluster? PDS needs a naming convention for this. + +cassini_iss_saturn/data_raw/15411xxxxx/1541120829n.xml +cassini_iss_saturn/data_raw/15411xxxxx/1541134395n.xml +- These have lid_reference to + urn:nasa:pds:context:target:star.mu_psa +Per simbad, please use + urn:nasa:pds:context:target:star.mu._psa + +cassini_iss_saturn/data_raw/15800xxxxx/1580047528n.xml & 11 others +- These have lid_reference to + urn:nasa:pds:context:target:star.nu_cen +Per simbad, please use + urn:nasa:pds:context:target:star.nu._cen + +cassini_iss_saturn/data_raw/collection_data_raw.xml +- This has lid_reference to + urn:nasa:pds:cassini_iss_cruise:data_raw:cum-index +Assuming there is a ...:cum-index, it should presumably be + urn:nasa:pds:cassini_iss_saturn:data_raw:cum-index +- Like the browse collection, this collection.csv is missing 4184 with LIDs + urn:nasa:pds:cassini_iss_saturn:data_raw:1877634459n to + urn:nasa:pds:cassini_iss_saturn:data_raw:1881830006n + +cassini_iss_saturn/document/collection_document.csv +- For Primary members, VIDs are required, i.e. + P,urn:nasa:pds:cassini_iss_saturn:document:iss-data-user-guide + P,urn:nasa:pds:cassini_iss_saturn:document:iss-na-camera-description + P,urn:nasa:pds:cassini_iss_saturn:document:iss-wa-camera-description +should be + P,urn:nasa:pds:cassini_iss_saturn:document:iss-data-user-guide::1.0 + P,urn:nasa:pds:cassini_iss_saturn:document:iss-na-camera-description::1.0 + P,urn:nasa:pds:cassini_iss_saturn:document:iss-wa-camera-description::1.0 + +cassini_iss_saturn/metadata_raw/ +- This directory needs a collection.xml and .csv +- PDS Standards' Table 2B-1 lists allowable top-level directories, and this is +not there. miscellaneous/ seems appropriate: "A miscellaneous collection +contains supplementary information deemed by the data provider to be useful +in the interpretation and use of other collections in the bundle but which +does not fit within the scope of the other collections. For example, +meta-data catalogs, data base dumps, and records of modification history +could be included." + +cassini_iss_saturn/xml_schema/collection_xml_schema.csv +- The VID seems low in + S,urn:nasa:pds:system_bundle:xml_schema:cassini-xml_schema::1.13 +The PDS4_CASSINI_* files provided in the top-level schema/ is newer than +the version at pds.nasa.gov, which has VID 1.17. + + + +cassini_vims_cruise/browse_raw/collection_browse_raw.csv +- Its entries don't match the labels' LIDs. Here: + P,urn:nasa:pds:cassini_vims_cruise:browse_raw:1294638283-full::1.0 + P,urn:nasa:pds:cassini_vims_cruise:browse_raw:1294638377-full::1.0 + ... +The files' LIDs: + urn:nasa:pds:cassini_vims_cruise:browse_raw:1294638283-full.png + urn:nasa:pds:cassini_vims_cruise:browse_raw:1294638377-full.png + ... + +cassini_vims_cruise/*.xml +- Is this LID defined somewhere? Every label but bundle.xml has lid_reference + urn:nasa:pds:cassini_vims_saturn:document:vims-description +There is a file in the other bundle with LID + urn:nasa:pds:cassini_vims_saturn:document:vims_instrument_description + +cassini_vims_cruise/bundle.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:mission.cassini +- This file and collection_data_raw.xml both have lid_reference to + urn:nasa:pds:context:target:planetary_system.jupiter_system +Mitch has discussed this, as this doesn't exist yet. Your call. + +cassini_vims_cruise/context/collection_context.xml +- urn:nasa:pds:cassini_vims_saturn:context +should presumably be + urn:nasa:pds:cassini_vims_cruise:context + +cassini_vims_cruise/data_raw/collection_data_raw.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:cassini_vims_saturn:data_raw:cum-index +I also didn't see urn:nasa:pds:cassini_vims_cruise:data_raw:cum-index defined. + +cassini_vims_cruise/data_raw/.../*.xml +- For the , disp:horizontal_display_axis and +disp:vertical_display_axis should have the values of + Array_3D_Spectrum/Axis_Array/axis_name, e.g. Line +not + Array_3D_Spectrum/Axis_Array/sequence_number, e.g. 1 +I.e. change + 3 + 1 +to + Sample + Line +- If you want tools to visualize the s correctly, +add more disp:Display_Settings with local_identifier_reference set appropriately + +cassini_vims_cruise/data_raw/13552xxxxx/1355233813.xml & 2174 others +- These have lid_reference to + urn:nasa:pds:context:target:ring.saturn_rings +No context products for type=ring exist yet. As in the type=planetary_system +debate, if there will later be context products for the individual rings, e.g. + urn:nasa:pds:context:target:ring.saturn.f_ring +there is no good mechanism for associating the two. + +cassini_vims_cruise/data_raw/13733xxxxx/1373351740.xml & 105 others +- These have lid_reference to + urn:nasa:pds:context:target:sun.sun +Per Guide to PDS4 Context Products V1.4 17 May 2019, use + urn:nasa:pds:context:target:star.sun +though we have no context product yet + +cassini_vims_cruise/data_raw/13736xxxxx/1373668788.xml & 6 others +- These have lid_reference to + urn:nasa:pds:context:target:star_cluster.pleiades +LIDs for star clusters are based on simbad. For the Pleiades, + urn:nasa:pds:context:target:star_cluster.cl_melotte_22 + +cassini_vims_cruise/data_raw/14056xxxxx/1405644685-v1.xml +cassini_vims_cruise/data_raw/14056xxxxx/1405644685-v2.xml +cassini_vims_cruise/data_raw/14056xxxxx/1405644685-v3.xml +& 392 other triples down to 1405763738 +- The LIDs don't match what's in collection_data_raw.csv, which has + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1405644685-v1::1.0 + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1405644685-v2::1.0 + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1405644685-v3::1.0 +while these three files have the same one LID + urn:nasa:pds:cassini_vims_cruise:data_raw:1405644685 +but different VIDs 1.0, 2.0, 3.0. So, if there should only be 1 version, +delete two of the .xml files (and their .qub files) and fix the collection.csv. +Else if all 3 versions are meant to be delivered, fix the collection.csv to: + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1405644685::1.0 + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1405644685::2.0 + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1405644685::3.0 +which seems less likely. + +cassini_vims_cruise/data_raw/14132xxxxx/1413246503-v1.xml +cassini_vims_cruise/data_raw/14132xxxxx/1413246503-v2.xml +& 4 other pairs down to 1444713101 +- The LIDs don't match what's in collection_data_raw.csv, which has + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1413246503-v1::1.0 + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1413246503-v2::1.0 +while these two files have the same one LID + urn:nasa:pds:cassini_vims_cruise:data_raw:1413246503 +but different VIDs 1.0, 2.0. So, if there should only be 1 version, +delete one of the .xml files (and its .qub file) and fix the collection.csv. +Else if both versions are meant to be delivered, fix the collection.csv to: + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1413246503::1.0 + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1413246503::2.0 +which seems less likely. + +cassini_vims_cruise/document/collection_document.xml +- urn:nasa:pds:cassini_vims_saturn:document +should presumably be + urn:nasa:pds:cassini_vims_cruise:document + +cassini_vims_cruise/xml_schema/collection_xml_schema.xml +- urn:nasa:pds:cassini_vims_saturn:xml_schema +should presumably be + urn:nasa:pds:cassini_vims_cruise:xml_schema + +cassini_vims_cruise/metadata_raw/ +- This directory needs a collection.xml and .csv +- PDS Standards' Table 2B-1 lists allowable top-level directories, and this is +not there. miscellaneous/ seems appropriate: "A miscellaneous collection +contains supplementary information deemed by the data provider to be useful +in the interpretation and use of other collections in the bundle but which +does not fit within the scope of the other collections. For example, +meta-data catalogs, data base dumps, and records of modification history +could be included." +- This directory has only 1 data file. The other bundles' metadata_raw +each has 4. + +cassini_vims_cruise/xml_schema/collection_xml_schema.csv +- The VID seems low in + S,urn:nasa:pds:system_bundle:xml_schema:cassini-xml_schema::1.13 +The PDS4_CASSINI_* files provided in the top-level schema/ is newer than +the version at pds.nasa.gov, which has VID 1.17. +- To match the .xsd and the .sch on https://pds.nasa.gov/schema/released/sp/, + S,urn:nasa:pds:system_bundle:xml_schema:sp-xml_schema::1.11 +should have VID 1.17. + + + +cassini_vims_saturn/*.xml +- Is this LID defined somewhere? Every label but bundle.xml has lid_reference + urn:nasa:pds:cassini_vims_saturn:document:vims-description +There is a file with LID + urn:nasa:pds:cassini_vims_saturn:document:vims_instrument_description + +cassini_vims_saturn/browse_raw/collection_browse_raw.csv +- Its entries don't match the labels' LIDs. Here: + P,urn:nasa:pds:cassini_vims_saturn:browse_raw:1454811589-full::1.0 + P,urn:nasa:pds:cassini_vims_saturn:browse_raw:1454811659-full::1.0 + ... +The files' LIDs: + urn:nasa:pds:cassini_vims_saturn:browse_raw:1454811589-full.png + urn:nasa:pds:cassini_vims_saturn:browse_raw:1454811659-full.png + ... + +cassini_vims_saturn/bundle.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:mission.cassini +- This file and collection_data_raw.xml both have lid_reference to + urn:nasa:pds:context:target:planetary_system.saturn_system +Mitch has discussed this, as this doesn't exist yet. Your call. + +cassini_vims_saturn/data_raw/.../*.xml +- For the , disp:horizontal_display_axis and +disp:vertical_display_axis should have the values of + Array_3D_Spectrum/Axis_Array/axis_name, e.g. Line +not + Array_3D_Spectrum/Axis_Array/sequence_number, e.g. 1 +I.e. change + 3 + 1 +to + Sample + Line +- If you want tools to visualize the s correctly, +add more disp:Display_Settings with local_identifier_reference set appropriately + +cassini_vims_saturn/data_raw/collection_data_raw.xml +- Is this LID defined somewhere? It's fine as long as someone will define it. + urn:nasa:pds:cassini_vims_saturn:data_raw:cum-index + +cassini_vims_saturn/data_raw/14548xxxxx/1454811589.xml & 127542 others +- These have lid_reference to + urn:nasa:pds:context:target:ring.saturn_rings +No context products for type=ring exist yet. As in the type=planetary_system +debate, if there will later be context products for the individual rings, e.g. + urn:nasa:pds:context:target:ring.saturn.f_ring +there is no good mechanism for associating the two. + +cassini_vims_saturn/data_raw/14656xxxxx/1465673806-v1.xml +cassini_vims_saturn/data_raw/14656xxxxx/1465673806-v2.xml +& 22 other pairs down to 1825945979 +- The LIDs don't match what's in collection_data_raw.csv, which has + P,urn:nasa:pds:cassini_vims_saturn:data_raw:1465673806-v1::1.0 + P,urn:nasa:pds:cassini_vims_saturn:data_raw:1465673806-v2::1.0 +while these two files have the same one LID + urn:nasa:pds:cassini_vims_saturn:data_raw1465673806: +but different VIDs 1.0, 2.0. So, if there should only be 1 version, +delete one of the .xml files (and its .qub file) and fix the collection.csv. +Else if both versions are meant to be delivered, fix the collection.csv to: + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1465673806::1.0 + P,urn:nasa:pds:cassini_vims_cruise:data_raw:1465673806::2.0 +which seems less likely. + +cassini_vims_saturn/data_raw/14673xxxxx/1467344835_001-v1.xml +cassini_vims_saturn/data_raw/14673xxxxx/1467344835_001-v2.xml +& many other tuples down to 1787306770_044 +- These have the same problem as above, but it's harder to see because +the both the .xml files' LIDs and collection.csv account for the _001, +but collection.csv again incorrectly accounts for VIDs. + +cassini_vims_saturn/data_raw/14785xxxxx/1478539143.xml & 74239 others +- These have lid_reference to + urn:nasa:pds:context:target:sun.sun +Per Guide to PDS4 Context Products V1.4 17 May 2019, use + urn:nasa:pds:context:target:star.sun +though we have no context product yet + +cassini_vims_saturn/data_raw/14953xxxxx/1495314769.xml & 2596 others + urn:nasa:pds:context:target:star.cw_leo +- These have lid_reference to + urn:nasa:pds:context:target:star.mu_psa +Per simbad, please use + urn:nasa:pds:context:target:star.mu._psa + +cassini_vims_saturn/data_raw/15036xxxxx/1503621071.xml & 59 others +- These have lid_reference to + urn:nasa:pds:context:target:star_cluster.pleiades +LIDs for star clusters are based on simbad. For the Pleiades, + urn:nasa:pds:context:target:star_cluster.cl_melotte_22 + +cassini_vims_saturn/data_raw/15039xxxxx/1503902475.xml & 1109 others +- These have lid_reference to + urn:nasa:pds:context:target:star.r_lyr +Per simbad, please use + urn:nasa:pds:context:target:star.13_lyr + +cassini_vims_saturn/data_raw/15174xxxxx/1517491644.xml & 33 others +- These have lid_reference to + urn:nasa:pds:context:target:star.mu_gem +Per simbad, please use + urn:nasa:pds:context:target:star.mu._gem + +cassini_vims_saturn/data_raw/15329xxxxx/1532905421.xml & 54 others +- These have lid_reference to + urn:nasa:pds:context:target:star.30_her +Per simbad, please use + urn:nasa:pds:context:target:star.g_her + +cassini_vims_saturn/data_raw/15329xxxxx/1532915621.xml % 559 others +- These have lid_reference to + urn:nasa:pds:context:target:star.mu_cep +Per simbad, please use + urn:nasa:pds:context:target:star.mu._cep + +cassini_vims_saturn/data_raw/15329xxxxx/1532925821.xml & 43 others +- These have lid_reference to + urn:nasa:pds:context:target:star.pi1_gru +Per simbad, please use + urn:nasa:pds:context:target:star.pi.01_gru + +cassini_vims_saturn/data_raw/15525xxxxx/1552575925.xml & 39 others +- These have lid_reference to + urn:nasa:pds:context:target:star.nu_vir +Per simbad, please use + urn:nasa:pds:context:target:star.nu._vir + +cassini_vims_saturn/data_raw/15737xxxxx/1573706260.xml & 503 others +- These have lid_reference to + urn:nasa:pds:context:target:star.2_cen +Per simbad, please use + urn:nasa:pds:context:target:star.g_cen + +cassini_vims_saturn/data_raw/16239xxxxx/1623910216.xml & 3 others +- These have lid_reference to + urn:nasa:pds:context:target:star.hr_996 +Per simbad, please use + urn:nasa:pds:context:target:star.kap01_cet + +cassini_vims_saturn/data_raw/18683xxxxx/1868307851.xml +- This file was truncated at 4165 bytes on the drive I received. + +cassini_vims_saturn/metadata_raw/ +- This directory needs a collection.xml and .csv +- PDS Standards' Table 2B-1 lists allowable top-level directories, and this is +not there. miscellaneous/ seems appropriate: "A miscellaneous collection +contains supplementary information deemed by the data provider to be useful +in the interpretation and use of other collections in the bundle but which +does not fit within the scope of the other collections. For example, +meta-data catalogs, data base dumps, and records of modification history +could be included." + +cassini_vims_saturn/xml_schema/collection_xml_schema.csv +- The VID seems low in + S,urn:nasa:pds:system_bundle:xml_schema:cassini-xml_schema::1.13 +The PDS4_CASSINI_* files provided in the top-level schema/ is newer than +the version at pds.nasa.gov, which has VID 1.17. +- To match the .xsd and the .sch on https://pds.nasa.gov/schema/released/sp/, + S,urn:nasa:pds:system_bundle:xml_schema:sp-xml_schema::1.11 +should have VID 1.17. + + + +schema/PDS4_Cassini_1B00_1300.* +- These files are newer than (i.e. have not yet appeared at) the ones at + https://pds.nasa.gov/datastandards/schema/released +Please ensure that these are the right version. + +schema/PDS4_SP_1B00_1100.xsd +- This differs slightly from + https://pds.nasa.gov/datastandards/schema/released/sp/v1/PDS4_SP_1B00_1100.xsd +Please use the one from the web site. Same for the .sch. The .xml wasn't included. + + + +generally +- EN (and the DPH) recommends that the Root Tag include: + xmlns:pds="http://pds.nasa.gov/pds4/pds/v1" +This has been debated, and there is no consequence for ignoring. +- EN similarly recommends, with no consequence for ignoring, that in order +to create a fully self-describing bundle, context/ contain secondary copies +of context products referred to and xml_schema/ contain secondary copies of +the schema and schematron used. diff --git a/website/reviews/coiss-covims-peer-reviews/coiss-review-chen-2019-10-11.txt b/website/reviews/coiss-covims-peer-reviews/coiss-review-chen-2019-10-11.txt new file mode 100644 index 000000000..df8e0cd24 --- /dev/null +++ b/website/reviews/coiss-covims-peer-reviews/coiss-review-chen-2019-10-11.txt @@ -0,0 +1,35 @@ +From: Chen, Richard L (US 398G) +Sent: Friday, October 11, 2019 12:13 PM +To: Waldron, Anna (US 398F) ; Mitchell Gordon ; De Cesare, Cristina M (US 398G) ; Michael Evans +Cc: Lynn Neakrase ; Padams, Jordan (US 398A) +Subject: Re: [EXTERNAL] Cassini ISS & VIMS per review + +Hi, Anna, I'm with the Engineering Node. My comments: + +> ERROR [error.label.context_ref_not_found] Context product not found: urn:nasa:pds:context:target:planetary_system.jupiter_system + +1) Mitch and Lynn, did we agree that this context product would eventually and painfully list all the component targets, giving EN's search a path to return products that reference either the component or the aggregation? +2) If so, does anyone object (or volunteer) if I create a barren target:planetary_system target now with the understanding that we'll add the components later when the schema/schematron allow it? +3) Should the last part of the LID be jupiter_system or jupiter? I mildly vote for the latter. + +> urn:nasa:pds:context:target:ring.saturn_rings +Mitch sent me this context product a while ago, but for type=ring, I expected LIDs like + urn:nasa:pds:context:target:ring.f_ring + urn:nasa:pds:context:target:ring.g_ring +IMO, the latter set is good because the DPH says so. Is the aggregated LID good as well? If so, 1) the schema/schematron will someday have to allow components later, and 2) anyone object if I rush one out there? I imagine either could be no, as I'm expecting some or maybe all of you to see clearer about this. + +> urn:nasa:pds:context:target:calibration_field.star +Mitch sent me this context product a while ago, and I suggested changing the LID and the name to ...:calibration_field.starfield and "Star Field" (from "Star"). I generally don't like giving one thing, especially as secondary as this, the name of something so generic. Right? Someone searching for "star x" is going to get this and probably the products that reference this as search results. Or maybe I'm wrong. You can argue me out of most stuff. + +> urn:nasa:pds:context:target:star.r_leo +We'll add this context product with LID as you have it in the next go-around. We usually don't add a context product until someone requests it. + +> There were many “Context reference name mismatch” warnings where the name didn’t match exactly what was expected but was close enough to have the same meaning so I’m not sure these are crucial. +I barely remember any mention of formation rules for names, unlike LIDs, which we're burned out on. We, PDS-wide, should think about what to do, now that validate checks for this. We have many all-caps names, which seems wrong. Minimum: I can generate a list of all LIDs, names, proposed new names. Maximum: formation rules for names + discussion of what to do with existing, non-conforming names and the products that use them. If the latter has a good chance of ever happening, we should do it rather than the minimum. + +For the two names you gave that raised errors, Anna, I would keep the ones you have and live with such warnings. + +> There were some repeated label errors where attributes appear to have been left empty. The attributes this occurred for were 'cassini:mission_phase_name' and 'cassini:observation_id'. +I didn't have your .xml (or the .sch and .xsd) files, but the messages are legit if you've got those elements with no value or all white space values. Are the rules misfiring? + +Richard diff --git a/website/reviews/coiss-covims-peer-reviews/coiss-review-spitale-2019-12-13.txt b/website/reviews/coiss-covims-peer-reviews/coiss-review-spitale-2019-12-13.txt new file mode 100644 index 000000000..a6b0a4192 --- /dev/null +++ b/website/reviews/coiss-covims-peer-reviews/coiss-review-spitale-2019-12-13.txt @@ -0,0 +1,3 @@ +Hi Mike and Mitch, I have had a look at the data throughout the week and I have not found any obvious problems. I loaded about 40000 images spanning the entire data set (cruise and saturn) and viewed them as thumbnails (subsampled from the full images), and I also viewed a few thousand at full res. I also read the NAC and WAC descriptions, which I found very useful. The only issue I found there was a missing apostrophe in "don't" in the same section in each file (lines 276 and 273 in the na and wa files respectively). Finally I did some spot checks (a few hundred images) on the phase angles in the body and ring geometry tables and found good agreement. I looked at phase angles because they are not very sensitive to precisely where you're looking on the body, and to what ephemeris is used, and it was a comparison I could do relatively quickly. Note that I used the vicar headers and did not evaluate the xml headers. + +-joe diff --git a/website/reviews/coiss-covims-peer-reviews/coiss-review-waldron-2019-10-10.txt b/website/reviews/coiss-covims-peer-reviews/coiss-review-waldron-2019-10-10.txt new file mode 100644 index 000000000..66bd912a3 --- /dev/null +++ b/website/reviews/coiss-covims-peer-reviews/coiss-review-waldron-2019-10-10.txt @@ -0,0 +1,43 @@ +From: Waldron, Anna (US 398F) +Sent: Thursday, October 10, 2019 10:49 AM +To: De Cesare, Cristina M (US 398G) ; Michael Evans +Cc: Mitchell Gordon +Subject: Re: [EXTERNAL] Cassini ISS & VIMS per review + +Mitch and Mike, here is a summary of the some of the validate errors we found. We also were unable to find a SIS in the bundle. + +There were many “'Context product not found” errors in all collections – I wasn’t sure if these are due to a problem in our validate configuration though. +· ERROR [error.label.context_ref_not_found] Context product not found: urn:nasa:pds:context:target:planetary_system.jupiter_system +· Other references that weren’t found included these examples and many similar ones: +urn:nasa:pds:context:target:ring.saturn_rings +urn:nasa:pds:context:target:calibration_field.star +urn:nasa:pds:context:target:star.r_leo + +There were many “Context reference name mismatch” warnings where the name didn’t match exactly what was expected but was close enough to have the same meaning so I’m not sure these are crucial. +· This warning came up many times in both ISS collections: +WARNING [warning.label.context_ref_mismatch] Context reference name mismatch. Value: 'Cassini Orbiter Imaging Science Subsystem - Narrow Angle Camera' Expected one of: '[IMAGING SCIENCE SUBSYSTEM - NARROW ANGLE]' +WARNING [warning.label.context_ref_mismatch] Context reference name mismatch. Value: 'Cassini Orbiter Imaging Science Subsystem - Wide Angle Camera' Expected one of: '[IMAGING SCIENCE SUBSYSTEM - WIDE ANGLE]' +This warnings appeared many times in both VIMS collections: +WARNING [warning.label.context_ref_mismatch] line 81: Context reference name mismatch. Value: 'Cassini Orbiter Visual And Infrared Mapping Spectrometer' Expected one of: '[VISUAL AND INFRARED MAPPING SPECTROMETER]' + +There were some repeated label errors where attributes appear to have been left empty. The attributes this occurred for were 'cassini:mission_phase_name' and 'cassini:observation_id'. +These errors appeared multiple times in the ISS_Cruise collection: +o ERROR [error.label.schema] line 95, 49: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'mission_phase_name'. +o ERROR [error.label.schema] line 95, 49: cvc-type.3.1.3: The value '' of element 'cassini:mission_phase_name' is not valid. +o ERROR [error.label.schematron] line 95, 49: The attribute cassini:mission_phase_name must be equal to one of the following values 'APPROACH SCIENCE', 'APPROACH_SCIENCE', 'Approach Science', 'Approach_Science', 'CRUISE SCIENCE', 'EARTH ENCOUNTER', 'EARTH-JUPITER CRUISE', 'EQUINOX MISSION', 'EXTENDED MISSION', 'EXTENDED-EXTENDED MISSION', 'Earth Encounter', 'Equinox Mission', 'Extended Mission', 'Extended-Extended Mission', 'HIGH GAIN ANTENNA TRANSITION', 'HUYGENS DESCENT', 'HUYGENS PROBE SEPARATION', 'High Gain Antenna Transition', 'Huygens Descent', 'Huygens Probe Separation', 'INSTRUMENT CHECKOUT 1', 'INSTRUMENT CHECKOUT 2', 'INTERPLANETARY CRUISE', 'Information not provided', 'Instrument Checkout 1', 'Instrument Checkout 2', 'Interplanetary Cruise', 'JUPITER CRUISE', 'JUPITER ENCOUNTER', 'Jupiter Cruise', 'Jupiter Encounter', 'LAUNCH', 'Launch', 'OUTER CRUISE', 'Outer Cruise', 'PHOEBE ENCOUNTER', 'PROXIMAL ORBITS', 'Phoebe Encounter', 'Proximal Orbits', 'QUIET CRUISE', 'Quiet Cruise', 'SATURN ORBIT INSERTION', 'SCIENCE CRUISE', 'SCIENCE_CRUISE', 'SOLSTICE MISSION', 'SPACE SCIENCE', 'SPACE_SCIENCE', 'Saturn Orbit Insertion', 'Science Cruise', 'Solstice Mission', 'Space Science', 'TCM 1', 'TITAN A ENCOUNTER', 'TITAN B ENCOUNTER', 'TITAN C HUYGENS', 'TOUR', 'TOUR PRE-HUYGENS', 'Titan A Encounter', 'Titan B Encounter', 'Titan C Huygens', 'Tour', 'Tour Pre-Huygens', 'VENUS 1 CRUISE', 'VENUS 1 ENCOUNTER', 'VENUS 2 - EARTH CRUISE', 'VENUS 2 ENCOUNTER', 'Venus 1 Cruise', 'Venus 1 Encounter', 'Venus 2 - Earth Cruise', 'Venus 2 Encounter'. +o ERROR [error.label.schema] line 140, 45: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'observation_id'. +o ERROR [error.label.schema] line 140, 45: cvc-type.3.1.3: The value '' of element 'cassini:observation_id' is not valid. + +· These errors appeared in both VIMS collections: +o ERROR [error.label.schema] line 147, 45: cvc-minLength-valid: Value '' with length = '0' is not facet-valid with respect to minLength '1' for type 'observation_id'. +o ERROR [error.label.schema] line 147, 45: cvc-type.3.1.3: The value '' of element 'cassini:observation_id' is not valid. + + +Anna + +Anna Waldron +Scientific Applications Software Engineer (398F) +Instrument Software and Science Data Systems +p: (818) 393-5727 m: (802) 540-5837 +a: T1721-109B +e: anna.waldron@jpl.nasa.gov diff --git a/website/reviews/coiss-covims-peer-reviews/index.html b/website/reviews/coiss-covims-peer-reviews/index.html new file mode 100755 index 000000000..7b09e6969 --- /dev/null +++ b/website/reviews/coiss-covims-peer-reviews/index.html @@ -0,0 +1,53 @@ + + +Cassini ISS/VIMS Peer Reviews + + + + +

Cassini ISS and VIMS Migration Peer Reviews

+Mike Evans and Mitch Gordon
+December 13, 2019 + +

Background

+

+These data sets were previously archived by the PDS Imaging Node under PDS3. This project was migration to PDS4, performed by the PDS Ring-Moon Systems Node. These four PDS4 bundles contain the raw data sets for the Cassini Imaging Science Subsystem (ISS) and the Cassini Visual and Infrared Mapping Spectrometer (VIMS). +

+

+The reviews were conducted largely by email. Responses from the reviewers are below. +

+ +

Data Bundle

+

See v1.0 archived versions of these bundles.

+ +

Reviewers Anna Waldron and Cristina de Cesare provided Validate logs for all four bundles, available here. +

+ +

Instructions for Reviewers

+

+Instructions to reviewers have not been preserved. They may have been given verbally. +

+ +

Reviewers' Submitted Comments

+ + +

Initial Responses

+ +

Review Outcome

+ +
+Ring-Moon Systems Node Home + + diff --git a/website/reviews/index.html b/website/reviews/index.html index d6540885c..6f71d7580 100755 --- a/website/reviews/index.html +++ b/website/reviews/index.html @@ -24,6 +24,7 @@

Rings Node Peer Reviews

Completed PDS4 peer reviews:

Completed PDS3 peer reviews, listed here for historical purposes: