Skip to content

Commit 331cfb6

Browse files
committed
refactor(dpi_ng): incorporating review comments
1 parent 9d18924 commit 331cfb6

68 files changed

Lines changed: 302 additions & 221 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.env_integration_tests.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ CLOUD_SDK_CFG_SDM_DEFAULT_URI=https://your-sdm-api-uri-here
5858
CLOUD_SDK_CFG_SDM_DEFAULT_UAA='{"url":"https://your-auth-url","clientid":"your-client-id","clientsecret":"your-client-secret","identityzone":"your-identity-zone"}'
5959

6060
# DPI NG - CONSENT
61-
# Required for all consent integration tests
61+
# Required for all dpi_ng integration tests
6262
CLOUD_SDK_CFG_DPI_NG_DEFAULT_BASE_URL=https://your-dpi-ng-service-host
6363

6464
# Pick ONE of the three auth methods below:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Each module has comprehensive usage guides:
8181
- [Telemetry](src/sap_cloud_sdk/core/telemetry/user-guide.md)
8282
- [Print](src/sap_cloud_sdk/print/user-guide.md)
8383
- [Data Anonymization](src/sap_cloud_sdk/core/data_anonymization/user-guide.md)
84-
- [Data Privacy Integration](src/sap_cloud_sdk/core/dpi_ng/consent/user-guide.md)
84+
- [Data Privacy Integration](src/sap_cloud_sdk/dpi_ng/consent/user-guide.md)
8585

8686
## Support, Feedback, Contributing
8787

docs/INTEGRATION_TESTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ uv run pytest tests/core/integration/auditlog -v
204204
uv run pytest tests/core/integration/data_anonymization -v
205205
uv run pytest tests/destination/integration/ -v
206206
uv run pytest tests/dms/integration/ -v
207-
uv run pytest tests/core/integration/dpi_ng/consent/ -v
207+
uv run pytest tests/dpi_ng/integration/consent/ -v
208208
uv run pytest tests/objectstore/integration/ -v
209209
```
210210

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
33
Shared building blocks for all DPI NG capabilities:
44
5-
- :mod:`sap_cloud_sdk.core.dpi_ng.auth` — AuthProvider ABC + strategies
6-
- :mod:`sap_cloud_sdk.core.dpi_ng.config` — BaseCapabilityConfig
7-
- :mod:`sap_cloud_sdk.core.dpi_ng.exceptions` — DPINGError hierarchy
8-
- :mod:`sap_cloud_sdk.core.dpi_ng.odata_client` — BaseODataClient
5+
- :mod:`sap_cloud_sdk.dpi_ng.auth` — AuthProvider ABC + strategies
6+
- :mod:`sap_cloud_sdk.dpi_ng.config` — BaseCapabilityConfig
7+
- :mod:`sap_cloud_sdk.dpi_ng.exceptions` — DPINGError hierarchy
8+
- :mod:`sap_cloud_sdk.dpi_ng.odata_client` — BaseODataClient
99
"""
1010

1111
from .auth import (

src/sap_cloud_sdk/core/dpi_ng/consent/__init__.py renamed to src/sap_cloud_sdk/dpi_ng/consent/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
33
Quickstart::
44
5-
from sap_cloud_sdk.core.dpi_ng.consent import create_client, BearerTokenAuth
5+
from sap_cloud_sdk.dpi_ng.consent import create_client, BearerTokenAuth
66
77
with create_client(
88
base_url="https://api.service.<region>.ngdpi.dpp.cloud.sap",
@@ -17,7 +17,7 @@
1717

1818
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
1919

20-
from sap_cloud_sdk.core.dpi_ng.auth import (
20+
from sap_cloud_sdk.dpi_ng.auth import (
2121
AuthProvider,
2222
BearerTokenAuth,
2323
ClientCertificateAuth,
@@ -31,7 +31,7 @@
3131
ConsentTemplateService,
3232
)
3333
from .config import ConsentConfig
34-
from sap_cloud_sdk.core.dpi_ng.exceptions import (
34+
from sap_cloud_sdk.dpi_ng.exceptions import (
3535
AuthenticationError,
3636
AuthorizationError,
3737
ClientCreationError,

src/sap_cloud_sdk/core/dpi_ng/consent/client.py renamed to src/sap_cloud_sdk/dpi_ng/consent/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import logging
66
from typing import Callable
77

8-
from sap_cloud_sdk.core.dpi_ng.odata_client import BaseODataClient
8+
from sap_cloud_sdk.dpi_ng.odata_client import BaseODataClient
99

1010
logger = logging.getLogger(__name__)
1111

src/sap_cloud_sdk/core/dpi_ng/consent/config.py renamed to src/sap_cloud_sdk/dpi_ng/consent/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import logging
44
from dataclasses import dataclass
55

6-
from sap_cloud_sdk.core.dpi_ng.config import BaseCapabilityConfig
6+
from sap_cloud_sdk.dpi_ng.config import BaseCapabilityConfig
77

88
logger = logging.getLogger(__name__)
99

File renamed without changes.

0 commit comments

Comments
 (0)