With the refactor of SimulationEngine in #2735, HerdFactory is now initialized with simulate_animals which is derived from the SimulationType enum grouping.
3 things to work on in this issue:
- If
simulate_animals is False, do we need to be initializing a HerdManager at all?
- If we don't need a
HerdManager when simulate_animals is False, does HerdManager need to know the value of simulate_animals or can it be assumed that when it's initialized at any point, simulate_animals is True?
- There is logic in
HerdManager that handles simulate_animals that should be addressed/removed if HerdManager doesn't need simulate_animals.
Please investigate.
With the refactor of
SimulationEnginein #2735,HerdFactoryis now initialized withsimulate_animalswhich is derived from theSimulationTypeenum grouping.3 things to work on in this issue:
simulate_animalsisFalse, do we need to be initializing aHerdManagerat all?HerdManagerwhensimulate_animalsisFalse, doesHerdManagerneed to know the value ofsimulate_animalsor can it be assumed that when it's initialized at any point,simulate_animalsisTrue?HerdManagerthat handlessimulate_animalsthat should be addressed/removed ifHerdManagerdoesn't needsimulate_animals.Please investigate.