From 36c02f8634b7d05a54f0c633f2b9709c35368deb Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 18 Oct 2026 08:24:16 +0000 Subject: [PATCH 1/3] Bump image_processing from 1.14.0 to 2.2.0 and add ruby-vips image_processing 2.0 made mini_magick and ruby-vips soft dependencies, so the plain Dependabot bump (#32) silently dropped ruby-vips. Active Storage uses the vips processor/analyzer by default, so add ruby-vips explicitly to keep treasure_image analysis and any variants working. mini_magick stays dropped since nothing uses it. Supersedes #32. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01UZdu9KhK3eVCqk8Tdwm6tA --- Gemfile | 4 +++- Gemfile.lock | 12 ++++-------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Gemfile b/Gemfile index ce5bd27..a3f7309 100644 --- a/Gemfile +++ b/Gemfile @@ -38,7 +38,9 @@ gem "kamal", require: false gem "thruster", require: false # Use Active Storage variants [https://guides.rubyonrails.org/active_storage_overview.html#transforming-images] -gem "image_processing", "~> 1.2" +gem "image_processing", "~> 2.2" +# image_processing 2.x no longer pulls in a backend; Active Storage defaults to vips +gem "ruby-vips" # Error tracking and logging [https://rollbar.com] gem "rollbar" diff --git a/Gemfile.lock b/Gemfile.lock index 71f3424..a63c11d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -144,9 +144,7 @@ GEM herb (0.11.0-x86_64-linux-musl) i18n (1.15.2) concurrent-ruby (~> 1.0) - image_processing (1.14.0) - mini_magick (>= 4.9.5, < 6) - ruby-vips (>= 2.0.17, < 3) + image_processing (2.2.0) imagen (0.2.0) parser (>= 2.5, != 2.5.1.1) importmap-rails (2.2.3) @@ -188,8 +186,6 @@ GEM net-smtp marcel (1.2.1) matrix (0.4.3) - mini_magick (5.3.1) - logger mini_mime (1.1.5) mini_portile2 (2.8.9) minitest (6.0.6) @@ -438,7 +434,7 @@ DEPENDENCIES csv debug herb (~> 0.11.0) - image_processing (~> 1.2) + image_processing (~> 2.2) importmap-rails jbuilder kamal @@ -449,6 +445,7 @@ DEPENDENCIES rails (~> 8.1.1) rollbar rubocop-rails-omakase + ruby-vips selenium-webdriver simplecov simplecov-lcov @@ -522,7 +519,7 @@ CHECKSUMS herb (0.11.0-x86_64-linux-gnu) sha256=aba19094bc1618e1bc0fb59db52ba251c93a24598f5228815616b282f10bb8a0 herb (0.11.0-x86_64-linux-musl) sha256=e27a08fe72304c8043e851b568ed30eaa45f06b5333d151939a7834e936c01aa i18n (1.15.2) sha256=00f9eb62412fe593b2a65a97daa75300d37abb8f7202ec748e94b6d46a9dd1b5 - image_processing (1.14.0) sha256=754cc169c9c262980889bec6bfd325ed1dafad34f85242b5a07b60af004742fb + image_processing (2.2.0) sha256=e0cb9892a4395ac2b7bb2fac5c6f5bc63361f2f18ed08773e21fce5b111c6974 imagen (0.2.0) sha256=369fe912078877dba92615ebfc6f35a7d833e31f24f47bdd3ad5371a4139e24b importmap-rails (2.2.3) sha256=7101be2a4dc97cf1558fb8f573a718404c5f6bcfe94f304bf1f39e444feeb16a io-console (0.9.4) sha256=a403304f32928ee85e56d457b4612ca43f2703b561a3258844992bd24085fbb1 @@ -537,7 +534,6 @@ CHECKSUMS mail (2.9.1) sha256=06574eca475253d6c18145dd70af80d0eb970182d55053497c5f4d797ea160e8 marcel (1.2.1) sha256=1678e9360e32f9eafa917c80029e2f6d10b2715c66a4b87b6d0da9b9cd1f859f matrix (0.4.3) sha256=a0d5ab7ddcc1973ff690ab361b67f359acbb16958d1dc072b8b956a286564c5b - mini_magick (5.3.1) sha256=29395dfd76badcabb6403ee5aff6f681e867074f8f28ce08d78661e9e4a351c4 mini_mime (1.1.5) sha256=8681b7e2e4215f2a159f9400b5816d85e9d8c6c6b491e96a12797e798f8bccef mini_portile2 (2.8.9) sha256=0cd7c7f824e010c072e33f68bc02d85a00aeb6fce05bb4819c03dfd3c140c289 minitest (6.0.6) sha256=153ea36d1d987a62942382b61075745042a2b3123b1cd48f4c3675af9cc7d6f1 From 87c49a99fb2a66682687ac04d2778287df5332ff Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 18 Oct 2026 08:25:18 +0000 Subject: [PATCH 2/3] Log Dependabot batch and image_processing 2.x soft-dependency pitfall Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01UZdu9KhK3eVCqk8Tdwm6tA --- .claude/docs/log.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.claude/docs/log.md b/.claude/docs/log.md index f3ac9bc..37e5870 100644 --- a/.claude/docs/log.md +++ b/.claude/docs/log.md @@ -287,3 +287,10 @@ Comprehensive improvement session covering security, testing, performance, and U - **Promjena**: uklonjeni `force_ruby_platform: true` za nokogiri, ffi i herb (i direktne `nokogiri`/`ffi` Gemfile linije koje su postojale samo zbog toga). `Gemfile.lock` dobija prebuilt Linux varijante za iste verzije (nokogiri 1.19.4, ffi 1.17.3, herb 0.11.0); izbačen zastarjeli `tzinfo-data` spec (gem je samo za windows/jruby, nema te platforme u lock-u). - **Validacija (lokalno, Ruby 3.4.11, svjež `vendor/bundle`)**: frozen install instalira `x86_64-linux-gnu` binarije i sva tri se učitavaju; rubocop, brakeman, bundler-audit, importmap audit, `herb analyze`, 419 tests i 9 system tests green. - **Pravilo iz 2026-10-03 (herb CI fix) više ne važi**: novi native gem-ovi ne trebaju `force_ruby_platform` na stabilnom Ruby-ju. + +## 2026-10-18 — Dependabot batch: 10 PR-ova landano + +- **Merge-ovano (squash)**: #38 brakeman 8.1.0, #37 pg 1.7.0, #36 thruster 0.1.27, #35 solid_queue 1.7.0, #33 selenium-webdriver 4.51.0, #31 web-console 4.3.0, #30 rollbar 3.8.0, #29 bootsnap 1.26.0 i #34 webmock 3.34.0 (zadnja dva nakon `@dependabot rebase` zbog Gemfile.lock konflikta; webmock je pri rebase-u skočio na 3.34.0). +- **#34 system-test**: prvi run pao na `test_user_can_logout` ("Logout" nije pronađen); poslije rebase-a zelen, ostali PR-ovi na istom base-u zeleni. Nije reproducirano. +- **#32 image_processing 2.2.0 → zamijenjen sa #39**: image_processing 2.0 je `mini_magick` i `ruby-vips` napravio *soft* dependency-jima, pa je goli bump tiho izbacio `ruby-vips` iz bundle-a. Active Storage koristi vips za analizu i varijante — `Hunt#treasure_image` bi izgubio metadata, a buduća `.variant` bi pukla; CI to ne pokriva. #39 dodaje `gem "ruby-vips"` eksplicitno (libvips je već u Dockerfile-u i CI-u). +- **Pravilo**: kod major bump-a gem-a provjeri da li je izbacio tranzitivne dependency-je iz `Gemfile.lock` (`-` linije bez `+` parnjaka) i da li ih aplikacija implicitno koristi. From b3197b9793beb5aa3db65f35b8fcf0ee6bc6919b Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 18 Oct 2026 08:27:16 +0000 Subject: [PATCH 3/3] Load ruby-vips lazily so the app boots without libvips A bare `gem "ruby-vips"` is loaded by Bundler.require at boot, which crashes when libvips is not installed (CI scan_js job). Active Storage already requires ruby-vips itself behind a LoadError rescue, so `require: false` restores the previous behaviour of image_processing 1.x, where ruby-vips was only a transitive dependency. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01UZdu9KhK3eVCqk8Tdwm6tA --- .claude/docs/log.md | 2 +- Gemfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.claude/docs/log.md b/.claude/docs/log.md index 37e5870..f429f4a 100644 --- a/.claude/docs/log.md +++ b/.claude/docs/log.md @@ -292,5 +292,5 @@ Comprehensive improvement session covering security, testing, performance, and U - **Merge-ovano (squash)**: #38 brakeman 8.1.0, #37 pg 1.7.0, #36 thruster 0.1.27, #35 solid_queue 1.7.0, #33 selenium-webdriver 4.51.0, #31 web-console 4.3.0, #30 rollbar 3.8.0, #29 bootsnap 1.26.0 i #34 webmock 3.34.0 (zadnja dva nakon `@dependabot rebase` zbog Gemfile.lock konflikta; webmock je pri rebase-u skočio na 3.34.0). - **#34 system-test**: prvi run pao na `test_user_can_logout` ("Logout" nije pronađen); poslije rebase-a zelen, ostali PR-ovi na istom base-u zeleni. Nije reproducirano. -- **#32 image_processing 2.2.0 → zamijenjen sa #39**: image_processing 2.0 je `mini_magick` i `ruby-vips` napravio *soft* dependency-jima, pa je goli bump tiho izbacio `ruby-vips` iz bundle-a. Active Storage koristi vips za analizu i varijante — `Hunt#treasure_image` bi izgubio metadata, a buduća `.variant` bi pukla; CI to ne pokriva. #39 dodaje `gem "ruby-vips"` eksplicitno (libvips je već u Dockerfile-u i CI-u). +- **#32 image_processing 2.2.0 → zamijenjen sa #39**: image_processing 2.0 je `mini_magick` i `ruby-vips` napravio *soft* dependency-jima, pa je goli bump tiho izbacio `ruby-vips` iz bundle-a. Active Storage koristi vips za analizu i varijante — `Hunt#treasure_image` bi izgubio metadata, a buduća `.variant` bi pukla; CI to ne pokriva. #39 dodaje `gem "ruby-vips", require: false` eksplicitno — `require: false` je obavezan: Active Storage sam radi `require "ruby-vips"` uz `rescue LoadError`, a goli gem bi se učitao kroz `Bundler.require` i srušio boot gdje nema libvips-a (CI `scan_js`). - **Pravilo**: kod major bump-a gem-a provjeri da li je izbacio tranzitivne dependency-je iz `Gemfile.lock` (`-` linije bez `+` parnjaka) i da li ih aplikacija implicitno koristi. diff --git a/Gemfile b/Gemfile index a3f7309..97e7e33 100644 --- a/Gemfile +++ b/Gemfile @@ -40,7 +40,7 @@ gem "thruster", require: false # Use Active Storage variants [https://guides.rubyonrails.org/active_storage_overview.html#transforming-images] gem "image_processing", "~> 2.2" # image_processing 2.x no longer pulls in a backend; Active Storage defaults to vips -gem "ruby-vips" +gem "ruby-vips", require: false # Error tracking and logging [https://rollbar.com] gem "rollbar"