From a811e1a0b2214599be5f9307f381a7263051ac8a Mon Sep 17 00:00:00 2001 From: "@mrubens" <2600+mrubens@users.noreply.github.com> Date: Mon, 21 Sep 2026 22:42:20 +0000 Subject: [PATCH] test(db): avoid environment factory name collisions --- .../factories/environment.factory.test.ts | 17 +++++++++++++++++ .../fixtures/factories/environment.factory.ts | 3 ++- 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 packages/db/src/fixtures/factories/environment.factory.test.ts diff --git a/packages/db/src/fixtures/factories/environment.factory.test.ts b/packages/db/src/fixtures/factories/environment.factory.test.ts new file mode 100644 index 0000000000..aebf6e49a9 --- /dev/null +++ b/packages/db/src/fixtures/factories/environment.factory.test.ts @@ -0,0 +1,17 @@ +import { environmentFactory } from './environment.factory'; + +describe('environmentFactory', () => { + it('generates distinct default names', () => { + const environments = environmentFactory.buildList(2); + + expect( + new Set(environments.map((environment) => environment.name)).size, + ).toBe(2); + }); + + it('preserves an explicitly provided name', () => { + const environment = environmentFactory.build({ name: 'test environment' }); + + expect(environment.name).toBe('test environment'); + }); +}); diff --git a/packages/db/src/fixtures/factories/environment.factory.ts b/packages/db/src/fixtures/factories/environment.factory.ts index 2c50e5ac43..8091664a5e 100644 --- a/packages/db/src/fixtures/factories/environment.factory.ts +++ b/packages/db/src/fixtures/factories/environment.factory.ts @@ -23,7 +23,8 @@ export const environmentFactory = Factory.define< return inserted; }); - const envName = params.name || faker.lorem.words(2); + const envName = + params.name ?? `${faker.lorem.words(2)}-${faker.string.uuid()}`; return { userId: params.userId,