From 6b8914faace7bf13a0ec36afa335f317e93c2f9d Mon Sep 17 00:00:00 2001
From: WheresAlice <WheresAlice@users.noreply.github.com>
Date: Fri, 7 Aug 2020 17:36:35 +0100
Subject: [PATCH 1/4] Template for new dataset PRs

---
 .github/PULL_REQUEST_TEMPLATE/new-data.md | 47 +++++++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 .github/PULL_REQUEST_TEMPLATE/new-data.md

diff --git a/.github/PULL_REQUEST_TEMPLATE/new-data.md b/.github/PULL_REQUEST_TEMPLATE/new-data.md
new file mode 100644
index 0000000..15b76f1
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE/new-data.md
@@ -0,0 +1,47 @@
+<!---
+Provide a short summary in the Title above. Examples of good PR titles:
+* "Feature: add so-and-so dataset"
+* "Fix: deduplicate such-and-such"
+* "Update: pandas version 0.13.0"
+-->
+
+# Description & motivation
+<!---
+Describe your changes, and why you're making them. Is this linked to an open
+issue, a Trello card, or another pull request? Link it here.
+-->
+
+# To-do before merge
+<!---
+(Optional -- remove this section if not needed)
+Include any notes about things that need to happen before this PR is merged, e.g.:
+- [ ] Update Observable documents
+- [ ] Ensure PR #56 is merged
+-->
+
+# Newly introduced datasets:
+<!---
+Describe any new datasets being added, detailing the sources and licenses
+-->
+
+# Changes to existing datasets:
+<!---
+Include this section if you are changing any existing datasets in cleaned_data or analysis.
+Link any related pull requests elsewhere, or instructions for merge (e.g. what else needs
+updating along with this change)
+-->
+
+# Checklist:
+<!---
+This checklist is mostly useful as a reminder of small things that can easily be
+forgotten – it is meant as a helpful tool rather than hoops to jump through.
+Put an `x` in all the items that apply, make notes next to any that haven't been
+addressed, and remove any items that are not relevant to this PR.
+-->
+
+- [ ] README files have been created and updated (including listings)
+- [ ] We have a license to use any new datasets being added
+- [ ] CI tests have passed
+- [ ] Great Expectations tests have been added
+- [ ] There are unit tests added where appropriate
+- [ ] Any scripts are reproducible - returning the same results each run
\ No newline at end of file

From de113ec4af6ae9b8133e3ea531307f52e63fa3d1 Mon Sep 17 00:00:00 2001
From: Dr Kim Foale <kim@gfsc.studio>
Date: Tue, 11 Aug 2020 14:04:26 +0100
Subject: [PATCH 2/4] Change PR template to make it more in line with RL needs

---
 .github/PULL_REQUEST_TEMPLATE/new-data.md | 41 ++++++++++++++---------
 1 file changed, 25 insertions(+), 16 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE/new-data.md b/.github/PULL_REQUEST_TEMPLATE/new-data.md
index 15b76f1..ec1a30a 100644
--- a/.github/PULL_REQUEST_TEMPLATE/new-data.md
+++ b/.github/PULL_REQUEST_TEMPLATE/new-data.md
@@ -1,36 +1,45 @@
 <!---
 Provide a short summary in the Title above. Examples of good PR titles:
-* "Feature: add so-and-so dataset"
-* "Fix: deduplicate such-and-such"
-* "Update: pandas version 0.13.0"
+* "New data request: add deaths in police custody datasets"
 -->
 
-# Description & motivation
+# Goal & possible research questions
 <!---
 Describe your changes, and why you're making them. Is this linked to an open
 issue, a Trello card, or another pull request? Link it here.
--->
 
-# To-do before merge
-<!---
-(Optional -- remove this section if not needed)
-Include any notes about things that need to happen before this PR is merged, e.g.:
-- [ ] Update Observable documents
-- [ ] Ensure PR #56 is merged
+ * Goal: what you want to do with this dataset, e.g. "Look at patterns in deaths following police custody"
+ * Research questions: what kinds of questions you might want to answer with this if you know, e.g. "Find out corrolation between race and deaths in police custody". This isn't essential but helps us plan what we call things and where we put them.
+ * Suggested path: what do you think this set should be called? E.g. 'deaths-following-police-contact'.
 -->
 
-# Newly introduced datasets:
+# Newly introduced dataset(s):
 <!---
-Describe any new datasets being added, detailing the sources and licenses
+Describe any new datasets being added, detailing the formats, sources and licenses (if you know). If you are adding more than one dataset, let us know if they should be added in separate places or combined together.
+
+Example:
+
+ * License: None stated, presume OGL?
+ * URL: https://policeconduct.gov.uk/research-and-learning/statistics/annual-deaths-during-or-following-police-contact-statistics
+ * File format: ODS
 -->
 
-# Changes to existing datasets:
+# Impact on existing dataset(s):
 <!---
-Include this section if you are changing any existing datasets in cleaned_data or analysis.
+Include this section if you are changing or adding to any existing datasets.
 Link any related pull requests elsewhere, or instructions for merge (e.g. what else needs
 updating along with this change)
 -->
 
+# To-do before merge
+<!---
+(Optional -- remove this section if not needed)
+Include any notes about things that need to happen before this PR is merged, e.g.:
+- [ ] Update Observable documents
+- [ ] Confirm license
+- [ ] Ensure PR #56 is merged
+-->
+
 # Checklist:
 <!---
 This checklist is mostly useful as a reminder of small things that can easily be
@@ -44,4 +53,4 @@ addressed, and remove any items that are not relevant to this PR.
 - [ ] CI tests have passed
 - [ ] Great Expectations tests have been added
 - [ ] There are unit tests added where appropriate
-- [ ] Any scripts are reproducible - returning the same results each run
\ No newline at end of file
+- [ ] Any scripts are reproducible - returning the same results each run

From 3165845e8d8319a867efaa0e19337bb78183894a Mon Sep 17 00:00:00 2001
From: Dr Kim Foale <kim@gfsc.studio>
Date: Tue, 11 Aug 2020 14:05:57 +0100
Subject: [PATCH 3/4] Add compulsory fields

---
 .github/PULL_REQUEST_TEMPLATE/new-data.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/.github/PULL_REQUEST_TEMPLATE/new-data.md b/.github/PULL_REQUEST_TEMPLATE/new-data.md
index ec1a30a..ea223e4 100644
--- a/.github/PULL_REQUEST_TEMPLATE/new-data.md
+++ b/.github/PULL_REQUEST_TEMPLATE/new-data.md
@@ -13,6 +13,10 @@ issue, a Trello card, or another pull request? Link it here.
  * Suggested path: what do you think this set should be called? E.g. 'deaths-following-police-contact'.
 -->
 
+ * Goal:
+ * Research question(s):
+ * Suggested path:
+
 # Newly introduced dataset(s):
 <!---
 Describe any new datasets being added, detailing the formats, sources and licenses (if you know). If you are adding more than one dataset, let us know if they should be added in separate places or combined together.
@@ -24,6 +28,10 @@ Example:
  * File format: ODS
 -->
 
+ * License:
+ * URL:
+ * File format:
+
 # Impact on existing dataset(s):
 <!---
 Include this section if you are changing or adding to any existing datasets.

From 4788431871f8e1b038d757738c1dbe68331b3b5a Mon Sep 17 00:00:00 2001
From: Dr Kim Foale <kim@gfsc.studio>
Date: Tue, 11 Aug 2020 14:07:39 +0100
Subject: [PATCH 4/4] Note that interfacing with other datasets will need extra
 consideration

---
 .github/PULL_REQUEST_TEMPLATE/new-data.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE/new-data.md b/.github/PULL_REQUEST_TEMPLATE/new-data.md
index ea223e4..5f054f8 100644
--- a/.github/PULL_REQUEST_TEMPLATE/new-data.md
+++ b/.github/PULL_REQUEST_TEMPLATE/new-data.md
@@ -9,7 +9,7 @@ Describe your changes, and why you're making them. Is this linked to an open
 issue, a Trello card, or another pull request? Link it here.
 
  * Goal: what you want to do with this dataset, e.g. "Look at patterns in deaths following police custody"
- * Research questions: what kinds of questions you might want to answer with this if you know, e.g. "Find out corrolation between race and deaths in police custody". This isn't essential but helps us plan what we call things and where we put them.
+ * Research questions: what kinds of questions you might want to answer with this if you know, e.g. "Find out corrolation between race and deaths in police custody". This isn't essential but helps us plan what we call things and where we put them, especially if you plan to use this in conjunction with other datasets.
  * Suggested path: what do you think this set should be called? E.g. 'deaths-following-police-contact'.
 -->