fix(ci): use 'sonar analyze --save' directly; agent-scan was a deleted skill-shell wrapper

The self-scan + parity workflows invoked '$SONAR_PREDICTOR_HOME/bin/sonar agent-scan analyze .',
but 'agent-scan' was never a CLI subcommand — it was a shell function defined inside the OLD
plugin/skills/sonar-predictor/bin/sonar wrapper that this branch deletes. The new distribution's
bin/sonar is a thin pass-through to the Java CLI, so the call now errors:

  Unmatched argument at index 0: 'agent-scan'
  Did you mean: sonar analyze?

Replace with the equivalent direct invocation:
  sonar --format json --save .sonar-predictor/scan.json analyze . --coverage <jacoco.xml>

--save was already a global option on the CLI (visible in sonar --help) — it captures the same
JSON the old wrapper redirected to scan.json. The downstream Render scan summary / Quality gate /
Upload artifact steps in both workflows already read .sonar-predictor/scan.json, so no change
needed there.

Author: aksOps

.github/workflows/parity.yml

@@ -114,8 +114,10 @@ jobs:
         run: |
           set +e
           export SONAR_PREDICTOR_HOME="$(pwd)/target/sonar-predictor-dist-${{ steps.version.outputs.version }}/sonar-predictor"
-          "$SONAR_PREDICTOR_HOME/bin/sonar" agent-scan analyze . \
-            --coverage target/site/jacoco/jacoco.xml
+          mkdir -p .sonar-predictor
+          "$SONAR_PREDICTOR_HOME/bin/sonar" \
+            --format json --save .sonar-predictor/scan.json \
+            analyze . --coverage target/site/jacoco/jacoco.xml
           rc=$?
           set -e
           echo "Self-scan exit code: $rc (0=clean, 1=issues found, 2+=tool error)"

.github/workflows/sonar.yml

@@ -84,13 +84,11 @@ jobs:
           echo "version=${VERSION}" >> "$GITHUB_OUTPUT"
           echo "Project version: ${VERSION}"
 
-      # The actual self-scan. We override SONAR_PREDICTOR_HOME so the wrapper
-      # script picks up THIS branch's freshly-built daemon jar and analyzer
-      # plugins from the assembly's exploded staging directory, not whatever
-      # happens to be installed globally. One JaCoCo XML is passed in as
-      # coverage evidence (single module = one report). agent-scan writes
-      # JSON to .sonar-predictor/scan.json and prints a human summary on
-      # stdout; we want both.
+      # The actual self-scan. We point bin/sonar at THIS branch's
+      # freshly-built distribution under target/ (not whatever happens to
+      # be installed globally), and capture the scan as JSON to
+      # .sonar-predictor/scan.json via --save. One JaCoCo XML is passed
+      # in as coverage evidence (single module = one report).
       #
       # IMPORTANT: the CLI uses three-state exit codes
       #   0 = clean (no findings at the floor)
@@ -104,8 +102,10 @@ jobs:
         run: |
           set +e
           export SONAR_PREDICTOR_HOME="$(pwd)/target/sonar-predictor-dist-${{ steps.version.outputs.version }}/sonar-predictor"
-          "$SONAR_PREDICTOR_HOME/bin/sonar" agent-scan analyze . \
-            --coverage target/site/jacoco/jacoco.xml
+          mkdir -p .sonar-predictor
+          "$SONAR_PREDICTOR_HOME/bin/sonar" \
+            --format json --save .sonar-predictor/scan.json \
+            analyze . --coverage target/site/jacoco/jacoco.xml
           rc=$?
           set -e
           echo "Self-scan exit code: $rc (0=clean, 1=issues found, 2+=tool error)"