feat: consolidate DeleteObject, validate window rects, expand tests

- Move DeleteObject P/Invoke onto the main [Native] class; drop the
  per-call SnipIT.Gdi Add-Type from Convert-BitmapToBitmapSource so
  bitmap cleanup compiles once per process, not per render.
- Reject degenerate RECTs from the GetWindowRect fallback in
  Show-SmartOverlay so a minimized / query-failed hwnd no longer
  produces a 0x0 hover overlay.
- Trace hotkey-registration failures through Write-SnipDiag so the
  tray balloon has a matching diagnostic record.
- Grow Test-SnipIT.ps1 from 40 to 65 cases: Resolve-SaveImagePath
  (9), Get-TrimmedRecent (5), Get-LoupePosition flip margins (3),
  extra format / capture-validity / crop edge cases (8).
- Add .github/workflows/test.yml: Linux job runs the headless suite,
  Windows job parses SnipIT.ps1 and runs the suite as well.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: aksOps

.github/workflows/test.yml

@@ -0,0 +1,41 @@
+name: test
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  workflow_dispatch:
+
+jobs:
+  headless:
+    name: Pure-logic tests (pwsh)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Show pwsh version
+        shell: pwsh
+        run: $PSVersionTable | Out-String
+      - name: Run headless tests
+        shell: pwsh
+        run: ./Test-SnipIT.ps1
+
+  parse:
+    name: Parse SnipIT.ps1 on Windows (no execution)
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Parse script
+        shell: pwsh
+        run: |
+          $errors = $null
+          [System.Management.Automation.Language.Parser]::ParseFile(
+            (Resolve-Path ./SnipIT.ps1), [ref]$null, [ref]$errors) | Out-Null
+          if ($errors) {
+            $errors | ForEach-Object { Write-Host "  $($_.Message)  at line $($_.Extent.StartLineNumber)" }
+            exit 1
+          }
+          Write-Host "Parsed cleanly."
+      - name: Run headless tests on Windows
+        shell: pwsh
+        run: ./Test-SnipIT.ps1

SnipIT.ps1

@@ -308,6 +308,9 @@ public static class Native {
 
     // Cursor pos in screen pixels
     [DllImport("user32.dll")] public static extern bool GetCursorPos(out POINT p);
+
+    // GDI cleanup for handles returned by Bitmap.GetHbitmap()
+    [DllImport("gdi32.dll")] public static extern bool DeleteObject(IntPtr hObject);
 }
 '@
 if (-not ('Native' -as [type])) {
@@ -477,12 +480,7 @@ function New-ScreenBitmap {
 
 function Convert-BitmapToBitmapSource {
     param([System.Drawing.Bitmap]$Bitmap)
-    # Cached P/Invoke; compile-once so cleanup is guaranteed (no JIT per call, no silent failure).
-    if (-not ('SnipIT.Gdi' -as [type])) {
-        Add-Type -Namespace SnipIT -Name Gdi -MemberDefinition @'
-[System.Runtime.InteropServices.DllImport("gdi32.dll")] public static extern bool DeleteObject(System.IntPtr hObject);
-'@
-    }
+    # DeleteObject lives on the main [Native] class defined at startup — no per-call JIT.
     $hbmp = [IntPtr]::Zero
     try {
         $hbmp = $Bitmap.GetHbitmap()
@@ -493,7 +491,7 @@ function Convert-BitmapToBitmapSource {
         $src.Freeze()
         return $src
     } finally {
-        if ($hbmp -ne [IntPtr]::Zero) { [SnipIT.Gdi]::DeleteObject($hbmp) | Out-Null }
+        if ($hbmp -ne [IntPtr]::Zero) { [Native]::DeleteObject($hbmp) | Out-Null }
     }
 }
 
@@ -713,9 +711,14 @@ function Show-SmartOverlay {
                 $r = New-Object Native+RECT
                 $ok = ([Native]::DwmGetWindowAttribute($top, [Native]::DWMWA_EXTENDED_FRAME_BOUNDS, [ref]$r, 16) -eq 0)
                 if (-not $ok) { [Native]::GetWindowRect($top, [ref]$r) | Out-Null }
-                $state.HoverRect = [pscustomobject]@{
-                    X = $r.Left; Y = $r.Top
-                    W = $r.Right - $r.Left; H = $r.Bottom - $r.Top
+                # Reject degenerate rects (minimized windows, failed fallback) — avoids a 0x0 hover overlay.
+                if ($r.Right -gt $r.Left -and $r.Bottom -gt $r.Top) {
+                    $state.HoverRect = [pscustomobject]@{
+                        X = $r.Left; Y = $r.Top
+                        W = $r.Right - $r.Left; H = $r.Bottom - $r.Top
+                    }
+                } else {
+                    $state.HoverRect = $null
                 }
             }
             if ($state.HoverRect) {
@@ -2131,6 +2134,7 @@ $tray.ContextMenuStrip = $menu
 $tray.Add_DoubleClick({ Invoke-SmartCapture })
 
 if ($hotkeyErrors.Count -gt 0) {
+    Write-SnipDiag "Hotkey registration failed: $($hotkeyErrors -join ', ')"
     $tray.BalloonTipTitle = 'SnipIT — hotkey conflict'
     $tray.BalloonTipText  = "Could not register: $($hotkeyErrors -join ', '). Use the tray menu instead."
     $tray.ShowBalloonTip(5000)

Test-SnipIT.ps1

@@ -173,6 +173,118 @@ It 'builds the launcher arg string with the script path quoted' {
     ShouldBeTrue ($a -match '-File "C:\\Users\\x\\AppData\\Local\\SnipIT\\SnipIT.ps1"')
 }
 
+Describe 'Resolve-SaveImagePath'
+It 'keeps a valid PNG path unchanged' {
+    ShouldBe (Resolve-SaveImagePath -Path '/tmp/a.png' -FilterFormat 'Png') '/tmp/a.png'
+}
+It 'keeps a valid JPG path unchanged even when filter is PNG' {
+    # User explicitly typed .jpg — respect their extension.
+    ShouldBe (Resolve-SaveImagePath -Path '/tmp/a.jpg' -FilterFormat 'Png') '/tmp/a.jpg'
+}
+It 'keeps a .jpeg extension (both supported jpeg forms)' {
+    ShouldBe (Resolve-SaveImagePath -Path '/tmp/a.jpeg' -FilterFormat 'Jpeg') '/tmp/a.jpeg'
+}
+It 'forces a non-image extension to match the PNG filter' {
+    $p = Resolve-SaveImagePath -Path '/tmp/a.txt' -FilterFormat 'Png'
+    ShouldBeTrue ($p.EndsWith('a.png'))
+}
+It 'forces a non-image extension to match the JPEG filter' {
+    $p = Resolve-SaveImagePath -Path '/tmp/a.txt' -FilterFormat 'Jpeg'
+    ShouldBeTrue ($p.EndsWith('a.jpg'))
+}
+It 'forces a non-image extension to match the BMP filter' {
+    $p = Resolve-SaveImagePath -Path '/tmp/a.txt' -FilterFormat 'Bmp'
+    ShouldBeTrue ($p.EndsWith('a.bmp'))
+}
+It 'appends the filter extension when path has no extension' {
+    $p = Resolve-SaveImagePath -Path '/tmp/a' -FilterFormat 'Png'
+    ShouldBeTrue ($p.EndsWith('a.png'))
+}
+It 'preserves the directory component when correcting extension' {
+    $p = Resolve-SaveImagePath -Path '/tmp/sub/foo.txt' -FilterFormat 'Bmp'
+    ShouldBeTrue ($p.EndsWith('foo.bmp'))
+    ShouldBeTrue ($p -like '*sub*foo.bmp')
+}
+It 'is case-insensitive for extension recognition' {
+    ShouldBe (Resolve-SaveImagePath -Path '/tmp/a.PNG' -FilterFormat 'Jpeg') '/tmp/a.PNG'
+}
+
+Describe 'Get-TrimmedRecent'
+It 'returns the input unchanged when under the cap' {
+    $r = Get-TrimmedRecent -Items @('c','b','a') -MaxDepth 10
+    ShouldBe $r.Count 3
+    ShouldBe $r[0] 'c'
+}
+It 'trims to the top N most recent when over cap' {
+    $items = 1..20                # 20 is top (most recent) by Stack.ToArray() convention
+    $r = Get-TrimmedRecent -Items $items -MaxDepth 5
+    ShouldBe $r.Count 5
+    ShouldBe $r[0] 1              # top-first ordering preserved
+    ShouldBe $r[4] 5
+}
+It 'returns empty array for null input' {
+    $r = Get-TrimmedRecent -Items $null
+    ShouldBe $r.Count 0
+}
+It 'handles empty array' {
+    $r = Get-TrimmedRecent -Items @() -MaxDepth 5
+    ShouldBe $r.Count 0
+}
+It 'exactly-at-cap returns the whole set' {
+    $r = Get-TrimmedRecent -Items (1..100) -MaxDepth 100
+    ShouldBe $r.Count 100
+}
+
+Describe 'Get-LoupePosition flip margins'
+It 'uses custom FlipMarginX when near right edge' {
+    $p = Get-LoupePosition -MouseX 1900 -MouseY 100 `
+        -VsX 0 -VsY 0 -VsWidth 1920 -VsHeight 1080 `
+        -LoupeWidth 170 -LoupeHeight 190 -FlipMarginX 20
+    # After flip: X = MouseX - LoupeWidth - FlipMarginX = 1900 - 170 - 20 = 1710
+    ShouldBe $p.X 1710
+}
+It 'uses custom FlipMarginY when near bottom edge' {
+    $p = Get-LoupePosition -MouseX 100 -MouseY 1070 `
+        -VsX 0 -VsY 0 -VsWidth 1920 -VsHeight 1080 `
+        -LoupeWidth 170 -LoupeHeight 190 -FlipMarginY 25
+    # After flip: Y = MouseY - LoupeHeight - FlipMarginY = 1070 - 190 - 25 = 855
+    ShouldBe $p.Y 855
+}
+It 'does not flip when loupe fits comfortably' {
+    $p = Get-LoupePosition -MouseX 500 -MouseY 500 `
+        -VsX 0 -VsY 0 -VsWidth 1920 -VsHeight 1080
+    ShouldBe $p.X 524
+    ShouldBe $p.Y 524
+}
+
+Describe 'Get-ImageFormatNameFromPath extra'
+It 'recognises uppercase .BMP' { ShouldBe (Get-ImageFormatNameFromPath 'x.BMP') 'Bmp' }
+It 'defaults .tiff to Png (unsupported)' { ShouldBe (Get-ImageFormatNameFromPath 'x.tiff') 'Png' }
+It 'handles dot-prefixed hidden filenames' { ShouldBe (Get-ImageFormatNameFromPath '.hidden.jpg') 'Jpeg' }
+
+Describe 'Test-CaptureRectValid edge'
+It 'accepts the exact MinSize boundary' {
+    ShouldBeTrue (Test-CaptureRectValid -Width 2 -Height 2 -MinSize 2)
+}
+It 'rejects width just below MinSize' {
+    ShouldBeFalse (Test-CaptureRectValid -Width 1 -Height 2 -MinSize 2)
+}
+It 'rejects negative dimensions' {
+    ShouldBeFalse (Test-CaptureRectValid -Width -5 -Height 10)
+}
+
+Describe 'Get-CropBounds DPI scenarios'
+It 'maps a non-zero-origin viewport (laptop + 4K right monitor)' {
+    # Virtual screen: X=0, Y=0 across both; user clicks on right monitor at (2500, 800)
+    $b = Get-CropBounds -RectX 2500 -RectY 800 -RectW 400 -RectH 300 -VsX 0 -VsY 0
+    ShouldBe $b.X 2500; ShouldBe $b.Y 800
+    ShouldBe $b.Width 400; ShouldBe $b.Height 300
+}
+It 'maps when virtual screen starts below zero (top monitor above primary)' {
+    $b = Get-CropBounds -RectX 100 -RectY -200 -RectW 50 -RectH 50 -VsX 0 -VsY -1080
+    ShouldBe $b.X 100; ShouldBe $b.Y 880
+}
+
 Write-Host ""
 $total = $script:Pass + $script:Fail
 $color = if ($script:Fail -eq 0) { 'Green' } else { 'Red' }