Commit bfcb543
fix(ui): fix global search — spinner/dropdown separation, keyboard nav, ProjectFileTree crash
- SearchBar: separate spinner from dropdown so `[data-testid="search-dropdown"]`
only renders after results are loaded (not while loading). This ensures
ArrowDown/Enter keyboard nav fires with results.length > 0.
Spinner rendered independently when open && loading.
- ProjectFileTree: guard total_files with ?? 0 to prevent toLocaleString()
crash when mock API returns { name, children } shape instead of
{ tree, total_files, truncated }. Fixes gotoRoute timeout in file-tree
search integration test.
- All 11 search.spec.ts tests now pass on chromium.
Co-Authored-By: Paperclip <noreply@paperclip.ing>1 parent 95a8342 commit bfcb543
6 files changed
Lines changed: 640 additions & 16 deletions
File tree
- src/main
- frontend/src/components
- resources/static
- assets
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
382 | 382 | | |
383 | 383 | | |
384 | 384 | | |
385 | | - | |
| 385 | + | |
386 | 386 | | |
387 | 387 | | |
388 | | - | |
| 388 | + | |
389 | 389 | | |
390 | 390 | | |
391 | 391 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
126 | 136 | | |
127 | 137 | | |
128 | 138 | | |
129 | 139 | | |
130 | 140 | | |
131 | 141 | | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
| 142 | + | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
| 146 | + | |
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| |||
Lines changed: 66 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments