ci: fix go-ci + go-parity workflows

Two unrelated CI failures on PR #130, both fixed:

1. staticcheck 2024.1.1 errors with "internal error in importing
   internal/byteorder (unsupported version: 2)" against Go 1.25's
   stdlib. Bump pin to 2025.1.1.

2. Java parity job called `graph -f json` without enriching to Neo4j
   first; the H2 cache alone isn't enough — graph reads from Neo4j
   under the serving profile. Now we run `enrich -Dspring.profiles.active=serving`
   between index and graph, then invoke graph from inside the fixture
   directory so the Neo4j path resolves relative to where enrich
   wrote it.

Drive-by: staticcheck 2025.1.1 surfaced legitimate dead code that
2024.1.1 was missing:
- containsInfra (internal/flow/builders.go) — unused helper, removed
- edgeColumns (internal/graph/bulk.go) — unused var, removed
- runtimeEdgeKinds (internal/query/service.go) — unused var, removed
- fileReadCounter (intelligence/extractor/enricher_test.go) — unused
  test type, removed
- allUnsupported (intelligence/query/planner_test.go) — unused helper, removed
- Two append-from-loop simplifications (internal/flow/builders.go)
- parity/open_ro.go marked with //go:build parity so staticcheck
  honors the build tag and doesn't flag the function as unused

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: aksOps

.github/workflows/go-ci.yml

@@ -35,7 +35,11 @@ jobs:
         run: go test ./... -race -count=1
       - name: staticcheck
         run: |
-          go install honnef.co/go/tools/cmd/staticcheck@2024.1.1
+          # staticcheck must understand the Go toolchain version that built
+          # the binaries above. 2024.1.1 errors with "internal error in
+          # importing internal/byteorder (unsupported version: 2)" against
+          # Go 1.25's stdlib. 2025.1.1 is the first release that handles it.
+          go install honnef.co/go/tools/cmd/staticcheck@2025.1.1
           "$(go env GOPATH)/bin/staticcheck" ./...
       - name: gosec
         run: |

.github/workflows/go-parity.yml

@@ -42,16 +42,27 @@ jobs:
           cp -r go/testdata/fixture-minimal /tmp/fm-java
       - name: Run Java index on fixture
         run: java -jar target/code-iq-*-cli.jar index /tmp/fm-java
+      - name: Run Java enrich on fixture
+        run: |
+          # `graph -f json` reads from Neo4j (serving profile), not H2. Need
+          # to enrich the H2 cache into Neo4j first or the export prints
+          # "No graph data found. Run 'codeiq analyze' first."
+          java -Dspring.profiles.active=serving -jar target/code-iq-*-cli.jar enrich /tmp/fm-java
       - name: Normalize Java output via Java helper
         run: |
           # The Java cache is H2, not SQLite — parity-normalize (Go-side)
           # cannot read it directly. Instead, use the Java side's `graph`
-          # command to emit JSON, then a small jq filter to produce the
-          # same canonical shape the Go normalizer emits. This jq script
-          # lives at parity/java-normalize.jq (committed in this PR).
-          java -jar target/code-iq-*-cli.jar graph /tmp/fm-java -f json \
+          # command to emit JSON (requires serving profile to access Neo4j),
+          # then a small jq filter to produce the same canonical shape the
+          # Go normalizer emits. The jq script lives at
+          # parity/java-normalize.jq (committed in this PR).
+          # Run from the fixture dir so the Neo4j path is resolved relative
+          # to where `enrich` wrote it.
+          cd /tmp/fm-java
+          java -Dspring.profiles.active=serving \
+            -jar "$GITHUB_WORKSPACE"/target/code-iq-*-cli.jar graph . -f json \
             > /tmp/java-raw.json
-          jq -f go/parity/java-normalize.jq /tmp/java-raw.json \
+          jq -f "$GITHUB_WORKSPACE"/go/parity/java-normalize.jq /tmp/java-raw.json \
             > /tmp/java-normalized.json
       - name: Run Go parity test
         working-directory: go

go/internal/flow/builders.go

@@ -26,12 +26,6 @@ func isCINode(id string) bool {
 	return strings.Contains(id, "gha:") || strings.Contains(id, "gitlab:")
 }
 
-// containsInfra reports whether the node's ID contains the supplied
-// substring (case-insensitive for "dockerfile" matches).
-func containsInfra(id, needle string) bool {
-	return strings.Contains(id, needle)
-}
-
 // buildOverview is the high-level architecture view with 4 subgraphs:
 // CI/CD, Infrastructure, Application, Security.
 //
@@ -74,12 +68,8 @@ func buildOverview(snap *Snapshot) *Diagram {
 
 	// --- Infrastructure subgraph ---
 	var infraNodesRaw []*model.CodeNode
-	for _, n := range snap.FindByKind(model.NodeInfraResource) {
-		infraNodesRaw = append(infraNodesRaw, n)
-	}
-	for _, n := range snap.FindByKind(model.NodeAzureResource) {
-		infraNodesRaw = append(infraNodesRaw, n)
-	}
+	infraNodesRaw = append(infraNodesRaw, snap.FindByKind(model.NodeInfraResource)...)
+	infraNodesRaw = append(infraNodesRaw, snap.FindByKind(model.NodeAzureResource)...)
 
 	if len(infraNodesRaw) > 0 {
 		var k8s, docker, terraform []*model.CodeNode

go/internal/graph/bulk.go

@@ -127,12 +127,6 @@ func stringProp(p map[string]any, key string) string {
 	return ""
 }
 
-// edgeColumns is the column order written to each rel-table staging CSV.
-// MUST match the per-kind REL table DDL in schema.go: the FROM/TO node
-// primary keys come first (Kuzu COPY convention for rel tables), followed
-// by the user columns id, confidence, source, props.
-var edgeColumns = []string{"from", "to", "id", "confidence", "source", "props"}
-
 // BulkLoadEdges groups edges by Kind and issues one COPY FROM per rel
 // table. A mixed-kind batch is split internally — callers don't need to
 // pre-partition. Empty input is a no-op.

go/internal/intelligence/extractor/enricher_test.go

@@ -47,12 +47,6 @@ func (f *fakeExtractor) Extract(ctx Context, node *model.CodeNode) Result {
 	return r
 }
 
-// fileReadCounter wraps os.ReadFile by spying on filesystem reads. We track
-// distinct paths to assert read-once.
-type fileReadCounter struct {
-	reads map[string]int
-}
-
 func TestEnricher_DispatchesPerLanguageAndAppendsEdges(t *testing.T) {
 	dir := t.TempDir()
 	javaPath := "src/Foo.java"

go/internal/intelligence/query/planner_test.go

@@ -23,14 +23,6 @@ func allLexical() CapabilityMatrix {
 	return out
 }
 
-// allUnsupported returns a CapabilityMatrix where every dimension is UNSUPPORTED.
-func allUnsupported() CapabilityMatrix {
-	out := make(CapabilityMatrix, len(allDimensions))
-	for _, d := range allDimensions {
-		out[d] = LevelUnsupported
-	}
-	return out
-}
 
 // fixed returns a planner whose capability provider always returns m, regardless
 // of language. Lets each test isolate routing logic from the per-language tables.

go/internal/query/service.go

@@ -28,14 +28,6 @@ type Service struct {
 // NewService constructs a Service bound to the given graph.Store.
 func NewService(store *graph.Store) *Service { return &Service{store: store} }
 
-// runtimeEdgeKinds enumerates the "consumer-direction" edges that count a
-// caller as a consumer for findConsumers. Matches the plan-spec list.
-// Returned as a Cypher rel-pattern alternation, e.g. `r:CALLS|PRODUCES|...`.
-var runtimeEdgeKinds = []string{
-	"CALLS", "PRODUCES", "CONSUMES", "QUERIES", "CONNECTS_TO",
-	"PUBLISHES", "LISTENS", "SENDS_TO", "RECEIVES_FROM",
-}
-
 // FindConsumers returns nodes m where m -[consumes|listens]-> target.
 // Mirrors QueryService.findConsumers + GraphStore.findConsumers on the Java
 // side; the runtime-edge set is the consumer-direction subset.

go/parity/open_ro.go

@@ -1,3 +1,5 @@
+//go:build parity
+
 package parity
 
 import "github.com/randomcodespace/codeiq/go/internal/cache"