Commit 12ba177
chore(build): drop dependency-check binding from verify (RAN-24 review)
Per reviewer feedback on #72: the OWASP dependency-check binding added in
15b5e6c red-lines every CI run because the public NVD 2.0 API rate-limits
anonymous callers (HTTP 429), which corrupts the partial H2 NVD store and
trips NPEs in the plugin's worker pool. Root cause is infra, not a real
CVE finding, but the failing binding still breaks the build - the opposite
of "CI enforces them."
Path B (reviewer's recommendation): keep the SpotBugs binding (already
green on this branch), drop the dep-check binding + skip property from
this PR, and track the NVD secret + cache work in a follow-up.
Removes from pom.xml:
- `<dependency-check.skip>` property and comment
- `<configuration>` + `<executions>` blocks on dependency-check-maven
(the plugin declaration itself stays for the follow-up to re-enable)
Updates .github/workflows/ci-java.yml comment to reference only the
SpotBugs gate.
Keeps dependency-check-suppressions.xml so the next PR can turn the gate
on without re-introducing the stub.
Verified locally (`mvn -B clean compile spotbugs:check ...`):
[INFO] --- spotbugs-maven-plugin:4.9.8.3:check (default-cli) @ code-iq ---
[INFO] BugInstance size is 0
[INFO] BUILD SUCCESS
Full `mvn clean verify` on this branch pre-edits produced
`Tests run: 3395, Failures: 0, Errors: 0, Skipped: 31` before the dep-check
step failed (per CI run 24913046002); removing that step is the only CI
delta this commit introduces.
Co-Authored-By: Paperclip <noreply@paperclip.ing>1 parent 15b5e6c commit 12ba177
2 files changed
Lines changed: 2 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
| 22 | + | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | 33 | | |
42 | 34 | | |
43 | 35 | | |
| |||
423 | 415 | | |
424 | 416 | | |
425 | 417 | | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | 418 | | |
441 | 419 | | |
442 | 420 | | |
| |||
0 commit comments