From 30b525bff05db0047708496205af4f60a618a8f3 Mon Sep 17 00:00:00 2001 From: Nitish Bhat Date: Thu, 11 Jun 2026 23:24:46 +0000 Subject: [PATCH 1/4] Add Radeon AI PRO R9700S (7551, C1) to labeller amdgpu.ids The R9700S revision (device 7551, rev C1) is not present in upstream libdrm's amdgpu.ids, causing amdgpu_get_marketing_name() to return a generic "AMD Radeon Graphics" name. This results in the node labeller reporting amd.com/gpu.product-name=AMD_Radeon_Graphics instead of the correct product name. Add the entry to labeller.Dockerfile following the existing pattern for other missing device IDs (MI325X VF, MI100, W6900X, W6800X, MI308X HF VF). Fixes: KUBE-22 Co-Authored-By: Claude Opus 4 --- labeller.Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/labeller.Dockerfile b/labeller.Dockerfile index 2445b3af..94edef60 100644 --- a/labeller.Dockerfile +++ b/labeller.Dockerfile @@ -24,6 +24,7 @@ RUN echo "738E, 01, AMD Instinct MI100" >> /go/src/github.com/ROCm/k8s-device- RUN echo "73A2, C0, AMD Radeon Pro W6900X" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "73AB, C0, AMD Radeon Pro W6800X" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "74BC, 00, AMD Instinct MI308X HF VF" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "7551, C1, AMD Radeon AI PRO R9700S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids FROM alpine:3.23.4 LABEL \ From 979e46b21311f9c569805634a5c875a7724bd093 Mon Sep 17 00:00:00 2001 From: Nitish Bhat Date: Sat, 13 Jun 2026 00:02:31 +0000 Subject: [PATCH 2/4] Add R9600D (7551, C8) and W7900S (744A, 00) to labeller amdgpu.ids Also backfills R9700S entry into ubi-labeller.Dockerfile which was missing it. Fixes: KUBE-22 --- labeller.Dockerfile | 2 ++ ubi-labeller.Dockerfile | 3 +++ 2 files changed, 5 insertions(+) diff --git a/labeller.Dockerfile b/labeller.Dockerfile index 94edef60..d68588b4 100644 --- a/labeller.Dockerfile +++ b/labeller.Dockerfile @@ -25,6 +25,8 @@ RUN echo "73A2, C0, AMD Radeon Pro W6900X" >> /go/src/github.com/ROCm/k8s-devi RUN echo "73AB, C0, AMD Radeon Pro W6800X" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "74BC, 00, AMD Instinct MI308X HF VF" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "7551, C1, AMD Radeon AI PRO R9700S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "7551, C8, AMD Radeon AI PRO R9600D" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "744A, 00, AMD Radeon PRO W7900S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids FROM alpine:3.23.4 LABEL \ diff --git a/ubi-labeller.Dockerfile b/ubi-labeller.Dockerfile index 6a26daba..dfd1b361 100644 --- a/ubi-labeller.Dockerfile +++ b/ubi-labeller.Dockerfile @@ -35,6 +35,9 @@ RUN echo "738E, 01, AMD Instinct MI100" >> /go/src/github.com/ROCm/k8s-device- RUN echo "73A2, C0, AMD Radeon Pro W6900X" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "73AB, C0, AMD Radeon Pro W6800X" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "74BC, 00, AMD Instinct MI308X HF VF" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "7551, C1, AMD Radeon AI PRO R9700S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "7551, C8, AMD Radeon AI PRO R9600D" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "744A, 00, AMD Radeon PRO W7900S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids FROM registry.access.redhat.com/ubi9/ubi-minimal:9.8 LABEL \ From 26d5e95b6fa02ddd3a0d5dbcd19d43428800b816 Mon Sep 17 00:00:00 2001 From: Nitish Bhat Date: Wed, 17 Jun 2026 18:12:39 +0000 Subject: [PATCH 3/4] Rename W7900S to W7900 Dual Slot in labeller amdgpu.ids Update the product name for device 744A (rev 00) from "AMD Radeon PRO W7900S" to "AMD Radeon PRO W7900 Dual Slot" in both labeller Dockerfiles. --- labeller.Dockerfile | 2 +- ubi-labeller.Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/labeller.Dockerfile b/labeller.Dockerfile index d68588b4..8d975eda 100644 --- a/labeller.Dockerfile +++ b/labeller.Dockerfile @@ -26,7 +26,7 @@ RUN echo "73AB, C0, AMD Radeon Pro W6800X" >> /go/src/github.com/ROCm/k8s-devi RUN echo "74BC, 00, AMD Instinct MI308X HF VF" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "7551, C1, AMD Radeon AI PRO R9700S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "7551, C8, AMD Radeon AI PRO R9600D" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids -RUN echo "744A, 00, AMD Radeon PRO W7900S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "744A, 00, AMD Radeon PRO W7900 Dual Slot" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids FROM alpine:3.23.4 LABEL \ diff --git a/ubi-labeller.Dockerfile b/ubi-labeller.Dockerfile index dfd1b361..893ef62f 100644 --- a/ubi-labeller.Dockerfile +++ b/ubi-labeller.Dockerfile @@ -37,7 +37,7 @@ RUN echo "73AB, C0, AMD Radeon Pro W6800X" >> /go/src/github.com/ROCm/k8s-devi RUN echo "74BC, 00, AMD Instinct MI308X HF VF" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "7551, C1, AMD Radeon AI PRO R9700S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids RUN echo "7551, C8, AMD Radeon AI PRO R9600D" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids -RUN echo "744A, 00, AMD Radeon PRO W7900S" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids +RUN echo "744A, 00, AMD Radeon PRO W7900 Dual Slot" >> /go/src/github.com/ROCm/k8s-device-plugin/cmd/k8s-node-labeller/amdgpu.ids FROM registry.access.redhat.com/ubi9/ubi-minimal:9.8 LABEL \ From 9b45c3822caa24995789b2dba8e51a3972e12bbd Mon Sep 17 00:00:00 2001 From: Nitish Bhat Date: Wed, 17 Jun 2026 18:29:17 +0000 Subject: [PATCH 4/4] Add CI workflow to build images on PRs --- .github/workflows/ci.yml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 00000000..3ad61801 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,29 @@ +name: CI - Build Images + +on: + pull_request: + branches: + - master + +jobs: + build-images: + runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + include: + - name: device-plugin + target: build-device-plugin + - name: labeller + target: build-labeller + - name: ubi-device-plugin + target: build-ubi-device-plugin + - name: ubi-labeller + target: build-ubi-labeller + name: build (${{ matrix.name }}) + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Build ${{ matrix.name }} + run: make ${{ matrix.target }}