Add a refund-after-dispute resolution test verifying escrow refund finality and investment status alignment

[Baskarayelu]

📋 Description

When a dispute resolves against the business, the natural remedy is to refund the investor via refund_escrow_funds in quicklendx-contracts/src/escrow.rs, which moves the escrow Held -> Refunded, the invoice to Refunded, the accepted bid to Cancelled, and the investment to Refunded. The dispute lifecycle in dispute.rs and refund mechanics are each tested separately, but the combined path — dispute resolved then escrow refunded — has no end-to-end consistency test.

Why this matters: the dispute-to-refund path is where investor protection actually pays out, and it touches four pieces of state that must all move together. A test that opens a dispute, resolves it, refunds, and asserts every status aligns (and that no second refund/settle can follow) proves the remedy is atomic and final — exactly the property a disputing investor relies on.

🎯 Requirements & Context

Functional requirements

• Add quicklendx-contracts/src/test_dispute_refund_flow.rs driving: fund -> create dispute -> put under review -> resolve -> refund escrow.
• Assert post-refund: invoice Refunded, escrow Refunded, bid Cancelled, investment Refunded, dispute Resolved — all consistent.
• Assert finality: after refund, settle_invoice and a second refund_escrow_funds both fail; no double disbursement (verify token balance delta equals one refund).
• Assert the investor (not the business) received the refunded amount.

Context & constraints

• Use a mock token to verify the balance delta, consistent with test_cancel_refund.rs and test_escrow_refund_hardened.rs.
• Test-only; document any inconsistency as a finding.
• Soroban SDK 25.1.1.

🛠️ Suggested Execution

1. Fork & branch

git checkout -b test/dispute-refund-flow

2. Implement changes

• Build the full path and the multi-module consistency + finality assertions.
• Doc-comment the atomic-remedy invariant.

3. Test & commit

cargo test -p quicklendx-contracts test_dispute_refund_flow -- --nocapture

• Edge cases: refund attempted while dispute still UnderReview; refund by admin vs business; double refund rejected; settle after refund rejected.

Example commit message

test(disputes): add end-to-end dispute-resolution-then-refund consistency and finality suite

Verifies invoice/escrow/bid/investment/dispute statuses align after refund and that the
remedy is final with no double disbursement.

✅ Acceptance Criteria & Guidelines

Requirement	Target
Full dispute-to-refund path covered	Required
Cross-module status alignment asserted	Required
Finality + no-double-spend asserted	Required
Coverage of refund/dispute branches	≥ 95%
Docs + doc comments	Required
cargo test + cargo clippy clean	Required
Timeframe	96 hours from assignment

💬 Community & Support

Questions, design discussion, and help getting your environment running — join the QuickLendX contributor community on Discord: https://discord.gg/VpngvTjWa

Please drop a note in the channel when you pick this up so we can avoid duplicate work and unblock you fast. Clear communication during the PR keeps the review fast and friction-free. 🚀

[Kuhai9801]

I’d like to work on this.

I have experience with smart-contract security testing and bug bounty-style state-machine/invariant work. I’ll add an end-to-end regression test for the dispute-resolved-to-refund path and assert the escrow, invoice, accepted bid, and investment statuses all reach the expected final states together.

[grantfox-oss]

🦊 GrantFox — @Kuhai9801 has been assigned to this issue!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #1324)
2. Your PR will be reviewed by the QuickLendX maintainers

Good luck! Track your progress on GrantFox.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox!

@Kuhai9801's PR #1381 was approved and merged by @Baskarayelu.

🏆 @Kuhai9801: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (293 total points). Track your full progress on GrantFox.

👏 Great work, @Kuhai9801! Keep contributing to QuickLendX.