From 2407c0e033460f2065de82e23362df4bd7e0bc16 Mon Sep 17 00:00:00 2001 From: ZhuchkaTriplesix Date: Wed, 29 Jul 2026 10:51:07 +0300 Subject: [PATCH] refactor: replace .map().toList() with collection for loops in UI components Resolves #530 --- lib/features/extensions/extension_stats_view.dart | 4 +++- lib/features/mongodb/mongo_stats_view.dart | 2 +- lib/features/redis/redis_view.dart | 11 +++++------ lib/shared/widgets/querya_dropdown.dart | 5 +++-- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/features/extensions/extension_stats_view.dart b/lib/features/extensions/extension_stats_view.dart index f7788a59..5b0cb1e4 100644 --- a/lib/features/extensions/extension_stats_view.dart +++ b/lib/features/extensions/extension_stats_view.dart @@ -316,7 +316,9 @@ class _ExtensionStatsViewState extends material.State { mainAxisSpacing: 16, mainAxisExtent: _summaryChipHeight, ), - children: chips.map((c) => _buildChip(cs, c)).toList(), + children: [ + for (final c in chips) _buildChip(cs, c), + ], ); }, ); diff --git a/lib/features/mongodb/mongo_stats_view.dart b/lib/features/mongodb/mongo_stats_view.dart index cce26a9c..a19f14d2 100644 --- a/lib/features/mongodb/mongo_stats_view.dart +++ b/lib/features/mongodb/mongo_stats_view.dart @@ -690,7 +690,7 @@ class _MongoStatsViewState extends material.State { title, _twoColumnMetrics( context, - data.entries.map((e) => MapEntry(e.key, e.value)).toList(), + [ for (final e in data.entries) MapEntry(e.key, e.value) ], ), ); } diff --git a/lib/features/redis/redis_view.dart b/lib/features/redis/redis_view.dart index 4ffa5d0a..db9096d7 100644 --- a/lib/features/redis/redis_view.dart +++ b/lib/features/redis/redis_view.dart @@ -680,11 +680,10 @@ class _RedisViewState extends material.State { {List? keys}) { if (data == null || data.isEmpty) return const material.SizedBox.shrink(); final entries = keys != null - ? keys - .map((k) => MapEntry(k, data[k])) - .where((e) => e.value != null) - .map((e) => MapEntry(e.key, e.value as String)) - .toList() + ? >[ + for (final k in keys) + if (data[k] != null) MapEntry(k, data[k]!), + ] : data.entries.toList(); if (entries.isEmpty) return const material.SizedBox.shrink(); return _card( @@ -692,7 +691,7 @@ class _RedisViewState extends material.State { title, _twoColumnMetrics( context, - entries.map((e) => MapEntry(_labelFor(e.key), e.value)).toList(), + [ for (final e in entries) MapEntry(_labelFor(e.key), e.value) ], ), ); } diff --git a/lib/shared/widgets/querya_dropdown.dart b/lib/shared/widgets/querya_dropdown.dart index e47b127f..4aef0e94 100644 --- a/lib/shared/widgets/querya_dropdown.dart +++ b/lib/shared/widgets/querya_dropdown.dart @@ -119,8 +119,9 @@ class _QueryaDropdownState extends material.State> { } _cachedMenuItems = List>.from(widget.items); _cachedMenuValue = widget.value; - _cachedMenuChildren = - widget.items.map((item) => _menuItem(item, cs)).toList(); + _cachedMenuChildren = [ + for (final item in widget.items) _menuItem(item, cs), + ]; return _cachedMenuChildren!; }