From 8370eed8448d009d977096077854e9a16722f2ab Mon Sep 17 00:00:00 2001 From: ZhuchkaTriplesix Date: Fri, 10 Jul 2026 20:39:46 +0300 Subject: [PATCH] fix(core): log remaining silent catches in database drivers Finish #272 coverage for MongoDB/Redis disconnect, connection test probes, and PostgreSQL transaction state checks. Fixes #272 --- lib/core/database/mongodb_connection.dart | 5 +++-- lib/core/database/mysql_connection.dart | 3 ++- lib/core/database/postgres_connection.dart | 3 ++- lib/core/database/redis_connection.dart | 10 ++++++---- lib/core/database/sqlite_connection.dart | 3 ++- 5 files changed, 15 insertions(+), 9 deletions(-) diff --git a/lib/core/database/mongodb_connection.dart b/lib/core/database/mongodb_connection.dart index d0d96b44..a6d78126 100644 --- a/lib/core/database/mongodb_connection.dart +++ b/lib/core/database/mongodb_connection.dart @@ -1,3 +1,4 @@ +import 'package:flutter/foundation.dart'; import 'package:mongo_dart/mongo_dart.dart'; import 'package:querya_desktop/features/connections/ssl_certificate_support.dart'; @@ -166,8 +167,8 @@ class MongoConnection { _db = null; try { await db?.close(); - } catch (_) { - // Connection may already be closed — ignore. + } catch (e) { + debugPrint('MongoConnection.disconnect: $e'); } } diff --git a/lib/core/database/mysql_connection.dart b/lib/core/database/mysql_connection.dart index c7a3700e..53c294d1 100644 --- a/lib/core/database/mysql_connection.dart +++ b/lib/core/database/mysql_connection.dart @@ -254,7 +254,8 @@ class MysqlConnection { return true; } return false; - } catch (_) { + } catch (e) { + debugPrint('MysqlConnection.testConnection: $e'); return false; } finally { await disconnect(); diff --git a/lib/core/database/postgres_connection.dart b/lib/core/database/postgres_connection.dart index d92ae8a5..2ba4162f 100644 --- a/lib/core/database/postgres_connection.dart +++ b/lib/core/database/postgres_connection.dart @@ -265,7 +265,8 @@ class PostgresConnection { ); if (r.isEmpty) return null; return r.first[0] as bool; - } catch (_) { + } catch (e) { + debugPrint('PostgresConnection.inOpenTransaction: $e'); return null; } } diff --git a/lib/core/database/redis_connection.dart b/lib/core/database/redis_connection.dart index c9548386..ee6b2528 100644 --- a/lib/core/database/redis_connection.dart +++ b/lib/core/database/redis_connection.dart @@ -112,8 +112,8 @@ class RedisConnection { _conn = null; try { await c?.close(); - } catch (_) { - // Connection may already be closed — ignore. + } catch (e) { + debugPrint('RedisConnection.disconnect: $e'); } } @@ -129,7 +129,8 @@ class RedisConnection { try { await connect(); return true; - } catch (_) { + } catch (e) { + debugPrint('RedisConnection.testConnection: $e'); return false; } finally { await disconnect(); @@ -164,7 +165,8 @@ class RedisConnection { if (result is List && result.length >= 2) { return int.tryParse(result[1].toString()) ?? 16; } - } catch (_) { + } catch (e) { + debugPrint('RedisConnection.getMaxDatabases: $e'); // Some Redis instances don't allow CONFIG; fall back. } return 16; diff --git a/lib/core/database/sqlite_connection.dart b/lib/core/database/sqlite_connection.dart index 6a90e44a..cf2cefeb 100644 --- a/lib/core/database/sqlite_connection.dart +++ b/lib/core/database/sqlite_connection.dart @@ -79,7 +79,8 @@ class SqliteConnection { return true; } return false; - } catch (_) { + } catch (e) { + debugPrint('SqliteConnection.testConnection: $e'); return false; } finally { await disconnect();