Skip to content

ui(results): ResultsTab isLoading must not hide errorMessage #457

Description

@ZhuchkaTriplesix

Parent

Part of #445

Severity

Low

Problem

isLoading always wins over errorMessage. Fine if callers clear error on run (SQL workspaces do); any caller that sets both shows spinner and hides the error.

Evidence

  • lib/features/main_screen/results_tab.dart (~45–50)

Acceptance

  • Document invariant or show error when !isLoading
  • Test asserting error visible when loading is false with error set
  • Optional: assert/test that workspaces clear error before setting loading

Suggested fix

Prefer error when errorMessage != null && !isLoading; document caller contract in dartdoc.

Metadata

Metadata

Labels

bugSomething isn't workinguiUser interface components and widgets

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions