Skip to content

ENH: we still have performance warning for our use of outer product #11

Description

@mathurinm

the tests on travis still get a lot of:

  /home/travis/build/QB3/CLaR/clar/solvers.py:387: NumbaPerformanceWarning: '@' is faster on contiguous arrays, called on (array(float64, 2d, A), array(float64, 2d, A))
    S_inv_R -= S_inv_X[:, j:j+1] @ B[j:j+1, :]

@QB3 I can't remember, can we fix this on the numba side? Or, given you experience with mne, do you think we can remove the numba in this part and use the dgemm routine for rank one matrix addition ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions