[Bug] incompatiblity with subworld libary #819
Description
Github issues should match the following format, for ease of organization and readability.
Issue Description
I am playing a hyper moded mod pack with many popular mods. i am getting horrible frame rate when i lode into a world (I know, I know hyper moded mean low frames). when I checked my logs i saw a spamming error coming from Subworld Library when i looked at the error it mentioned starlight river multiple times within the error. so i am sending you one and another to subworld libary
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at SubworldLibrary.SubworldLibrary.Call(Object[] args) in SubworldLibrary.cs:line 964
at StarlightRiver.Core.Systems.CutawaySystem.CutawayHook.get_InSubworld() in StarlightRiver\Core\Systems\CutawaySystem\CutawayHook.cs:line 22
at StarlightRiver.Core.Systems.CutawaySystem.CutawayHook.DrawPositive(orig_DrawDust orig, Main self) in StarlightRiver\Core\Systems\CutawaySystem\CutawayHook.cs:line 53
at Hook<System.Void StarlightRiver.Core.Systems.CutawaySystem.CutawayHook::DrawPositive(Terraria.On_Main+orig_DrawDust,Terraria.Main)>(Main )
at StarlightRiver.Content.CustomHooks.PrimitiveDrawing.DrawPrimitives(orig_DrawDust orig, Main self) in StarlightRiver\Content\CustomHooks\Visuals.PrimitiveDrawing.cs:line 16
at Hook<System.Void StarlightRiver.Content.CustomHooks.PrimitiveDrawing::DrawPrimitives(Terraria.On_Main+orig_DrawDust,Terraria.Main)>(Main )
at SyncProxy<System.Void Terraria.Main:DrawDust()>(Main )
at DMD<DMD<>?13667440::Terraria.Main::DoDraw>(Main this, GameTime gameTime)
at Daybreak.Common.Features.Rendering.ItemPreRenderer.UpdateItemRenders(orig_DoDraw orig, Main self, GameTime gameTime) in Daybreak\Common\Features\Rendering\ItemPreRendering\ItempreRenderer.cs:line 124
at Hook<System.Void Daybreak.Common.Features.Rendering.ItemPreRenderer::UpdateItemRenders(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at StarlightRiver.Core.Systems.CameraSystem.Fadeout.DrawFadeout(orig_DoDraw orig, Main self, GameTime gameTime) in StarlightRiver\Core\Systems\CameraSystem\Fadeout.cs:line 27
at Hook<System.Void StarlightRiver.Core.Systems.CameraSystem.Fadeout::DrawFadeout(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at GravityDontFlipScreen.GravityFlipSystem.Main_DoDraw(orig_DoDraw orig, Main self, GameTime gameTime) in GravityDontFlipScreen\GravityFlipSystem.cs:line 116
at Hook<System.Void GravityDontFlipScreen.GravityFlipSystem::Main_DoDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at TerrariaOverhaul.Core.Time.TimeSystem.OnDoDraw(orig_DoDraw orig, Main main, GameTime gameTime) in TerrariaOverhaul\Core\Time\TimeSystem.cs:line 71
at Hook<System.Void TerrariaOverhaul.Core.Time.TimeSystem::OnDoDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at SyncProxy<System.Void Terraria.Main:DoDraw(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at Terraria.Main.Draw_Inner(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53223
at Terraria.Main.Draw(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53210
at Microsoft.Xna.Framework.Game.Tick() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 562
at Microsoft.Xna.Framework.Game.RunLoop() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 878
at Microsoft.Xna.Framework.Game.Run() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 419
at Terraria.Program.RunGame() in tModLoader\Terraria\Program.cs:line 266
at Terraria.Program.LaunchGame_(Boolean isServer) in tModLoader\Terraria\Program.cs:line 240
at Terraria.Program.LaunchGame(String[] args, Boolean monoArgs) in tModLoader\Terraria\Program.cs:line 213
at Terraria.MonoLaunch.Main_End(String[] args) in tModLoader\Terraria\MonoLaunch.cs:line 79
at Terraria.MonoLaunch.<>c__DisplayClass1_0.
[15:50:43.591] [Main Thread/ERROR] [SubworldLibrary]: Call error: at SubworldLibrary.SubworldLibrary.Call(Object[] args) in SubworldLibrary.cs:line 964Index was outside the bounds of the array.
[15:50:43.593] [Main Thread/WARN] [tML]: Silently Caught Exception:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at SubworldLibrary.SubworldLibrary.Call(Object[] args) in SubworldLibrary.cs:line 964
at StarlightRiver.Core.Systems.CutawaySystem.CutawayHook.get_InSubworld() in StarlightRiver\Core\Systems\CutawaySystem\CutawayHook.cs:line 22
at StarlightRiver.Core.Systems.CutawaySystem.CutawayHook.DrawNegative(orig_DrawInfernoRings orig, Main self) in StarlightRiver\Core\Systems\CutawaySystem\CutawayHook.cs:line 66
at Hook<System.Void StarlightRiver.Core.Systems.CutawaySystem.CutawayHook::DrawNegative(Terraria.On_Main+orig_DrawInfernoRings,Terraria.Main)>(Main )
at InfernumMode.Core.ILEditingStuff.DrawCherishedSealocketHook.DrawForcefields(orig_DrawInfernoRings orig, Main self) in InfernumMode\Core\ILEditingStuff\MechanicHooks.cs:line 485
at Hook<System.Void InfernumMode.Core.ILEditingStuff.DrawCherishedSealocketHook::DrawForcefields(Terraria.On_Main+orig_DrawInfernoRings,Terraria.Main)>(Main )
at SyncProxy<System.Void Terraria.Main:DrawInfernoRings()>(Main )
at DMD<DMD<>?13667440::Terraria.Main::DoDraw>(Main this, GameTime gameTime)
at Daybreak.Common.Features.Rendering.ItemPreRenderer.UpdateItemRenders(orig_DoDraw orig, Main self, GameTime gameTime) in Daybreak\Common\Features\Rendering\ItemPreRendering\ItempreRenderer.cs:line 124
at Hook<System.Void Daybreak.Common.Features.Rendering.ItemPreRenderer::UpdateItemRenders(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at StarlightRiver.Core.Systems.CameraSystem.Fadeout.DrawFadeout(orig_DoDraw orig, Main self, GameTime gameTime) in StarlightRiver\Core\Systems\CameraSystem\Fadeout.cs:line 27
at Hook<System.Void StarlightRiver.Core.Systems.CameraSystem.Fadeout::DrawFadeout(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at GravityDontFlipScreen.GravityFlipSystem.Main_DoDraw(orig_DoDraw orig, Main self, GameTime gameTime) in GravityDontFlipScreen\GravityFlipSystem.cs:line 116
at Hook<System.Void GravityDontFlipScreen.GravityFlipSystem::Main_DoDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at TerrariaOverhaul.Core.Time.TimeSystem.OnDoDraw(orig_DoDraw orig, Main main, GameTime gameTime) in TerrariaOverhaul\Core\Time\TimeSystem.cs:line 71
at Hook<System.Void TerrariaOverhaul.Core.Time.TimeSystem::OnDoDraw(Terraria.On_Main+orig_DoDraw,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at SyncProxy<System.Void Terraria.Main:DoDraw(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at Terraria.Main.Draw_Inner(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53223
at Terraria.Main.Draw(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 53210
at Microsoft.Xna.Framework.Game.Tick() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 562
at Microsoft.Xna.Framework.Game.RunLoop() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 878
at Microsoft.Xna.Framework.Game.Run() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 419
at Terraria.Program.RunGame() in tModLoader\Terraria\Program.cs:line 266
at Terraria.Program.LaunchGame_(Boolean isServer) in tModLoader\Terraria\Program.cs:line 240
at Terraria.Program.LaunchGame(String[] args, Boolean monoArgs) in tModLoader\Terraria\Program.cs:line 213
at Terraria.MonoLaunch.Main_End(String[] args) in tModLoader\Terraria\MonoLaunch.cs:line 79
at Terraria.MonoLaunch.<>c__DisplayClass1_0.
[15:50:43.594] [Main Thread/ERROR] [SubworldLibrary]: Call error: at SubworldLibrary.SubworldLibrary.Call(Object[] args) in SubworldLibrary.cs:line 964Index was outside the bounds of the array.
[15:50:46.488] [Main Thread/INFO] [Terraria]: Entering world with player: jala, IsCloud=False, Width: 8400, Height: 2400, Evil: 1, GameMode: 1
[15:50:47.240] [.NET TP Worker/DEBUG] [tML]: Web Request: https://raw.githubusercontent.com/Dummiez/tModLoader-WingSlotExtra/main/build.txt
[15:50:47.263] [Main Thread/INFO] [tML]: tModLoader RAM usage has increased: 12.4 GB
[15:50:47.444] [Main Thread/WARN] [tML]: Silently Caught Exception:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at SubworldLibrary.SubworldLibrary.Call(Object[] args) in SubworldLibrary.cs:line 964
at StarlightRiver.Core.Systems.CutawaySystem.CutawayHook.get_InSubworld() in StarlightRiver\Core\Systems\CutawaySystem\CutawayHook.cs:line 22
at StarlightRiver.Core.Systems.CutawaySystem.CutawayHandler.CreateCutaways() in StarlightRiver\Core\Systems\CutawaySystem\CutawayHandler.cs:line 21
at StarlightRiver.Core.Systems.CutawaySystem.CutawayHandler.PostUpdateEverything() in StarlightRiver\Core\Systems\CutawaySystem\CutawayHandler.cs:line 88
at Terraria.ModLoader.SystemLoader.PostUpdateEverything() in tModLoader\Terraria\ModLoader\SystemLoader.cs:line 421
at DMD<DMD<>?45982140::Terraria.Main::DoUpdateInWorld>(Main this, Stopwatch sw)
at SyncProxy<System.Void Terraria.Main:DoUpdateInWorld(System.Diagnostics.Stopwatch)>(Main , Stopwatch )
at DMD<DMD<>?43902060::Terraria.Main::DoUpdate>(Main this, GameTime& gameTime)
at Hook<System.Void SpiritMod.Mechanics.EventSystem.EventManager::Main_DoUpdate(Terraria.On_Main+orig_DoUpdate,Terraria.Main,Microsoft.Xna.Framework.GameTime&)>(Main , GameTime& )
at StarlightRiver.Core.Systems.BlockerTileSystem.BlockerTileSystem.UpdateCollision(orig_DoUpdate orig, Main self, GameTime& gameTime) in StarlightRiver\Core\Systems\BlockerTileSystem\BlockerTileSystem.cs:line 24
at Hook<System.Void StarlightRiver.Core.Systems.BlockerTileSystem.BlockerTileSystem::UpdateCollision(Terraria.On_Main+orig_DoUpdate,Terraria.Main,Microsoft.Xna.Framework.GameTime&)>(Main , GameTime& )
at StarlightRiver.Core.Systems.BossRushSystem.BossRushSpeedupAddon.Speedup(orig_DoUpdate orig, Main self, GameTime& gameTime) in StarlightRiver\Core\Systems\BossRushSystem\BossRushSpeedupAddon.cs:line 28
at Hook<System.Void StarlightRiver.Core.Systems.BossRushSystem.BossRushSpeedupAddon::Speedup(Terraria.On_Main+orig_DoUpdate,Terraria.Main,Microsoft.Xna.Framework.GameTime&)>(Main , GameTime& )
at StarlightRiver.Core.Systems.ForegroundSystem.ForegroundHook.ResetForeground(orig_DoUpdate orig, Main self, GameTime& gameTime) in StarlightRiver\Core\Systems\ForegroundSystem\ForegroundHook.cs:line 55
at Hook<System.Void StarlightRiver.Core.Systems.ForegroundSystem.ForegroundHook::ResetForeground(Terraria.On_Main+orig_DoUpdate,Terraria.Main,Microsoft.Xna.Framework.GameTime&)>(Main , GameTime& )
at TerrariaOverhaul.Core.Time.TimeSystem.OnDoUpdate(orig_DoUpdate orig, Main main, GameTime& gameTime) in TerrariaOverhaul\Core\Time\TimeSystem.cs:line 81
at Hook<System.Void TerrariaOverhaul.Core.Time.TimeSystem::OnDoUpdate(Terraria.On_Main+orig_DoUpdate,Terraria.Main,Microsoft.Xna.Framework.GameTime&)>(Main , GameTime& )
at SyncProxy<System.Void Terraria.Main:DoUpdate(Microsoft.Xna.Framework.GameTime&)>(Main , GameTime& )
at DMD<System.Void Terraria.Main:Update(Microsoft.Xna.Framework.GameTime)>(Main this, GameTime gameTime)
at Hook<System.Void ThoriumMod.UI.ThoriumInterfaceResources::OnResolutionChanged(Terraria.On_Main+orig_Update,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at SpiritMod.Utilities.SpiritDetours.Main_Update(orig_Update orig, Main self, GameTime gameTime)
at Hook<System.Void SpiritMod.Utilities.SpiritDetours::Main_Update(Terraria.On_Main+orig_Update,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at Hook<System.Void StarlightRiver.Content.GUI.Tooltip::Reset(Terraria.On_Main+orig_Update,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at StarlightRiver.Core.Systems.BossRushSystem.BossRushGUIHack.UpdateBossMenu(orig_Update orig, Main self, GameTime gameTime)
at Hook<System.Void StarlightRiver.Core.Systems.BossRushSystem.BossRushGUIHack::UpdateBossMenu(Terraria.On_Main+orig_Update,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at StarlightRiver.Core.Systems.DebugSystem.DoUpdate(orig_Update orig, Main self, GameTime gameTime)
at Hook<System.Void StarlightRiver.Core.Systems.DebugSystem::DoUpdate(Terraria.On_Main+orig_Update,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at Hook<System.Void BTitles.BiomeTitlesMod::Update(Terraria.On_Main+orig_Update,Terraria.Main,Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at SyncProxy<System.Void Terraria.Main:Update(Microsoft.Xna.Framework.GameTime)>(Main , GameTime )
at Microsoft.Xna.Framework.Game.Tick()
at Microsoft.Xna.Framework.Game.RunLoop()
at Microsoft.Xna.Framework.Game.Run()
at Terraria.Program.RunGame()
at Terraria.Program.LaunchGame_(Boolean isServer)
at Terraria.Program.LaunchGame(String[] args, Boolean monoArgs)
at Terraria.MonoLaunch.Main_End(String[] args)
at Terraria.MonoLaunch.<>c__DisplayClass1_0.
Reproduction
A detailed walkthrough of how to reproduce the issue, as thorough as possible.
Mod list: [ "AlchemistNPCLite",
"AmuletOfManyMinions",
"BetterBlending",
"BossChecklist",
"CalamityMod",
"CalamityModMusic",
"CalValEX",
"Census",
"CheatSheet",
"ExtraPylons",
"FargoSeeds",
"fargosoulstweaks",
"Fargowiltas",
"FargowiltasMusic",
"FargowiltasSouls",
"GravityDontFlipScreen",
"HighTrees",
"Luminance",
"PylonShield",
"RecipeBrowser",
"SerousCommonLib",
"TerrariaNoRangePylon",
"HuntExpert",
"WingSlotExtra",
"WMITF",
"CalamityHunt",
"DraedonExpansion",
"XDContentMod",
"ThoriumChestTweaks",
"RagnarokMod",
"ThoriumMod",
"ClamityMusic",
"Clamity",
"SubworldLibrary",
"CatalystMod",
"AutoTrash",
"StarsAbove",
"CoolerItemVisualEffect",
"ThoriumRework",
"StructureHelper",
"Daybreak",
"FargowiltasCrossmod",
"CalamityBossResyncer",
"PetsOverhaul",
"PetsOverhaulCalamityAddon",
"RevengeancePlus",
"InfernalEclipseAPI",
"InfernumMode",
"ThrowerUnification",
"InfernumSOTSSanctuaryAdjuster",
"Consolaria",
"SOTS",
"VervCaves",
"FishingMinigame",
"ColoredCalRelics",
"InfernumModeMusic",
"CalamityExpert",
"CalamityAmmo",
"PackBuilder",
"BTitles",
"BlueMoon",
"YouBoss",
"MusicDisplay",
"ColoredDamageTypes",
"InfernalEclipseWeaponsDLC",
"UnCalamityModMusic",
"ShopExpander",
"TeamSpectate",
"CalamityBardHealer",
"EvilPylon",
"CalamityCrossmodVulnerabilities",
"SOTSBardHealer",
"WHummusMultiModBalancing",
"OrchidMineshaft",
"CalamityAmmunitions",
"CatalystExpert",
"HypnosMod",
"BossCursor",
"MSC",
"ImproveGame",
"MagicStorage",
"MagicStorageVoidBag",
"TerrariaOverhaul",
"StarlightRiver",
"MoreAccessories",
"LogSpiralLibrary",
"CraftableAccessories",
"CraftableCalamityItems",
"RecipeBrowserToMagicStorage",
"SummonersAssociation",
"SpiritMod",
"ParticleLibrary",
"FargowiltasSoulsDLC",
"CalamityLootSwap",
"BossBagNoRng",
"BetterClasses",
"imkSushisMod",
"CompatChecker"]
Config settings: [No changes]
Game settings: [Large world (i know, i know)]
Gameplay events happening: [On opeing a world]
Your inputs: [what you did precisely to trigger the issue. EX: running to the left and using the thunderbuss to the right]
OS: [windows 10 64]
Additional context and log files
Add any other context about the problem here.
Please attach Client.Log for all single-player issues and both Cleint.log and Server.log (if the host) for all multiplayer issues.
Log files are integral to identifying and fixing bugs and especially crashes. Please make sure you include the ENTIRE LOG and not just the final error message. Log files are usually found under Steam\steamapps\common\tModLoader\tModLoader-Logs