From 81153cfdfad5385964928f35a3d96bfc6c674d63 Mon Sep 17 00:00:00 2001 From: Alessandro Pogliaghi Date: Wed, 22 Jul 2026 15:04:36 +0100 Subject: [PATCH] fix(tasks): acknowledge cloud task messages asynchronously Generated-By: PostHog Code Task-Id: 7e2afcdb-b4f2-4a41-80a3-7e0d53b4abc3 --- products/tasks/backend/logic/services/agent_command.py | 3 +++ .../process_task/activities/forward_pending_message.py | 1 + .../process_task/tests/test_forward_pending_message.py | 1 + 3 files changed, 5 insertions(+) diff --git a/products/tasks/backend/logic/services/agent_command.py b/products/tasks/backend/logic/services/agent_command.py index e841bb2f52fd..d445430b3b17 100644 --- a/products/tasks/backend/logic/services/agent_command.py +++ b/products/tasks/backend/logic/services/agent_command.py @@ -285,6 +285,7 @@ def send_user_message( timeout: int = COMMAND_TIMEOUT_SECONDS, message_id: str | None = None, steer: bool = False, + wait_for_completion: bool = True, ) -> CommandResult: """Send a user_message command to the sandbox agent. @@ -301,6 +302,8 @@ def send_user_message( params["messageId"] = message_id if steer: params["steer"] = True + if not wait_for_completion: + params["waitForCompletion"] = False return send_agent_command( task_run, method="user_message", diff --git a/products/tasks/backend/temporal/process_task/activities/forward_pending_message.py b/products/tasks/backend/temporal/process_task/activities/forward_pending_message.py index fc62c9b3bbd2..94fea8563b5c 100644 --- a/products/tasks/backend/temporal/process_task/activities/forward_pending_message.py +++ b/products/tasks/backend/temporal/process_task/activities/forward_pending_message.py @@ -128,6 +128,7 @@ def _ensure_pending_message_id(state: dict[str, Any]) -> None: auth_token=auth_token, timeout=PENDING_MESSAGE_TIMEOUT_SECONDS, message_id=pending_message_id, + wait_for_completion=False, ) logger.info( "forward_pending_message_attempted", diff --git a/products/tasks/backend/temporal/process_task/tests/test_forward_pending_message.py b/products/tasks/backend/temporal/process_task/tests/test_forward_pending_message.py index a464f25054ab..a09b312328da 100644 --- a/products/tasks/backend/temporal/process_task/tests/test_forward_pending_message.py +++ b/products/tasks/backend/temporal/process_task/tests/test_forward_pending_message.py @@ -101,6 +101,7 @@ def test_pending_message_delivered_successfully(self, mock_send, mock_token): forward_pending_user_message(str(run.id)) mock_send.assert_called_once() + assert mock_send.call_args.kwargs["wait_for_completion"] is False assert mock_send.call_args[0][1] == "fix the tests" assert mock_send.call_args.kwargs["message_id"] run.refresh_from_db()