From 74eb93e2eaf883e20d8d326542347f1ae2c477fe Mon Sep 17 00:00:00 2001 From: Phill <14913130+phillram@users.noreply.github.com> Date: Tue, 1 Sep 2026 14:43:01 -0700 Subject: [PATCH 1/2] docs(surveys): correct EmojiRating unselected tint in KDoc The KDoc said unselected emojis use ratingButtonColor. The code tints them with inputTextColor at 50% alpha, which matches the iOS SDK. Correct the doc to describe what the code does. Generated-By: PostHog Desktop Task-Id: d4c503a5-e8e6-46d4-aedc-0ad42bfef186 --- .../android/surveys/compose/internal/ui/EmojiRating.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt b/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt index 287ba690c..61fd8f33c 100644 --- a/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt +++ b/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt @@ -50,7 +50,9 @@ import com.posthog.surveys.PostHogDisplaySurveyTextContentType * * Selected emojis are tinted * [com.posthog.android.surveys.compose.internal.theme.ResolvedSurveyAppearance.ratingButtonActiveColor], - * unselected use `ratingButtonColor`. + * unselected use + * [com.posthog.android.surveys.compose.internal.theme.ResolvedSurveyAppearance.inputTextColor] + * at 50% alpha. */ @Composable internal fun EmojiRating( From 1e4142a7828e04f6c11ff5041db53b25c6dc4dca Mon Sep 17 00:00:00 2001 From: Phill <14913130+phillram@users.noreply.github.com> Date: Tue, 1 Sep 2026 15:18:31 -0700 Subject: [PATCH 2/2] docs(surveys): note thumbs scale in EmojiRating KDoc The summary said the control renders 3 or 5 face shapes. emojisForScale maps a 2-point scale to thumbs up and thumbs down, and there is a preview for that case. The surrounding comments already describe thumbs; the class KDoc was the last place that did not. Also give the unselected clause its noun. Generated-By: PostHog Desktop Task-Id: d4c503a5-e8e6-46d4-aedc-0ad42bfef186 --- .../android/surveys/compose/internal/ui/EmojiRating.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt b/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt index 61fd8f33c..e40dacc50 100644 --- a/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt +++ b/posthog-android-surveys-compose/src/main/java/com/posthog/android/surveys/compose/internal/ui/EmojiRating.kt @@ -40,8 +40,9 @@ import com.posthog.surveys.PostHogDisplaySurveyTextContentType * [PostHogDisplayRatingQuestion.ratingType] equal to * [PostHogDisplaySurveyRatingType.EMOJI]. * - * Renders 3 or 5 face shapes (Dissatisfied / Neutral / Satisfied for scale 3, - * VeryDissatisfied → VerySatisfied for scale 5). The face artwork is the same + * Renders 2, 3, or 5 shapes (thumbs up / thumbs down for scale 2, + * Dissatisfied / Neutral / Satisfied for scale 3, VeryDissatisfied → + * VerySatisfied for scale 5). The artwork is the same * SVG used by the web product (posthog-js * `packages/browser/src/extensions/surveys/icons.tsx`) — the exact `d` path * strings are embedded verbatim in [PostHogEmoji] and parsed at draw time by @@ -50,7 +51,7 @@ import com.posthog.surveys.PostHogDisplaySurveyTextContentType * * Selected emojis are tinted * [com.posthog.android.surveys.compose.internal.theme.ResolvedSurveyAppearance.ratingButtonActiveColor], - * unselected use + * unselected ones use * [com.posthog.android.surveys.compose.internal.theme.ResolvedSurveyAppearance.inputTextColor] * at 50% alpha. */