run setup discovery agent in plan mode

Author: charlesvien

packages/ui/src/features/setup/setupRunServiceImpl.test.ts

@@ -0,0 +1,39 @@
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+const startMutate = vi.fn(async (_input: Record<string, unknown>) => {});
+
+vi.mock("@posthog/di/container", () => ({
+  resolveService: () => ({ agent: { start: { mutate: startMutate } } }),
+}));
+
+vi.mock("../../shell/analytics", () => ({
+  captureException: vi.fn(),
+  track: vi.fn(),
+}));
+
+import { SetupRunServiceImpl } from "./setupRunServiceImpl";
+
+describe("SetupRunServiceImpl.startAgent", () => {
+  beforeEach(() => {
+    startMutate.mockClear();
+  });
+
+  it("starts the discovery agent in plan mode, never bypassPermissions", async () => {
+    const service = new SetupRunServiceImpl();
+
+    await service.startAgent({
+      taskId: "task-1",
+      taskRunId: "run-1",
+      repoPath: "/repo",
+      apiHost: "https://us.posthog.com",
+      projectId: 1,
+      jsonSchema: {},
+    });
+
+    expect(startMutate).toHaveBeenCalledTimes(1);
+    expect(startMutate.mock.calls[0][0]).toMatchObject({
+      permissionMode: "plan",
+      disallowedTools: ["EnterPlanMode", "ExitPlanMode", "AskUserQuestion"],
+    });
+  });
+});

packages/ui/src/features/setup/setupRunServiceImpl.ts

@@ -111,7 +111,11 @@ export class SetupRunServiceImpl implements ISetupRunService {
       repoPath: input.repoPath,
       apiHost: input.apiHost,
       projectId: input.projectId,
-      permissionMode: "bypassPermissions",
+      // Read-only scan: plan mode denies write/exec tools (VERIA-356).
+      permissionMode: "plan",
+      // Deny tools that would open a permission prompt no one answers on an
+      // auto-launched run, which an injected repo could exploit to hang it.
+      disallowedTools: ["EnterPlanMode", "ExitPlanMode", "AskUserQuestion"],
       jsonSchema: input.jsonSchema,
     });
   }