run setup discovery agent in plan mode

Author: charlesvien

packages/agent/src/adapters/claude/session/options.ts

@@ -449,7 +449,11 @@ export function buildSessionOptions(params: BuildOptionsParams): Options {
     ...params.userProvidedOptions,
     betas: ["context-1m-2025-08-07"],
     systemPrompt: params.systemPrompt ?? buildSystemPrompt(),
-    settingSources: ["user", "project", "local"],
+    settingSources: params.userProvidedOptions?.settingSources ?? [
+      "user",
+      "project",
+      "local",
+    ],
     stderr: (err) => params.logger.error(err),
     cwd: params.cwd,
     includePartialMessages: true,

packages/ui/src/features/setup/setupRunServiceImpl.test.ts

@@ -0,0 +1,40 @@
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+const startMutate = vi.fn(async (_input: Record<string, unknown>) => {});
+
+vi.mock("@posthog/di/container", () => ({
+  resolveService: () => ({ agent: { start: { mutate: startMutate } } }),
+}));
+
+vi.mock("../../shell/analytics", () => ({
+  captureException: vi.fn(),
+  track: vi.fn(),
+}));
+
+import { SetupRunServiceImpl } from "./setupRunServiceImpl";
+
+describe("SetupRunServiceImpl.startAgent", () => {
+  beforeEach(() => {
+    startMutate.mockClear();
+  });
+
+  it("starts the discovery agent in plan mode, never bypassPermissions", async () => {
+    const service = new SetupRunServiceImpl();
+
+    await service.startAgent({
+      taskId: "task-1",
+      taskRunId: "run-1",
+      repoPath: "/repo",
+      apiHost: "https://us.posthog.com",
+      projectId: 1,
+      jsonSchema: {},
+    });
+
+    expect(startMutate).toHaveBeenCalledTimes(1);
+    expect(startMutate.mock.calls[0][0]).toMatchObject({
+      permissionMode: "plan",
+      disallowedTools: ["EnterPlanMode", "ExitPlanMode", "AskUserQuestion"],
+      settingSources: ["user"],
+    });
+  });
+});

packages/ui/src/features/setup/setupRunServiceImpl.ts

@@ -111,7 +111,14 @@ export class SetupRunServiceImpl implements ISetupRunService {
       repoPath: input.repoPath,
       apiHost: input.apiHost,
       projectId: input.projectId,
-      permissionMode: "bypassPermissions",
+      // Read-only scan: plan mode denies write/exec tools (VERIA-356).
+      permissionMode: "plan",
+      // Deny tools that would open a permission prompt no one answers on an
+      // auto-launched run, which an injected repo could exploit to hang it.
+      disallowedTools: ["EnterPlanMode", "ExitPlanMode", "AskUserQuestion"],
+      // Skip the repo's project/local .claude settings so a committed hook
+      // can't execute when discovery auto-starts against an untrusted repo.
+      settingSources: ["user"],
       jsonSchema: input.jsonSchema,
     });
   }

packages/workspace-server/src/services/agent/agent.ts

@@ -248,6 +248,7 @@ function buildClaudeCodeOptions(args: {
   effort?: EffortLevel;
   plugins: { type: "local"; path: string }[];
   disallowedTools?: string[];
+  settingSources?: ("user" | "project" | "local")[];
 }) {
   return {
     ...(args.additionalDirectories?.length && {
@@ -257,6 +258,9 @@ function buildClaudeCodeOptions(args: {
     ...(args.disallowedTools?.length && {
       disallowedTools: args.disallowedTools,
     }),
+    ...(args.settingSources?.length && {
+      settingSources: args.settingSources,
+    }),
     plugins: args.plugins,
   };
 }
@@ -278,6 +282,8 @@ interface SessionConfig {
   systemPromptOverride?: string;
   /** Tool names denied for this session (passed to the Claude SDK). */
   disallowedTools?: string[];
+  /** SDK setting sources to load; omit for the default user+project+local. */
+  settingSources?: ("user" | "project" | "local")[];
   /** Effort level for Claude sessions */
   effort?: EffortLevel;
   /** Model to use for the session (e.g. "claude-sonnet-4-6") */
@@ -779,6 +785,7 @@ If a repository IS genuinely required, attach one in this priority order:
       customInstructions,
       systemPromptOverride,
       disallowedTools,
+      settingSources,
       effort,
       model,
       jsonSchema,
@@ -1010,6 +1017,7 @@ If a repository IS genuinely required, attach one in this priority order:
         effort,
         plugins,
         disallowedTools,
+        settingSources,
       });
 
       let configOptions: SessionConfigOption[] | undefined;
@@ -2131,6 +2139,8 @@ For git operations while detached:
           : undefined,
       disallowedTools:
         "disallowedTools" in params ? params.disallowedTools : undefined,
+      settingSources:
+        "settingSources" in params ? params.settingSources : undefined,
       effort: "effort" in params ? params.effort : undefined,
       model: "model" in params ? params.model : undefined,
       jsonSchema: "jsonSchema" in params ? params.jsonSchema : undefined,

packages/workspace-server/src/services/agent/schemas.ts

@@ -77,6 +77,12 @@ export const startSessionInput = z.object({
    * Lets a sandboxed surface deny file/shell/network tools.
    */
   disallowedTools: z.array(z.string()).optional(),
+  /**
+   * SDK setting sources to load. Discovery passes ["user"] to skip the repo's
+   * project/local .claude settings, so a committed hook can't execute on an
+   * auto-launched scan (VERIA-356). Omit for the default user+project+local.
+   */
+  settingSources: z.array(z.enum(["user", "project", "local"])).optional(),
   effort: effortLevelSchema.optional(),
   model: z.string().optional(),
   jsonSchema: z.record(z.string(), z.unknown()).nullish(),