fix(channels): decouple task board from removed home

Generated-By: PostHog Code
Task-Id: 1fbd8776-9d5b-4e74-9629-a6bdb8d3b78f

Author: puemos

packages/core/src/tasks/taskBoardStatus.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { taskBoardStatus, taskBoardStatusFromSources } from "./taskBoardStatus";
+import { taskBoardStatus } from "./taskBoardStatus";
 
 describe("taskBoardStatus", () => {
   it.each([
@@ -17,15 +17,3 @@ describe("taskBoardStatus", () => {
     expect(taskBoardStatus(input)).toBe(expected);
   });
 });
-
-it("prefers a directly resolved merged PR over a stale open Home snapshot", () => {
-  expect(
-    taskBoardStatusFromSources({
-      resolvedPrState: "merged",
-      prSnapshot: {
-        state: "open",
-        ciStatus: "failing",
-      } as never,
-    }),
-  ).toBe("done");
-});

packages/core/src/tasks/taskBoardStatus.ts

@@ -1,5 +1,6 @@
 import type { TaskRunStatus } from "@posthog/shared/domain-types";
-import type { PrSnapshot, PrSnapshotState } from "../home/prSnapshot";
+
+export type TaskBoardPrState = "open" | "draft" | "merged" | "closed";
 
 export const TASK_BOARD_STATUSES = [
   "working",
@@ -15,7 +16,7 @@ export type TaskBoardStatus = (typeof TASK_BOARD_STATUSES)[number];
  */
 export function taskBoardStatus(input: {
   runStatus?: TaskRunStatus | null;
-  prState?: PrSnapshotState | null;
+  prState?: TaskBoardPrState | null;
 }): TaskBoardStatus {
   if (input.prState === "merged") return "done";
   if (input.prState === "closed") return "cancelled";
@@ -27,15 +28,3 @@ export function taskBoardStatus(input: {
   if (input.runStatus === "completed") return "done";
   return "working";
 }
-
-export function taskBoardStatusFromSources(input: {
-  runStatus?: TaskRunStatus | null;
-  resolvedPrState?: PrSnapshotState | null;
-  prSnapshot?: PrSnapshot | null;
-}): TaskBoardStatus {
-  return taskBoardStatus({
-    runStatus: input.runStatus,
-    // Direct PR resolution is fresher than the periodically rebuilt Home row.
-    prState: input.resolvedPrState ?? input.prSnapshot?.state,
-  });
-}

packages/ui/src/features/canvas/components/ChannelBoardView.tsx

@@ -5,11 +5,10 @@ import {
   GitCommit,
   XCircle,
 } from "@phosphor-icons/react";
-import type { PrSnapshot } from "@posthog/core/home/prSnapshot";
 import {
   TASK_BOARD_STATUSES,
   type TaskBoardStatus,
-  taskBoardStatusFromSources,
+  taskBoardStatus,
 } from "@posthog/core/tasks/taskBoardStatus";
 import type { Task } from "@posthog/shared/domain-types";
 import { UserAvatar } from "@posthog/ui/features/auth/UserAvatar";
@@ -82,14 +81,12 @@ const STATUS_VISUAL: Record<
 export function ChannelBoardView({
   tasks,
   isLoading,
-  prSnapshotByTaskId,
   taskPrStates,
   onOpenTask,
   onOpenThread,
 }: {
   tasks: Task[];
   isLoading: boolean;
-  prSnapshotByTaskId: ReadonlyMap<string, PrSnapshot>;
   taskPrStates: ChannelTaskPrStates;
   onOpenTask: (task: Task) => void;
   onOpenThread: (task: Task) => void;
@@ -115,14 +112,12 @@ export function ChannelBoardView({
       // A task with a PR cannot be classified until its first PR response.
       // Omitting it temporarily avoids showing it as Working and then moving it.
       if (taskPrStates.pendingTaskIds.has(task.id)) continue;
-      const snapshot = prSnapshotByTaskId.get(task.id);
       const resolvedPrState = taskPrStates.states.get(task.id);
-      const status = taskBoardStatusFromSources({
+      const status = taskBoardStatus({
         runStatus: task.latest_run?.status,
-        resolvedPrState,
-        prSnapshot: snapshot,
+        prState: resolvedPrState,
       });
-      const prState = resolvedPrState ?? snapshot?.state ?? null;
+      const prState = resolvedPrState ?? null;
       grouped.get(status)?.push({
         task,
         status,
@@ -136,7 +131,7 @@ export function ChannelBoardView({
       ...STATUS_VISUAL[status],
       items: grouped.get(status) ?? [],
     }));
-  }, [prSnapshotByTaskId, taskPrStates, tasks]);
+  }, [taskPrStates, tasks]);
 
   if (isLoading) {
     return <div className="min-h-0 flex-1" />;
@@ -153,7 +148,7 @@ export function ChannelBoardView({
           status={status}
           prState={prState}
           badgePrState={badgePrState}
-          prUrl={taskPrUrl(task, prSnapshotByTaskId) ?? undefined}
+          prUrl={taskPrUrl(task) ?? undefined}
           onOpenTask={onOpenTask}
           onOpenThread={onOpenThread}
         />

packages/ui/src/features/canvas/components/ChannelFeedView.tsx

@@ -148,7 +148,7 @@ function dayLabel(iso: string, now: Date): string {
   return `${weekday}, ${month} ${day}${year}`;
 }
 
-interface TaskStatusDisplay {
+export interface TaskStatusDisplay {
   // The run/environment badge ("Local", "Completed", "In progress", …).
   base: ReactNode;
   // The PR's GitHub state, shown alongside the run badge when a PR exists.
@@ -168,7 +168,7 @@ interface TaskStatusDisplay {
 // shipped task never reads "Ready + Merged" or a stale "In progress + PR
 // ready". A failed/cancelled run suppresses the PR badge instead — that is a
 // deliberate end state we should not soften with a PR.
-function useTaskStatusDisplay(task: Task): TaskStatusDisplay {
+export function useTaskStatusDisplay(task: Task): TaskStatusDisplay {
   const data = useChannelTaskData(task);
   const { prState } = useTaskPrStatus({
     id: task.id,
@@ -247,7 +247,7 @@ function PrStateBadge({ prState }: { prState: Exclude<SidebarPrState, null> }) {
   return <Badge variant={variant}>{label}</Badge>;
 }
 
-function TaskStatusBadge({ display }: { display: TaskStatusDisplay }) {
+export function TaskStatusBadge({ display }: { display: TaskStatusDisplay }) {
   return (
     <div className="flex shrink-0 items-center gap-1">
       {display.base}

packages/ui/src/features/canvas/components/WebsiteChannelHome.tsx

@@ -1,5 +1,4 @@
 import { Kanban, ListBullets, Plus, User } from "@phosphor-icons/react";
-import type { PrSnapshot } from "@posthog/core/home/prSnapshot";
 import { insertTaskDedup } from "@posthog/core/tasks/taskDelete";
 import { Button } from "@posthog/quill";
 import { CHANNEL_TASK_BOARD_FLAG } from "@posthog/shared";
@@ -50,7 +49,6 @@ import {
 import { useChannelHomeUiStore } from "@posthog/ui/features/canvas/stores/channelHomeUiStore";
 import { useThreadPanelStore } from "@posthog/ui/features/canvas/stores/threadPanelStore";
 import { useFeatureFlag } from "@posthog/ui/features/feature-flags/useFeatureFlag";
-import { useHomeSnapshot } from "@posthog/ui/features/home/hooks/useHomeSnapshot";
 import { SuggestedPromptCard } from "@posthog/ui/features/task-detail/components/SuggestedPromptCard";
 import { taskDetailQuery } from "@posthog/ui/features/tasks/queries";
 import { useSetHeaderContent } from "@posthog/ui/hooks/useSetHeaderContent";
@@ -79,7 +77,6 @@ export function WebsiteChannelHome({ channelId }: { channelId: string }) {
   const effectiveViewMode = boardEnabled ? viewMode : "feed";
   const client = useOptionalAuthenticatedClient();
   const { data: currentUser } = useCurrentUser({ client });
-  const { snapshot: homeSnapshot } = useHomeSnapshot();
 
   // Poll while empty so the intro's context.md card flips to "created" when
   // the agent publishes mid plan-session, without a manual reload.
@@ -132,22 +129,8 @@ export function WebsiteChannelHome({ channelId }: { channelId: string }) {
         : tasks,
     [boardEnabled, currentUser?.uuid, taskScope, tasks],
   );
-  const prSnapshotByTaskId = useMemo(() => {
-    const result = new Map<string, PrSnapshot>();
-    for (const workstream of [
-      ...homeSnapshot.needsAttention,
-      ...homeSnapshot.inProgress,
-    ]) {
-      if (!workstream.pr) continue;
-      for (const task of workstream.tasks) {
-        result.set(task.id, workstream.pr);
-      }
-    }
-    return result;
-  }, [homeSnapshot.inProgress, homeSnapshot.needsAttention]);
   const taskPrStates = useChannelTaskPrStates(
     boardEnabled && effectiveViewMode === "board" ? visibleTasks : [],
-    prSnapshotByTaskId,
   );
 
   const composerRef = useRef<ChannelHomeComposerHandle>(null);
@@ -250,14 +233,8 @@ export function WebsiteChannelHome({ channelId }: { channelId: string }) {
   );
   const handleOpenTask = useCallback((task: Task) => setPreviewTask(task), []);
   const handleOpenFeedTask = useCallback(
-    (task: Task) => {
-      if (boardEnabled) {
-        setPreviewTask(task);
-      } else {
-        handleOpenFull(task.id);
-      }
-    },
-    [boardEnabled, handleOpenFull],
+    (task: Task) => handleOpenFull(task.id),
+    [handleOpenFull],
   );
 
   const handleOpenThread = useCallback(
@@ -398,7 +375,6 @@ export function WebsiteChannelHome({ channelId }: { channelId: string }) {
           <ChannelBoardView
             tasks={visibleTasks}
             isLoading={isLoading}
-            prSnapshotByTaskId={prSnapshotByTaskId}
             taskPrStates={taskPrStates}
             onOpenTask={handleOpenTask}
             onOpenThread={handleOpenThread}
@@ -455,15 +431,11 @@ export function WebsiteChannelHome({ channelId }: { channelId: string }) {
           task={previewTask}
           channelId={channelId}
           prUrl={
-            previewTask
-              ? (taskPrUrl(previewTask, prSnapshotByTaskId) ?? undefined)
-              : undefined
+            previewTask ? (taskPrUrl(previewTask) ?? undefined) : undefined
           }
           prState={
             previewTask
-              ? (taskPrStates.states.get(previewTask.id) ??
-                prSnapshotByTaskId.get(previewTask.id)?.state ??
-                null)
+              ? (taskPrStates.states.get(previewTask.id) ?? null)
               : null
           }
           onClose={() => setPreviewTask(null)}

packages/ui/src/features/canvas/hooks/useChannelTaskPrStates.test.ts

@@ -1,5 +1,5 @@
-import { describe, expect, it } from "vitest";
 import type { Task } from "@posthog/shared/domain-types";
+import { describe, expect, it } from "vitest";
 import { prDetailsToState, taskPrUrl } from "./useChannelTaskPrStates";
 
 describe("prDetailsToState", () => {
@@ -21,20 +21,7 @@ describe("taskPrUrl", () => {
     latest_run: { output: { pr_url: "https://github.com/o/r/pull/1" } },
   } as unknown as Task;
 
-  it("prefers the Home snapshot URL", () => {
-    expect(
-      taskPrUrl(
-        task,
-        new Map([
-          ["task-1", { url: "https://github.com/o/r/pull/2" }],
-        ]),
-      ),
-    ).toBe("https://github.com/o/r/pull/2");
-  });
-
-  it("falls back to the latest run URL", () => {
-    expect(taskPrUrl(task, new Map())).toBe(
-      "https://github.com/o/r/pull/1",
-    );
+  it("reads the latest run URL", () => {
+    expect(taskPrUrl(task)).toBe("https://github.com/o/r/pull/1");
   });
 });

packages/ui/src/features/canvas/hooks/useChannelTaskPrStates.ts

@@ -1,4 +1,3 @@
-import type { PrSnapshot } from "@posthog/core/home/prSnapshot";
 import type { Task } from "@posthog/shared/domain-types";
 import {
   type PrStateDetails,
@@ -18,16 +17,10 @@ export function prDetailsToState(
   return null;
 }
 
-export function taskPrUrl(
-  task: Task,
-  prSnapshotByTaskId: ReadonlyMap<string, Pick<PrSnapshot, "url">>,
-): string | null {
-  return (
-    prSnapshotByTaskId.get(task.id)?.url ??
-    (typeof task.latest_run?.output?.pr_url === "string"
-      ? task.latest_run.output.pr_url
-      : null)
-  );
+export function taskPrUrl(task: Task): string | null {
+  return typeof task.latest_run?.output?.pr_url === "string"
+    ? task.latest_run.output.pr_url
+    : null;
 }
 
 export interface ChannelTaskPrStates {
@@ -37,20 +30,17 @@ export interface ChannelTaskPrStates {
   isRefreshing: boolean;
 }
 
-export function useChannelTaskPrStates(
-  tasks: Task[],
-  prSnapshotByTaskId: ReadonlyMap<string, PrSnapshot>,
-): ChannelTaskPrStates {
+export function useChannelTaskPrStates(tasks: Task[]): ChannelTaskPrStates {
   const prUrls = useMemo(
     () => [
       ...new Set(
         tasks.flatMap((task) => {
-          const prUrl = taskPrUrl(task, prSnapshotByTaskId);
+          const prUrl = taskPrUrl(task);
           return prUrl ? [prUrl] : [];
         }),
       ),
     ],
-    [prSnapshotByTaskId, tasks],
+    [tasks],
   );
   const results = usePrDetailsQueries(prUrls);
 
@@ -63,7 +53,7 @@ export function useChannelTaskPrStates(
     let isRefreshing = false;
 
     for (const task of tasks) {
-      const prUrl = taskPrUrl(task, prSnapshotByTaskId);
+      const prUrl = taskPrUrl(task);
       const result = prUrl ? resultByUrl.get(prUrl) : undefined;
       if (prUrl && result && !result.data && result.isPending) {
         pendingTaskIds.add(task.id);
@@ -83,5 +73,5 @@ export function useChannelTaskPrStates(
       isResolving: pendingTaskIds.size > 0,
       isRefreshing,
     };
-  }, [prSnapshotByTaskId, prUrls, results, tasks]);
+  }, [prUrls, results, tasks]);
 }