From eba9f8ce58ce9c16d3b7346c254585c302cf5029 Mon Sep 17 00:00:00 2001 From: Sameeul B Samee Date: Thu, 3 Jul 2025 06:37:55 -0400 Subject: [PATCH 1/3] bugfix: update ImageReader close() call --- src/bfio/backends.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bfio/backends.py b/src/bfio/backends.py index 4bc52e3..c2c6445 100644 --- a/src/bfio/backends.py +++ b/src/bfio/backends.py @@ -8,6 +8,7 @@ from pathlib import Path from typing import Dict, List, Tuple import threading +from jpype import JBoolean # Third party packages import imagecodecs @@ -1046,7 +1047,7 @@ def _read_image(self, X, Y, Z, C, T, output): def close(self): if jpype.isJVMStarted() and self._rdr is not None: - self._rdr.close() + self._rdr.close(JBoolean(False)) def __del__(self): self.close() From b5c953a7b56c0695b9f018747866ab7981afb334 Mon Sep 17 00:00:00 2001 From: Sameeul B Samee Date: Thu, 3 Jul 2025 06:44:05 -0400 Subject: [PATCH 2/3] bugfix: update ImageReader close() call --- src/bfio/backends.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/bfio/backends.py b/src/bfio/backends.py index c2c6445..cb1b8c2 100644 --- a/src/bfio/backends.py +++ b/src/bfio/backends.py @@ -8,7 +8,6 @@ from pathlib import Path from typing import Dict, List, Tuple import threading -from jpype import JBoolean # Third party packages import imagecodecs @@ -1047,7 +1046,7 @@ def _read_image(self, X, Y, Z, C, T, output): def close(self): if jpype.isJVMStarted() and self._rdr is not None: - self._rdr.close(JBoolean(False)) + self._rdr.close(False) def __del__(self): self.close() From b00b836dc51427d8dd0cdd68aed9249f1c352a46 Mon Sep 17 00:00:00 2001 From: Sameeul B Samee Date: Thu, 3 Jul 2025 07:17:17 -0400 Subject: [PATCH 3/3] test with jpype < 1.5.1 --- pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 9a26f3f..0116c06 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -9,7 +9,7 @@ requires = [ "ome-types>=0.4.2", "zarr>=2.6.1,<3", "scyjava", - "jpype1", + "jpype1<1.5.1", "tifffile>=2022.8.12", "bfiocpp" ] @@ -25,7 +25,7 @@ dependencies = [ "ome-types>=0.4.2", "zarr>=2.6.1,<3", "scyjava", - "jpype1", + "jpype1<1.5.1", "tifffile>=2022.8.12", "bfiocpp" ]