From 984cd66246ab59ab3a2f75d930d917574285c72d Mon Sep 17 00:00:00 2001 From: T1erno Date: Fri, 9 Jan 2026 12:16:29 -0600 Subject: [PATCH 1/9] Added --impersonate flag on mssql protocol --- nxc/protocols/mssql.py | 53 +++++++++++++++++++++++++++++++ nxc/protocols/mssql/proto_args.py | 1 + 2 files changed, 54 insertions(+) diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index 66395530e4..df2de9e04f 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -44,6 +44,7 @@ def __init__(self, args, db, host): self.lmhash = "" self.nthash = "" self.is_mssql = False + self.impersonation_applied = False connection.__init__(self, args, db, host) @@ -157,6 +158,21 @@ def print_host_info(self): encryption = colored(f"EncryptionReq:{self.encryption}", host_info_colors[0 if self.encryption else 1], attrs=["bold"]) self.logger.display(f"{self.server_os} (name:{self.hostname}) (domain:{self.targetDomain}) ({encryption})") + def call_cmd_args(self): + if getattr(self.args, "impersonate", None) and not self.impersonation_applied and not self.impersonate(): + return + for attr, value in vars(self.args).items(): + if attr == "impersonate": + continue + if hasattr(self, attr) and callable(getattr(self, attr)) and value is not False and value is not None: + self.logger.debug(f"Calling {attr}()") + getattr(self, attr)() + + def call_modules(self): + if getattr(self.args, "impersonate", None) and not self.impersonation_applied and not self.impersonate(): + return + super().call_modules() + @reconnect_mssql def kerberos_login(self, domain, username, password="", ntlm_hash="", aesKey="", kdcHost="", useCache=False): self.username = username @@ -276,6 +292,43 @@ def hash_login(self, domain, username, ntlm_hash): self.logger.fail(f"{self.domain}\\{self.username}:{process_secret(self.nthash)} {error_msg if error_msg else ''}") return False + def impersonate(self): + target = self.args.impersonate + if not target: + self.logger.error("No impersonation target specified") + return False + + mode = "LOGIN" + raw_target = str(target) + lowered = raw_target.lower() + if lowered.startswith("login:"): + raw_target = raw_target.split(":", 1)[1] + mode = "LOGIN" + elif lowered.startswith("user:"): + raw_target = raw_target.split(":", 1)[1] + mode = "USER" + + raw_target = raw_target.strip() + if not raw_target: + self.logger.error("Impersonation target is empty") + return False + + safe_target = raw_target.replace("'", "''") + try: + self.conn.sql_query(f"EXECUTE AS {mode} = N'{safe_target}';") + if self.conn.lastError: + self.logger.fail(self.conn.lastError) + return False + self.logger.success(f"Impersonation set: {mode}={raw_target}") + self.impersonation_applied = True + if self.args.debug: + res = self.conn.sql_query("SELECT SYSTEM_USER, SUSER_SNAME();") + self.logger.debug(f"Impersonated context: {res}") + except Exception as e: + self.logger.fail(f"Failed to impersonate {mode} {raw_target}: {e}") + return False + return True + def query(self): if self.conn.lastError: # Invalid connection diff --git a/nxc/protocols/mssql/proto_args.py b/nxc/protocols/mssql/proto_args.py index 9d494ed44e..74c71f3983 100644 --- a/nxc/protocols/mssql/proto_args.py +++ b/nxc/protocols/mssql/proto_args.py @@ -6,6 +6,7 @@ def proto_args(parser, parents): mssql_parser.add_argument("-H", "--hash", metavar="HASH", dest="hash", nargs="+", default=[], help="NTLM hash(es) or file(s) containing NTLM hashes") mssql_parser.add_argument("--port", default=1433, type=int, metavar="PORT", help="MSSQL port") mssql_parser.add_argument("--mssql-timeout", help="SQL server connection timeout", type=int, default=5) + mssql_parser.add_argument("--impersonate", metavar="LOGIN|USER", type=str, help="impersonate a login or user (prefix with login: or user:, default: login)") mssql_parser.add_argument("-q", "--query", metavar="QUERY", type=str, help="execute the specified query against the mssql db") mssql_parser.add_argument("--database", nargs="?", const=True, metavar="NAME", help="list databases or list tables for NAME") From 8c3bec97573e9afed7835680f3b2ed28282b4e61 Mon Sep 17 00:00:00 2001 From: T1erno Date: Sun, 22 Mar 2026 14:16:42 -0600 Subject: [PATCH 2/9] Fail closed on MSSQL impersonation errors --- nxc/protocols/mssql.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index df2de9e04f..7e8eaafff2 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -160,7 +160,7 @@ def print_host_info(self): def call_cmd_args(self): if getattr(self.args, "impersonate", None) and not self.impersonation_applied and not self.impersonate(): - return + raise SystemExit for attr, value in vars(self.args).items(): if attr == "impersonate": continue @@ -170,7 +170,7 @@ def call_cmd_args(self): def call_modules(self): if getattr(self.args, "impersonate", None) and not self.impersonation_applied and not self.impersonate(): - return + raise SystemExit super().call_modules() @reconnect_mssql From 6b9b48ad15b09421ec487ab19dd22065768584c5 Mon Sep 17 00:00:00 2001 From: T1erno Date: Sun, 22 Mar 2026 14:16:55 -0600 Subject: [PATCH 3/9] Run protocol args before modules --- nxc/connection.py | 5 ++--- nxc/protocols/mssql.py | 2 -- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/nxc/connection.py b/nxc/connection.py index 062b91c139..3a929ae55e 100755 --- a/nxc/connection.py +++ b/nxc/connection.py @@ -253,13 +253,12 @@ def proto_flow(self): self.print_host_info() if self.login() or (self.username == "" and self.password == ""): + self.logger.debug("Calling command arguments") + self.call_cmd_args() if hasattr(self.args, "module") and self.args.module: self.load_modules() self.logger.debug("Calling modules") self.call_modules() - else: - self.logger.debug("Calling command arguments") - self.call_cmd_args() self.disconnect() def call_cmd_args(self): diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index 7e8eaafff2..b66db4e206 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -169,8 +169,6 @@ def call_cmd_args(self): getattr(self, attr)() def call_modules(self): - if getattr(self.args, "impersonate", None) and not self.impersonation_applied and not self.impersonate(): - raise SystemExit super().call_modules() @reconnect_mssql From a4a3c1653155d5507e9555273aa69996516a7a26 Mon Sep 17 00:00:00 2001 From: T1erno Date: Sun, 22 Mar 2026 14:17:09 -0600 Subject: [PATCH 4/9] Simplify MSSQL impersonation target parsing --- nxc/protocols/mssql.py | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index b66db4e206..192e7db86a 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -291,39 +291,32 @@ def hash_login(self, domain, username, ntlm_hash): return False def impersonate(self): - target = self.args.impersonate - if not target: - self.logger.error("No impersonation target specified") - return False - mode = "LOGIN" - raw_target = str(target) - lowered = raw_target.lower() - if lowered.startswith("login:"): - raw_target = raw_target.split(":", 1)[1] + target = self.args.impersonate.strip() + if target.lower().startswith("login:"): + target = target.split(":", 1)[1].strip() mode = "LOGIN" - elif lowered.startswith("user:"): - raw_target = raw_target.split(":", 1)[1] + elif target.lower().startswith("user:"): + target = target.split(":", 1)[1].strip() mode = "USER" - raw_target = raw_target.strip() - if not raw_target: + if not target: self.logger.error("Impersonation target is empty") return False - safe_target = raw_target.replace("'", "''") + safe_target = target.replace("'", "''") try: self.conn.sql_query(f"EXECUTE AS {mode} = N'{safe_target}';") if self.conn.lastError: self.logger.fail(self.conn.lastError) return False - self.logger.success(f"Impersonation set: {mode}={raw_target}") + self.logger.success(f"Impersonation set: {mode}={target}") self.impersonation_applied = True if self.args.debug: res = self.conn.sql_query("SELECT SYSTEM_USER, SUSER_SNAME();") self.logger.debug(f"Impersonated context: {res}") except Exception as e: - self.logger.fail(f"Failed to impersonate {mode} {raw_target}: {e}") + self.logger.fail(f"Failed to impersonate {mode} {target}: {e}") return False return True From 9430712c0ad652baffde061fa7c035db49a0ad9b Mon Sep 17 00:00:00 2001 From: T1erno Date: Sun, 22 Mar 2026 14:17:20 -0600 Subject: [PATCH 5/9] Always log MSSQL impersonation context at debug level --- nxc/protocols/mssql.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index 192e7db86a..4a3827a6dd 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -312,9 +312,8 @@ def impersonate(self): return False self.logger.success(f"Impersonation set: {mode}={target}") self.impersonation_applied = True - if self.args.debug: - res = self.conn.sql_query("SELECT SYSTEM_USER, SUSER_SNAME();") - self.logger.debug(f"Impersonated context: {res}") + res = self.conn.sql_query("SELECT SYSTEM_USER, SUSER_SNAME();") + self.logger.debug(f"Impersonated context: {res}") except Exception as e: self.logger.fail(f"Failed to impersonate {mode} {target}: {e}") return False From 067261a43834dab08dc92d6909faf739b7dc0170 Mon Sep 17 00:00:00 2001 From: T1erno Date: Sun, 22 Mar 2026 14:19:49 -0600 Subject: [PATCH 6/9] Created MSSQL impersonation e2e command --- tests/e2e_commands.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/e2e_commands.txt b/tests/e2e_commands.txt index 944b44e65a..47855b4283 100644 --- a/tests/e2e_commands.txt +++ b/tests/e2e_commands.txt @@ -258,6 +258,7 @@ netexec winrm TARGET_HOST -u LOGIN_USERNAME -p LOGIN_PASSWORD KERBEROS -M aws-cr ##### MSSQL netexec mssql TARGET_HOST -u LOGIN_USERNAME -p LOGIN_PASSWORD KERBEROS # Need a space at the end for kerb regex netexec {DNS} mssql TARGET_HOST -u LOGIN_USERNAME -p LOGIN_PASSWORD KERBEROS # Need a space at the end for kerb regex +netexec mssql TARGET_HOST -u LOGIN_USERNAME -p LOGIN_PASSWORD KERBEROS --impersonate LOGIN_USERNAME netexec mssql TARGET_HOST -u LOGIN_USERNAME -p LOGIN_PASSWORD KERBEROS --rid-brute netexec mssql TARGET_HOST -u LOGIN_USERNAME -p LOGIN_PASSWORD KERBEROS --database netexec mssql TARGET_HOST -u LOGIN_USERNAME -p LOGIN_PASSWORD KERBEROS --sam From 952e13c40b679e59afab68819eb0dbb3a48b6b58 Mon Sep 17 00:00:00 2001 From: T1erno Date: Mon, 23 Mar 2026 22:35:53 -0600 Subject: [PATCH 7/9] Removed unused functions --- nxc/protocols/mssql.py | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index 4a3827a6dd..4301e1b8d3 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -158,19 +158,6 @@ def print_host_info(self): encryption = colored(f"EncryptionReq:{self.encryption}", host_info_colors[0 if self.encryption else 1], attrs=["bold"]) self.logger.display(f"{self.server_os} (name:{self.hostname}) (domain:{self.targetDomain}) ({encryption})") - def call_cmd_args(self): - if getattr(self.args, "impersonate", None) and not self.impersonation_applied and not self.impersonate(): - raise SystemExit - for attr, value in vars(self.args).items(): - if attr == "impersonate": - continue - if hasattr(self, attr) and callable(getattr(self, attr)) and value is not False and value is not None: - self.logger.debug(f"Calling {attr}()") - getattr(self, attr)() - - def call_modules(self): - super().call_modules() - @reconnect_mssql def kerberos_login(self, domain, username, password="", ntlm_hash="", aesKey="", kdcHost="", useCache=False): self.username = username From ebd4ddd9bee783276316967eb437e5747906ab21 Mon Sep 17 00:00:00 2001 From: T1erno Date: Mon, 23 Mar 2026 22:36:43 -0600 Subject: [PATCH 8/9] Use nargs=1 for MSSQL impersonation argument --- nxc/protocols/mssql.py | 2 +- nxc/protocols/mssql/proto_args.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index 4301e1b8d3..5a71c9bf6a 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -279,7 +279,7 @@ def hash_login(self, domain, username, ntlm_hash): def impersonate(self): mode = "LOGIN" - target = self.args.impersonate.strip() + target = self.args.impersonate[0].strip() if target.lower().startswith("login:"): target = target.split(":", 1)[1].strip() mode = "LOGIN" diff --git a/nxc/protocols/mssql/proto_args.py b/nxc/protocols/mssql/proto_args.py index 74c71f3983..1c77740891 100644 --- a/nxc/protocols/mssql/proto_args.py +++ b/nxc/protocols/mssql/proto_args.py @@ -6,7 +6,7 @@ def proto_args(parser, parents): mssql_parser.add_argument("-H", "--hash", metavar="HASH", dest="hash", nargs="+", default=[], help="NTLM hash(es) or file(s) containing NTLM hashes") mssql_parser.add_argument("--port", default=1433, type=int, metavar="PORT", help="MSSQL port") mssql_parser.add_argument("--mssql-timeout", help="SQL server connection timeout", type=int, default=5) - mssql_parser.add_argument("--impersonate", metavar="LOGIN|USER", type=str, help="impersonate a login or user (prefix with login: or user:, default: login)") + mssql_parser.add_argument("--impersonate", nargs=1, metavar="LOGIN|USER", type=str, help="impersonate a login or user (prefix with login: or user:, default: login)") mssql_parser.add_argument("-q", "--query", metavar="QUERY", type=str, help="execute the specified query against the mssql db") mssql_parser.add_argument("--database", nargs="?", const=True, metavar="NAME", help="list databases or list tables for NAME") From bc90b43ee0398a2f65551d2629b39d0e2d6ce62d Mon Sep 17 00:00:00 2001 From: T1erno Date: Wed, 29 Apr 2026 22:26:00 -0600 Subject: [PATCH 9/9] MSSQL: remove target escaping to test impact --- nxc/protocols/mssql.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/nxc/protocols/mssql.py b/nxc/protocols/mssql.py index 5a71c9bf6a..105d97fefa 100755 --- a/nxc/protocols/mssql.py +++ b/nxc/protocols/mssql.py @@ -291,9 +291,8 @@ def impersonate(self): self.logger.error("Impersonation target is empty") return False - safe_target = target.replace("'", "''") try: - self.conn.sql_query(f"EXECUTE AS {mode} = N'{safe_target}';") + self.conn.sql_query(f"EXECUTE AS {mode} = N'{target}';") if self.conn.lastError: self.logger.fail(self.conn.lastError) return False