Repository navigation
Replies: 1 comment
|
Hi kwm365, Sorry this went unanswered for so long, and thank you for the careful reading. We have also replied to you in more detail by email (through your support ticket); here is the public part, so others looking at the same question can see it. You read it correctly:
If you would like to take this on, we would be glad to see a proposal here first and then a pull request. As the README says, PNLCS moves forward largely with help from the people who use it. If a change fits the existing architecture and works for current installs, we will gladly review and merge it, with credit. The contributing guide and module guide are good starting points. Thanks again for the help. Panelica Team |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Looking at how configurable options reach provisioning on current
main(commit acf0292), and I want to check whether I'm reading this correctly
or missing something.
What I see:
service_config_optionsand are picked up by pricing (
CartService) and by upgrades(
UpgradeService).ServiceConfigOptionacross
modules/returns nothing, while the same grep inapp/matches.PanelicaModule::createAccount()provisions from the product's JSONconfig using the
res_*limits, and creates one shared planpnlcs-p<id>per product rather than per service.If that is right, an option such as "RAM: 4 GB" changes the invoice
amount but not the provisioned account.
Questions:
or are options currently intended as a pricing mechanism only?
per-product plan, or is there another path you have in mind?
AfterModuleCreate, but the module's HTTP helpers are private, soit would mean a separate API client. And I don't see a hook point
for option changes on an existing service.
Same question applies to product add-ons, which look like they have the
same gap.
Happy to help test whatever direction you take.
regards
Martin
All reactions