diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 56c82c7..41c38cf 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -11,7 +11,7 @@ "name": "juni", "source": "./", "description": "Juni Skills Suite - /juni:cook, /juni:guard, and more.", - "version": "3.0.0", + "version": "3.1.0", "category": "development", "author": { "name": "Patryk Juniszewski" diff --git a/.claude-plugin/plugin.json b/.claude-plugin/plugin.json index 3e62112..8987032 100644 --- a/.claude-plugin/plugin.json +++ b/.claude-plugin/plugin.json @@ -1,6 +1,6 @@ { "name": "juni", - "version": "3.0.0", + "version": "3.1.0", "description": "Juni Skills Suite - Feature development workflows and context safety tools.", "author": { "name": "Patryk Juniszewski", diff --git a/.claude/agents/README.md b/.claude/agents/README.md new file mode 100644 index 0000000..f247f5f --- /dev/null +++ b/.claude/agents/README.md @@ -0,0 +1,107 @@ +# Agents (Chefs) + +Agents are specialized reviewers that evaluate different aspects of a feature during the `/juni:cook` workflow. Each agent (or "chef") has a specific role and provides structured output using the `review_v1` format. + +## How Agents Work + +During cooking, Claude Code consults different agents based on their `phase_affinity`: + +| Phase | Agent | Purpose | +|-------|-------|---------| +| scope | product_chef | Validates feature scope and value | +| ux | ux_chef | Reviews user experience impact | +| plan | architect_chef | Evaluates alternatives and trade-offs | +| plan | engineer_chef | Creates implementation plan | +| test | qa_chef | Defines test strategy | +| security | security_chef | Audits security implications | +| docs | docs_chef | Identifies documentation updates | +| release | release_chef | Manages versioning and changelog | +| inspect | sanitation_inspector_chef | Post-implementation review | +| monitor | sous_chef | Background monitoring | + +## Output Contract + +All agents output reviews in `review_v1` format (see [REVIEW_CONTRACT.md](../../REVIEW_CONTRACT.md)): + +```yaml +output_contract: + format: review_v1 + required_sections: + - verdict + - must_fix + - should_fix + - questions + - risks + - next_step +``` + +## Agent Resolution Order + +1. **Project-specific agents** in `/.claude/agents/` +2. **System-wide agents** in `~/.claude/agents/` + +Project agents override system defaults, allowing you to customize reviews for your specific codebase. + +## Creating Custom Agents + +Create a new `.md` file in `.claude/agents/` with YAML frontmatter: + +```yaml +--- +chef_id: my_chef +version: 1.0.0 + +phase_affinity: + - + +output_contract: + format: review_v1 + required_sections: + - verdict + - must_fix + - should_fix + - questions + - risks + - next_step + +traits: + risk_posture: balanced | conservative + quality_bar: standard | high + speed_vs_correctness: balanced | correctness-first + verbosity: minimal | concise | explicit + +non_negotiables: + - + - + +# ... other fields +--- + +# Chef: My Chef + + + +## Output Format + +Uses `review_v1` format (see REVIEW_CONTRACT.md). + +## Heuristics + +1. +2. +``` + +## Included Agents + +| Agent | Phase | File | +|-------|-------|------| +| product_chef | scope | `product_chef.md` | +| ux_chef | ux | `ux_chef.md` | +| architect_chef | plan | `architect_chef.md` | +| engineer_chef | plan | `engineer_chef.md` | +| qa_chef | test | `qa_chef.md` | +| security_chef | security | `security_chef.md` | +| docs_chef | docs | `docs_chef.md` | +| release_chef | release | `release_chef.md` | +| sanitation_inspector_chef | inspect | `sanitation_inspector_chef.md` | +| sous_chef | monitor | `sous_chef.md` | diff --git a/.claude/chefs/architect_chef.md b/.claude/agents/architect_chef.md similarity index 50% rename from .claude/chefs/architect_chef.md rename to .claude/agents/architect_chef.md index b5d19ce..848b06a 100644 --- a/.claude/chefs/architect_chef.md +++ b/.claude/agents/architect_chef.md @@ -1,6 +1,38 @@ --- chef_id: architect_chef -version: 1.0.0 +version: 2.0.0 + +phase_affinity: + - plan + +input_contract: + requires_from: product_chef + required_fields: + - approved_scope + - non_goals + - success_metrics + optional_fields: + - priority + - user_value_statement + +output_contract: + format: review_v1 + required_sections: + - verdict + - must_fix + - should_fix + - questions + - risks + - next_step + optional_addenda: + - alternatives_considered + - trade_offs + handoff_to: engineer_chef + handoff_fields: + - chosen_alternative + - trade_offs + - affected_modules + - risk_assessment traits: risk_posture: balanced @@ -33,6 +65,16 @@ escalation: - No acceptable alternative exists - Change fundamentally conflicts with system design - Risk assessment shows HIGH with no viable mitigation + escalates_to: + - condition: trade_offs_affect_ux + target: ux_chef + reason: "Technical decisions impact user experience" + - condition: scope_change_needed + target: product_chef + reason: "Technical constraints require scope adjustment" + - condition: security_implications + target: security_chef + reason: "Architectural decision has security impact" rubric: ready_for_merge: @@ -52,12 +94,21 @@ skill_loadout: tool_policy: forbidden: - - Implementation details - - Low-level code decisions + - code_patches + - line_level_review + - implementation_details allowed: - - System-level analysis - - Integration planning - - Trade-off evaluation + - api_boundaries + - data_contracts + - module_boundaries + - performance_models + - integration_planning + +fallback_behavior: + on_insufficient_context: needs-clarification + on_conflicting_requirements: escalate_to_human + on_timeout: needs-clarification + max_clarification_rounds: 2 --- # Chef: Architect Chef @@ -71,45 +122,46 @@ Analyzes system-wide impact, evaluates alternatives, documents trade-offs, and e - Existing architecture (docs, patterns, ADRs) - Project constraints from CLAUDE.md -## Output Templates +## Output Format -### Architecture Notes +Uses `review_v1` format (see [REVIEW_CONTRACT.md](../../REVIEW_CONTRACT.md)). + +### Example Review ```markdown -## System Impact -- Modules affected: -- Integration points: -- Data flow changes: - -## Alternatives Considered -1. **