Skip to content

chore(spp_programs): remove dead cycle_base.py (never imported, stale duplicate of cycle.py) #457

Description

@gonzalesedwin1123

Summary

spp_programs/models/cycle_base.py is dead code: it has never been imported in spp_programs/models/__init__.py (checked back to the initial v2 export, 4da8e30e). The live spp.cycle model is defined in spp_programs/models/cycle.py; cycle_base.py is a stale near-duplicate (~700 lines) that defines the same _name = "spp.cycle" but is never loaded by Odoo.

$ grep -n "cycle" spp_programs/models/__init__.py
from . import cycle
from . import cycle_membership
# no cycle_base

Why it matters

Proposed fix

Delete spp_programs/models/cycle_base.py. Before deleting, diff it against cycle.py to confirm nothing in it is newer than the live implementation (spot-check suggests it's an older snapshot, but the diff should be part of the PR description).

No manifest version bump strictly needed if we treat unloaded files as non-functional, but per convention a micro bump + HISTORY note is cheap and keeps the audit trail clean.

Found while

Reviewing PR #300 / issue #236 (locale-aware total_amount_in_words).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions