Issue in Elk itself? Attachment conversion problem

[margarett]

So, attachments are also kinda broken 👅
I get a thumbnail (size 0) at my c:\ folder 😆 and no file at attachments folder.

But when looking at the topic that should have the attachment, the following errors pop in the log:
Type of error: Undefined
8: Undefined index: basedirectory_for_attachments
Only show the error messages of this URL http://localhost/elk/index.php?action=dlattach;topic=1.0;attach=1;image
Only show the errors from this file File: C:/xampp/htdocs/elk/sources/Subs.php
Line: 3065

Type of error: General
2: fopen(/1_3e974e417f1fb8d14457d0d53d606decc99feb40.elk): failed to open stream: No such file or directory
http://localhost/elk/index.php?topic=1.0
Only show the errors from this file File: C:/xampp/htdocs/elk/sources/subs/Graphics.subs.php
Line: 243
(notice how there is no attachments folder before the file name? ;-))

It seems that there some variable to define in Elk?

BTW: converting to SMF (not finished with the importer yet to submit it) also fails to create the attachment but doesn't trigger these errors...

[emanuele45]

hmm... 50%-50%
I'd say both of them are bugged: Elk because doesn't set a basedirectory_for_attachments at install, and the Elk OI destination because it doesn't properly set the attachments paths.

[emanuele45]

The main problem with attachments was that it was still kind of mixed and the "real" file name (the one of the file on the file system) was actually explicitly passed from the source to the destination. It was properly passed (by chance) in a couple of situations but not all of them, now it should be.

I'm keeping this open just in case what I fixed was only one part of the problem. 👼

[margarett]

FYI, this error still occurs in Elk 1.0.3 after a conversion from MyBB.
An image attachment has no thumbnail after conversion. Clicking on it brings a white page with an error:
404 - Attachment Not Found

And an empty file (0 bytes) is created in c:, with the name: 1_a15a3ec3ebdc0717f58ff9f69afde8fa48e81068.elk_thumb
Do note, ID 1 in attachments is already taken ;)

edit: and the error in the log is still there...