Description
In openagent_eval/core/executor.py, two methods — execute_parallel (lines 31-71) and execute_sequential (lines 97-134) — are defined but never called anywhere in the codebase. The pipeline uses gather() for parallel execution (line 88) and a list comprehension for sequential execution (line 90), completely bypassing these methods.
Location
openagent_eval/core/executor.py, lines 31-71 and 97-134
Dead Code
execute_parallel (lines 31-71)
async def execute_parallel(
self,
tasks: list[Callable[..., Coroutine[Any, Any, Any]]],
*args: Any,
**kwargs: Any,
) -> list[Any]:
This method takes a list of callables and executes them all with the same *args and **kwargs. The pipeline never uses it — it calls gather() instead.
execute_sequential (lines 97-134)
async def execute_sequential(
self,
tasks: list[Callable[..., Coroutine[Any, Any, Any]]],
*args: Any,
**kwargs: Any,
) -> list[Any]:
This method runs tasks sequentially, stopping on the first failure. The pipeline implements sequential execution directly:
result.results = [await coro for coro in coroutines]
Why This Matters
- Dead code: Unused code adds maintenance burden, confuses readers, and increases the surface area for bugs
- Potential confusion: Developers might try to use
execute_parallel or execute_sequential only to discover they're not used by the pipeline
- Async code that's never tested: These methods may have subtle bugs that go unnoticed
Suggested Fix
Remove both unused methods, or if they're intended for future use, mark them explicitly:
# TODO: Remove if unused after v1.0 release
Severity
Medium — Dead code that adds maintenance burden but doesn't cause runtime issues.
Description
In
openagent_eval/core/executor.py, two methods —execute_parallel(lines 31-71) andexecute_sequential(lines 97-134) — are defined but never called anywhere in the codebase. The pipeline usesgather()for parallel execution (line 88) and a list comprehension for sequential execution (line 90), completely bypassing these methods.Location
openagent_eval/core/executor.py, lines 31-71 and 97-134Dead Code
execute_parallel(lines 31-71)This method takes a list of callables and executes them all with the same
*argsand**kwargs. The pipeline never uses it — it callsgather()instead.execute_sequential(lines 97-134)This method runs tasks sequentially, stopping on the first failure. The pipeline implements sequential execution directly:
Why This Matters
execute_parallelorexecute_sequentialonly to discover they're not used by the pipelineSuggested Fix
Remove both unused methods, or if they're intended for future use, mark them explicitly:
# TODO: Remove if unused after v1.0 releaseSeverity
Medium — Dead code that adds maintenance burden but doesn't cause runtime issues.