Skip to content

Commit 47ecf26

Browse files
OVVO-Financialgithub-actions[bot]
authored andcommitted
Inspect R API update 15d74ef047d5c60cda53dfa8ca6db13c96ad3f6d
1 parent 3c2b753 commit 47ecf26

3 files changed

Lines changed: 79 additions & 19 deletions

File tree

sync/last_live_r_parity_report.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,18 @@
33
- Plan: `sync/last_r_api_plan.json`
44
- R checkout: `upstream/NNS`
55
- Fresh cache requested: `False`
6-
- Skip install: `False`
7-
- Live R recompute: `True`
6+
- Skip install: `True`
7+
- Live R recompute: `False`
88

9-
## Result: live R parity diverged
9+
## Result: manual review required
1010

11-
Mapped parity tests recomputed every R value from the freshly installed live R NNS and the Python implementation did not match. Public Python behavior differs from live R at the recorded commit.
11+
The plan reports unmapped R files. A human must extend `sync/r_api_map.json` before automated parity can run:
1212

13-
Failing command: `/opt/hostedtoolcache/Python/3.11.15/x64/bin/python -m pytest -q -n 0 tests/parity/test_practical_examples.py tests/parity/test_r13_smoke.py`
14-
Exit status: `1`
13+
- `R/Multivariate_Regression.R`
14+
- `R/RcppExports.R`
15+
16+
## Workflow step outcome
17+
18+
- `run_live_r_parity_for_changed_api.py` step outcome: `failure`
19+
- Fresh cache requested: `false`
20+
- DESCRIPTION changed: `false`

sync/last_r_api_inspection.md

Lines changed: 34 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,53 @@
22

33
## Changed files
44

5-
- `R/ARMA.R`
5+
- `R/Multivariate_Regression.R`
6+
- `R/RcppExports.R`
7+
- `R/Regression.R`
8+
- `R/Stack.R`
9+
- `benchmarks/benchmark_stack_native.R`
10+
- `benchmarks/stack_baseline_report.md`
11+
- `benchmarks/stack_baseline_results.csv`
12+
- `benchmarks/stack_native_report.md`
13+
- `benchmarks/stack_native_results.csv`
14+
- `src/NNS_mreg_predict.cpp`
15+
- `src/NNS_mreg_setup.cpp`
16+
- `src/NNS_stack_fast.cpp`
17+
- `src/RcppExports.cpp`
18+
- `tests/testthat/helper-stack-parity.R`
19+
- `tests/testthat/test-mreg-path-native.R`
20+
- `tests/testthat/test-mreg-setup-native.R`
21+
- `tests/testthat/test-stack-method1-native-parity.R`
22+
- `tests/testthat/test-stack-method2-native-parity.R`
23+
- `tests/testthat/test-stack-native-parity.R`
24+
- `tests/testthat/test-univariate-fast-parity.R`
25+
- `tests/testthat/test-xstar-path-native.R`
626

727
## Affected Python modules
828

9-
- `src/nns/arma.py`
29+
- `src/nns/multivariate_regression.py`
30+
- `src/nns/regression.py`
31+
- `src/nns/stack.py`
1032

1133
## Parity tests to run
1234

35+
- `tests/docs/test_vignette_examples.py`
1336
- `tests/parity/test_practical_examples.py`
1437
- `tests/parity/test_r13_smoke.py`
1538

1639
## Cache scope
1740

18-
- `NNS.ARMA`
19-
- `NNS.ARMA.optim`
20-
- `NNS.VAR`
41+
- `NNS.M.reg`
42+
- `NNS.reg`
43+
- `NNS.stack`
2144

2245
## Required actions
2346

2447
- Fresh cache required: `False`
2548
- Export review required: `False`
26-
- Unmapped R files present: `False`
49+
- Unmapped R files present: `True`
50+
51+
## Unmapped R files
52+
53+
- `R/Multivariate_Regression.R`
54+
- `R/RcppExports.R`

sync/last_r_api_plan.json

Lines changed: 33 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,48 @@
11
{
22
"changed_files": [
3-
"R/ARMA.R"
3+
"R/Multivariate_Regression.R",
4+
"R/RcppExports.R",
5+
"R/Regression.R",
6+
"R/Stack.R",
7+
"benchmarks/benchmark_stack_native.R",
8+
"benchmarks/stack_baseline_report.md",
9+
"benchmarks/stack_baseline_results.csv",
10+
"benchmarks/stack_native_report.md",
11+
"benchmarks/stack_native_results.csv",
12+
"src/NNS_mreg_predict.cpp",
13+
"src/NNS_mreg_setup.cpp",
14+
"src/NNS_stack_fast.cpp",
15+
"src/RcppExports.cpp",
16+
"tests/testthat/helper-stack-parity.R",
17+
"tests/testthat/test-mreg-path-native.R",
18+
"tests/testthat/test-mreg-setup-native.R",
19+
"tests/testthat/test-stack-method1-native-parity.R",
20+
"tests/testthat/test-stack-method2-native-parity.R",
21+
"tests/testthat/test-stack-native-parity.R",
22+
"tests/testthat/test-univariate-fast-parity.R",
23+
"tests/testthat/test-xstar-path-native.R"
424
],
525
"affected_python_modules": [
6-
"src/nns/arma.py"
26+
"src/nns/multivariate_regression.py",
27+
"src/nns/regression.py",
28+
"src/nns/stack.py"
729
],
830
"parity_tests": [
31+
"tests/docs/test_vignette_examples.py",
932
"tests/parity/test_practical_examples.py",
1033
"tests/parity/test_r13_smoke.py"
1134
],
1235
"cache_scope": [
13-
"NNS.ARMA",
14-
"NNS.ARMA.optim",
15-
"NNS.VAR"
36+
"NNS.M.reg",
37+
"NNS.reg",
38+
"NNS.stack"
1639
],
1740
"requires_fresh_cache": false,
1841
"requires_export_review": false,
19-
"has_unmapped_r_files": false,
20-
"unmapped_r_files": [],
42+
"has_unmapped_r_files": true,
43+
"unmapped_r_files": [
44+
"R/Multivariate_Regression.R",
45+
"R/RcppExports.R"
46+
],
2147
"warnings": []
2248
}

0 commit comments

Comments
 (0)