`userProfile` should also use `travellerReference` for `id` field

[jorgenosberg]

OMSA/OMSA.yaml

Line 2507 in 6b0cb69

$ref: "#/components/schemas/shortString"

[edwinvandenbelt]

I'd rather specify a 'userProfileReference'. Technically the same, and it is a bit strange to have a 'userProfile' containing a travellerID

[jorgenosberg]

This also breaks code generation, e.g. in the update-traveller endpoint where the field containing the updatedTraveller can't be generated with oneOf because of the type mismatch between the travellerReference, userProfileReference and the assetReference (which is an object)

[jorgenosberg]

After some more verification against multiple generators, this is a more general issue with using a different ID type and then trying to use a discriminator on type to handle a travelParty-hierarchy.

I see 2 smaller "quick-fix" paths to fix this:

• Minimal change: A shared travelPartyReference with and optional name or type, which means the discriminator will still work since each id field uses the same reference object
• Never use refs for things like the TravellerInput -> updatedTraveller field, just rely on the full travelParty objects, e.g. IndividualTraveller or TravellingAsset directly

This could potentially be a part of a bigger change, however, reducing complexity for clients:

• Consolidate travellers in just one array travelParties and define travelParty with a oneOf for the three traveller object types. The three will then share the same travelPartyReference as the type of their id field.