Conflicting RenderDisableManager

[allandiego]

Hey, I think there is an issue with the current render control implementation: if another plugin that does not use ECommons to request render disabling changes the value directly, ECommons will overwrite that value again during Framework_Update.

Would it be possible to change the function so it doesn't update the value every frame? That would prevent conflicts with other plugins that modify the same value, since their changes would no longer be overwritten continuously.

ECommons/ECommons/GameFunctions/RenderDisableManager.cs

Line 113 in 2ac3c72

*RenderDisabled = 0;

[Limiana]

Hello, that would not prevent conflict with other plugins that modify the same value, because if they modify it anyway they will eventually conflict with each other resulting in unpredictable results. If you'd like to have exclusive control over this value, I'd suggest asking users to disable render disabling in plugins that they use, it will not be initialized until first time requested.
This class is also self-contained, you can copy and paste it into your project and use it like that as well

[allandiego]

In my case, there's a button that allows the user to turn the flag on/off but It only change value once. The issue, I think, is that since ecommon is running It in the framework update, it keeps overwriting every frame. Even if two plugins change the value, if they only change it once without overwriting every frame, both can be used simultaneously.

Manager* manager = Manager.Instance();
manager->Is3DRenderingDisabled = true;

User have plugin A using ecommon with render enabled, It request to plugin B disable render (not using ecommon), B disable the render but in next frame ecommon enable it again

[Limiana]

I could change it not to use framework update but then we will have this situation instead:
Plugin A: wants to disable render, writes disable render
Plugin B: wants to disable render, writes disable render
Plugin A: no longer wants to disable render, writes enable render
Plugin B: thinks that render disabled, but it is enabled, therefore similar conflict also takes place

Solving this issue requires value to be monitored one way or another, whether it will be from inside ECommons library or from plugin itself.
Do you have an issue with using shared data approach?

[allandiego]

I got your point, but don't you think this option is better? Not using the framework update allows any plugin to overwrite the value; the user has the possibility to toggle any of the plugins render stuff to return to the desired state without having to disable one or the other

[Limiana]

I got your point, but don't you think this option is better? Not using the framework update allows any plugin to overwrite the value; the user has the possibility to toggle any of the plugins render stuff to return to the desired state without having to disable one or the other

I don't really get the point, for example if user enabled so that render must be disabled when game is minimized or when AR is running in multi mode I don't want any other plugin to have possibility of reenabling it, that's the whole point

Although, what I can do is I can stop reenabling it repeatedly when there are no disable requests, which should make your checkbox work

[allandiego]

That would solve the issue. I'd appreciate it if you could make that change

[Limiana]

Already done! After testing it myself for some time, I'll update all my plugins that use it

[allandiego]

Awesome, thank you!