From 052372d20c376716bdaef51c4f0a7eaa85d75032 Mon Sep 17 00:00:00 2001
From: reginaldalfret <reginaldalfret@gmail.com>
Date: Sun, 25 Oct 2026 19:22:26 +0530
Subject: [PATCH] fix(histogram): ignore negative durations and support
 batching in PercentileTimer

Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
---
 .../api/histogram/PercentileTimer.java        | 17 +++++-
 .../api/histogram/PercentileTimerTest.java    | 56 +++++++++++++++++++
 2 files changed, 71 insertions(+), 2 deletions(-)

diff --git a/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java b/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java
index 4471a78c4..32751e450 100644
--- a/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java
+++ b/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java
@@ -261,9 +261,22 @@ private long restrict(long amount) {
   }
 
   @Override public void record(long amount, TimeUnit unit) {
-    final long nanos = restrict(unit.toNanos(amount));
     timer.record(amount, unit);
-    counterFor(PercentileBuckets.indexOf(nanos)).increment();
+    if (amount >= 0) {
+      final long nanos = restrict(unit.toNanos(amount));
+      counterFor(PercentileBuckets.indexOf(nanos)).increment();
+    }
+  }
+
+  @Override public void record(long[] amounts, int n, TimeUnit unit) {
+    timer.record(amounts, n, unit);
+    final int limit = Math.min(n, amounts.length);
+    for (int i = 0; i < limit; i++) {
+      if (amounts[i] >= 0) {
+        final long nanos = restrict(unit.toNanos(amounts[i]));
+        counterFor(PercentileBuckets.indexOf(nanos)).increment();
+      }
+    }
   }
 
   /**
diff --git a/spectator-api/src/test/java/com/netflix/spectator/api/histogram/PercentileTimerTest.java b/spectator-api/src/test/java/com/netflix/spectator/api/histogram/PercentileTimerTest.java
index 76f9f61f3..cf44ec725 100644
--- a/spectator-api/src/test/java/com/netflix/spectator/api/histogram/PercentileTimerTest.java
+++ b/spectator-api/src/test/java/com/netflix/spectator/api/histogram/PercentileTimerTest.java
@@ -16,6 +16,7 @@
 package com.netflix.spectator.api.histogram;
 
 import com.netflix.spectator.api.Clock;
+import com.netflix.spectator.api.Counter;
 import com.netflix.spectator.api.DefaultRegistry;
 import com.netflix.spectator.api.ExpiringRegistry;
 import com.netflix.spectator.api.ManualClock;
@@ -146,4 +147,59 @@ public void expirationGlobalRegistry() {
     Assertions.assertFalse(t.hasExpired());
     Assertions.assertEquals(1, r.timer("test").count());
   }
+
+  private long bucketCount(Registry r, String name) {
+    return r.counters()
+        .filter(c -> c.id().name().equals(name))
+        .mapToLong(Counter::count)
+        .sum();
+  }
+
+  @Test
+  public void negativeAmountIgnored() {
+    Registry r = newRegistry();
+    PercentileTimer t = PercentileTimer.get(r, r.createId("test"));
+    t.record(-5, TimeUnit.SECONDS);
+    Assertions.assertEquals(0, t.count());
+    Assertions.assertEquals(0, bucketCount(r, "test"));
+  }
+
+  private void checkBatchMatchesSingle(
+      Registry r, PercentileTimer t1, PercentileTimer t2) {
+    Assertions.assertEquals(t1.count(), t2.count());
+    Assertions.assertEquals(t1.count(), bucketCount(r, t1.id().name()));
+    Assertions.assertEquals(t2.count(), bucketCount(r, t2.id().name()));
+    for (int i = 0; i <= 100; ++i) {
+      Assertions.assertEquals(t1.percentile(i), t2.percentile(i), 1e-12);
+    }
+  }
+
+  private void checkBatchRecord(long min, long max) {
+    Registry r = newRegistry();
+    PercentileTimer t1 = PercentileTimer.builder(r)
+        .withName("single")
+        .withRange(min, max, TimeUnit.SECONDS)
+        .build();
+    PercentileTimer t2 = PercentileTimer.builder(r)
+        .withName("batch")
+        .withRange(min, max, TimeUnit.SECONDS)
+        .build();
+
+    long[] amounts = {-5L, 0L, 0L, 0L, 500L, -1L};
+    for (long amount : amounts) {
+      t1.record(amount, TimeUnit.MILLISECONDS);
+    }
+    t2.record(amounts, amounts.length, TimeUnit.MILLISECONDS);
+    checkBatchMatchesSingle(r, t1, t2);
+  }
+
+  @Test
+  public void batchRecordMatchesSingleRecord() {
+    checkBatchRecord(10, 1000);
+  }
+
+  @Test
+  public void batchRecordMatchesSingleRecordDefaultRange() {
+    checkBatchRecord(0, Long.MAX_VALUE);
+  }
 }