From 8e766243d53b0e659e5da90ddc8be1524765a534 Mon Sep 17 00:00:00 2001
From: mliem2k <michael.liem2k@gmail.com>
Date: Mon, 13 Jul 2026 07:11:21 +0800
Subject: [PATCH] Fix compile warnings in mantis-server-agent module

Context: mantis-server-agent module update for removing warnings, refer issue #393.

Addresses:
- anonymous Thread subclass replaced with a method reference (MantisAgent)
- anonymous ListenerCallQueue.Event implementations use diamond operator instead of a redundant explicit type argument (TaskExecutor)
- filled in an empty @return javadoc tag (Hardware)
---
 .../src/main/java/io/mantisrx/server/agent/Hardware.java  | 2 +-
 .../main/java/io/mantisrx/server/agent/MantisAgent.java   | 7 +------
 .../main/java/io/mantisrx/server/agent/TaskExecutor.java  | 8 ++++----
 3 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/Hardware.java b/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/Hardware.java
index fb9ca50aa..932797046 100644
--- a/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/Hardware.java
+++ b/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/Hardware.java
@@ -60,7 +60,7 @@ public static int getNumberCPUCores() {
      * Returns the total size of the disk. Assumes that it's a UNIX style filesystem. Will not work
      * in Windows.
      *
-     * @return
+     * @return total disk size in bytes
      */
     public static long getSizeOfDisk() {
         try {
diff --git a/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/MantisAgent.java b/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/MantisAgent.java
index 83f3ed1ca..83b8f4d79 100644
--- a/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/MantisAgent.java
+++ b/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/MantisAgent.java
@@ -28,12 +28,7 @@ public class MantisAgent implements Service {
     private CountDownLatch blockUntilShutdown = new CountDownLatch(1);
 
     public MantisAgent() {
-        Thread t = new Thread() {
-            @Override
-            public void run() {
-                shutdown();
-            }
-        };
+        Thread t = new Thread(this::shutdown);
         t.setDaemon(true);
         // shutdown hook
         Runtime.getRuntime().addShutdownHook(t);
diff --git a/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/TaskExecutor.java b/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/TaskExecutor.java
index 8f2cc779a..56e4647d5 100644
--- a/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/TaskExecutor.java
+++ b/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/TaskExecutor.java
@@ -643,7 +643,7 @@ public void onTaskCancelled(RuntimeTask task, @Nullable Throwable throwable) {
     }
 
     private static ListenerCallQueue.Event<Listener> getTaskStartingEvent(RuntimeTask task) {
-        return new ListenerCallQueue.Event<Listener>() {
+        return new ListenerCallQueue.Event<>() {
             @Override
             public void call(Listener listener) {
                 listener.onTaskStarting(task);
@@ -657,7 +657,7 @@ public String toString() {
     }
 
     private static ListenerCallQueue.Event<Listener> getTaskCancellingEvent(RuntimeTask task) {
-        return new ListenerCallQueue.Event<Listener>() {
+        return new ListenerCallQueue.Event<>() {
             @Override
             public void call(Listener listener) {
                 listener.onTaskCancelling(task);
@@ -671,7 +671,7 @@ public String toString() {
     }
 
     private static ListenerCallQueue.Event<Listener> getTaskFailedEvent(RuntimeTask task, Throwable throwable) {
-        return new ListenerCallQueue.Event<Listener>() {
+        return new ListenerCallQueue.Event<>() {
             @Override
             public void call(Listener listener) {
                 listener.onTaskFailed(task, throwable);
@@ -685,7 +685,7 @@ public String toString() {
     }
 
     private static ListenerCallQueue.Event<Listener> getTaskCancelledEvent(RuntimeTask task, @Nullable Throwable throwable) {
-        return new ListenerCallQueue.Event<Listener>() {
+        return new ListenerCallQueue.Event<>() {
             @Override
             public void call(Listener listener) {
                 listener.onTaskCancelled(task, throwable);