getLineProps arguments check

[kasia129]

Description

On dev branch, in getLineProps function of helpers.py lines 622-665, there is a check for having both the source and lineProps arguments not None, but it is only done after assigning the inputs from the yaml file to the lineProps variable, so the if not lineProps==None statement can never be False.

Current behavior

Warning: both lineProps and source arguments were passed to getLineProps. lineProps will be ignored is always printed out if source is not None, regardless of the lineProps argument.

[mattEhall]

I think this issue has been fixed in the current state of the dev branch: https://github.com/NREL/MoorPy/blob/6ffdc85854f7077c3174175fe5c809cfb3028b59/moorpy/helpers.py#L658

Does updating with the latest commits solve the issue?

[kasia129]

This version still shows the same code, I think. The issue I had in mind was about the if not lineProps==None and not source==None rather than if lineProps==None and source==None. I might be missing something here, but I thought these lines:

if not source==None:
        lineProps = loadLineProps(source)
        if not lineProps==None:
            print('Warning: both lineProps and source arguments were passed to getLineProps. lineProps will be ignored.')

do:

• check if source is a non-nan argument
• load mooring properties from source, and assign this dict to lineProps variable
• check if lineProps variable is not none (i.e., suposedly lineProps argument has also been provided to the function). Because we just set lineProps in the previous step, this statement will never be False?
• the warning will always be printed out as long as source was provided as an argument.

It could be that loading the moor props from source returns None, but since in loadLineProps() output is initialised as an empty dict, I would think that cannot be the case?

[vamseeachanta]

@kasia129 , do you have an input file that I can run to see the current behavior? Following this we can simulate the expected behavior and move forward.

[shousner]

Hi @kasia129, I'm going through some of these GitHub Issues now. Does the current code sufficiently address the issue (https://github.com/NatLabRockies/MoorPy/blob/main/moorpy/helpers.py#L665)?

The logic is that if both source and lineProps inputs are provided, then it will default to only using the source input and ignoring the lineProps input. If only a source input is provided, then it runs loadLineProps to set the new lineProps variable. If only a lineProps input is provided, then it skips this if statement entirely.