Fix performance and infinite recursion problem (max call stack) due to unconstrained spread of arrays#12
Merged
Merged
Conversation
…pread generally, spreading arrays should be avoided, because you never know if the iterator will run forever
NullVoxPopuli
changed the title
NullVoxPopuli
changed the title
NaamuKim
approved these changes
May 10, 2026
Owner
NaamuKim
left a comment
NaamuKim
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for your contribution and I like it. I will publish patch version after merging this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generally, spreading arrays should be avoided, because you never know if the iterator will run forever