Skip to content

[BUG] C ABI check is failing on PRs with no C ABI changes #2387

Description

@jrbourbeau

Originally saw over in #2369 that the C ABI check was failing, even though that PR only ever touches cuvs-bench Python code. The error message was a bit off there, so I opened #2386 to update the actual ABI check code error handling and saw that the C ABI check was still failing with

using dlpack from /home/runner/work/cuvs/cuvs/dlpack/include
Error: Function has been removed. Symbol cuvsDatasetCreate from cuvs/core/dataset.h:57
Error: Function has been removed. Symbol cuvsDatasetMakePadded from cuvs/core/dataset.h:70
Error: Function has been removed. Symbol cuvsDatasetMakePaddedView from cuvs/core/dataset.h:80
Error: Function has been removed. Symbol cuvsDatasetMakeStandardView from cuvs/core/dataset.h:89
Error: Function has been removed. Symbol cuvsDatasetDestroy from cuvs/core/dataset.h:94
Error: Function has been removed. Symbol cuvsDatasetGetMemType from cuvs/core/dataset.h:97
Error: Function has been removed. Symbol cuvsDatasetGetLayout from cuvs/core/dataset.h:101
Error: Function has been removed. Symbol cuvsDatasetGetIsOwning from cuvs/core/dataset.h:104
Error: Function has been removed. Symbol cuvsDatasetGetDtype from cuvs/core/dataset.h:107
Error: Function has been removed. Symbol cuvsCagraUpdateDataset from cuvs/neighbors/cagra.h:596
Error: Function has changed parameter type 'cuvsDataset_t' to 'DLManagedTensor *' for 'dataset'. Symbol cuvsCagraBuild from cuvs/neighbors/cagra.h:638
Error: Function has changed parameter type 'cuvsDataset_t' to 'DLManagedTensor *' for 'extended_dataset'. Symbol cuvsCagraExtend from cuvs/neighbors/cagra.h:667
Error: Function has changed parameter type 'int64_t' to 'cuvsCagraIndex_t' for 'new_start_row'. Symbol cuvsCagraExtend from cuvs/neighbors/cagra.h:667
Error: Function has a deleted parameter 'cuvsCagraIndex_t index'. Symbol cuvsCagraExtend from cuvs/neighbors/cagra.h:695
Error: Function has been removed. Symbol cuvsCagraSerializeGraph from cuvs/neighbors/cagra.h:827
Error: Function has been removed. Symbol cuvsCagraSerializeGraphAndDataset from cuvs/neighbors/cagra.h:844
Error: Function has been removed. Symbol cuvsCagraDeserializeGraph from cuvs/neighbors/cagra.h:888
Error: Function has been removed. Symbol cuvsCagraDeserializeGraphAndDataset from cuvs/neighbors/cagra.h:911
Error: Function has changed parameter type 'cuvsDataset_t' to 'cuvsCagraIndex_t' for 'merged_dataset'. Symbol cuvsCagraMerge from cuvs/neighbors/cagra.h:957
Error: Function has a deleted parameter 'cuvsCagraIndex_t output_index'. Symbol cuvsCagraMerge from cuvs/neighbors/cagra.h:1029
Error: Struct has been removed. Symbol cuvsDataset from cuvs/core/dataset.h:41
Error: Struct member has changed type 'void *' to 'cuvsCagraCompressionParams_t' for member 'graph_build_params'. Symbol cuvsCagraIndexParams from cuvs/neighbors/cagra.h:203
Error: Enum value CUVS_DATASET_LAYOUT_STANDARD has been removed. Symbol cuvsDatasetLayout_t from cuvs/core/dataset.h:21
Error: Enum value CUVS_DATASET_LAYOUT_PADDED has been removed. Symbol cuvsDatasetLayout_t from cuvs/core/dataset.h:21
Error: Enum value CUVS_DATASET_MEM_TYPE_HOST has been removed. Symbol cuvsDatasetMemType_t from cuvs/core/dataset.h:29
Error: Enum value CUVS_DATASET_MEM_TYPE_DEVICE has been removed. Symbol cuvsDatasetMemType_t from cuvs/core/dataset.h:29

which seems totally unrelated to the changes in that PR.

Maybe the CI job is comparing against the wrong original ABI?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions