From 2e28c4a34b0f0ad50bd1edc8cde39811f1c75e6a Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 1 Jul 2026 09:17:08 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Palette:=20Add=20missing=20acces?= =?UTF-8?q?sibility=20labels=20to=20icon=20buttons?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 💡 What: Added `.accessibilityLabel` to icon-only buttons in `SettingsViews.swift` (Layer Stick Override reset button) and `OnScreenKeyboardSettingsView.swift` (Variables function icon). 🎯 Why: These buttons previously had `.help` modifiers for hover tooltips but lacked equivalent VoiceOver accessibility labels, making them inaccessible to screen readers. 📸 Before/After: Visuals remain unchanged, but screen reader accessibility is fixed. ♿ Accessibility: Ensures VoiceOver properly announces "Reset to base (inherit)" and "Contains variables that will be expanded" for the respective icons. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com> --- .../Views/MainWindow/OnScreenKeyboardSettingsView.swift | 1 + .../XboxControllerMapper/Views/MainWindow/SettingsViews.swift | 1 + 2 files changed, 2 insertions(+) diff --git a/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/OnScreenKeyboardSettingsView.swift b/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/OnScreenKeyboardSettingsView.swift index 8fe6829f..b9873f2d 100644 --- a/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/OnScreenKeyboardSettingsView.swift +++ b/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/OnScreenKeyboardSettingsView.swift @@ -104,6 +104,7 @@ struct QuickTextRowView: View { .font(.caption2) .foregroundColor(.blue) .help("Contains variables that will be expanded") + .accessibilityLabel("Contains variables that will be expanded") } Spacer() diff --git a/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SettingsViews.swift b/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SettingsViews.swift index ffe3986e..73749e5b 100644 --- a/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SettingsViews.swift +++ b/XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SettingsViews.swift @@ -438,6 +438,7 @@ struct JoystickSettingsView: View { } .buttonStyle(.borderless) .help("Reset to base (inherit)") + .accessibilityLabel("Reset to base (inherit)") } }