Skip to content

Variable name is wrong; in the result baseflow is not generated #83

@RY4GIT

Description

@RY4GIT

This issue is identified in PR #60 and #63

Current behavior

Variable names were inconsistent. Fluxes from both soil & groundwater storages were named as primary_flux and secondary_flux in the main execusion vs. primary_flux**_m** and secoundary_flux**_m** in conceptual_reservoir_flux_calc.

As a result, the baseflow was entirely missing in CFE. Fluxes calculated in conceptual_reservoir_flux_calc were not passed the main flux calculation.

Change needed

  • Change variable name 'primary_flux' to 'primary_flux_m'
  • Change variable name 'secondary_flux' to 'secondary_flux_m'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions