From 6805b314256337d94aae5f7d75f91928700c32df Mon Sep 17 00:00:00 2001 From: aidenvaines-cgi Date: Wed, 1 Apr 2026 12:13:34 +0100 Subject: [PATCH 1/4] CCM-15307 Fixing Pa11y findings --- docs/.pa11y-ci.js | 1 + docs/pages/using-nhs-notify/upload-a-letter.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/.pa11y-ci.js b/docs/.pa11y-ci.js index 31c08e98..7b14d404 100644 --- a/docs/.pa11y-ci.js +++ b/docs/.pa11y-ci.js @@ -33,6 +33,7 @@ module.exports = { standard: 'WCAG2AA', userAgent: 'pa11y-ci', concurrency: 8, + hideElements: 'a[href$=".pdf"]', }, urls: getUrlsFromSiteMap() };; diff --git a/docs/pages/using-nhs-notify/upload-a-letter.md b/docs/pages/using-nhs-notify/upload-a-letter.md index 9090e6d8..f40088a8 100644 --- a/docs/pages/using-nhs-notify/upload-a-letter.md +++ b/docs/pages/using-nhs-notify/upload-a-letter.md @@ -191,7 +191,7 @@ The address is a personalisation field and is set automatically. The recipient's name is always included as the first line of the address. -If your letter is about a child, use the [parent or guardian letter template](#download-our-blank-letter-template). This template includes 'Parent or guardian of' in the first line of the address. +If your letter is about a child, use the [parent or guardian letter template](#download-a-blank-word-letter-template). This template includes 'Parent or guardian of' in the first line of the address. ### NHS logo From 56dea07510b681a9e571854f23a88a69dc3ab363 Mon Sep 17 00:00:00 2001 From: aidenvaines-cgi Date: Wed, 1 Apr 2026 13:05:47 +0100 Subject: [PATCH 2/4] CCM-15307 Drop PDF links before Pa11y runs --- docs/.pa11y-before.js | 4 ++++ docs/.pa11y-ci.js | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 docs/.pa11y-before.js diff --git a/docs/.pa11y-before.js b/docs/.pa11y-before.js new file mode 100644 index 00000000..b04dfee5 --- /dev/null +++ b/docs/.pa11y-before.js @@ -0,0 +1,4 @@ +// Remove PDF links before accessibility testing +document.querySelectorAll('a[href$=".pdf"]').forEach(function(link) { + link.remove(); +}); diff --git a/docs/.pa11y-ci.js b/docs/.pa11y-ci.js index 7b14d404..86b5be57 100644 --- a/docs/.pa11y-ci.js +++ b/docs/.pa11y-ci.js @@ -33,7 +33,7 @@ module.exports = { standard: 'WCAG2AA', userAgent: 'pa11y-ci', concurrency: 8, - hideElements: 'a[href$=".pdf"]', + beforeScript: './.pa11y-before.js' }, urls: getUrlsFromSiteMap() };; From 95f98932fa96f3434e79214cc297fb3c3fc72f61 Mon Sep 17 00:00:00 2001 From: aidenvaines-cgi Date: Wed, 1 Apr 2026 13:26:06 +0100 Subject: [PATCH 3/4] CCM-15307 Drop PDF links before Pa11y runs --- docs/.pa11y-before.js | 4 ---- docs/.pa11y-ci.js | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) delete mode 100644 docs/.pa11y-before.js diff --git a/docs/.pa11y-before.js b/docs/.pa11y-before.js deleted file mode 100644 index b04dfee5..00000000 --- a/docs/.pa11y-before.js +++ /dev/null @@ -1,4 +0,0 @@ -// Remove PDF links before accessibility testing -document.querySelectorAll('a[href$=".pdf"]').forEach(function(link) { - link.remove(); -}); diff --git a/docs/.pa11y-ci.js b/docs/.pa11y-ci.js index 86b5be57..97e5a650 100644 --- a/docs/.pa11y-ci.js +++ b/docs/.pa11y-ci.js @@ -33,7 +33,7 @@ module.exports = { standard: 'WCAG2AA', userAgent: 'pa11y-ci', concurrency: 8, - beforeScript: './.pa11y-before.js' + hideElements: 'a[href*=".pdf"]', }, urls: getUrlsFromSiteMap() };; From 56da560549a5f1243dcfb6bcd96b627002049531 Mon Sep 17 00:00:00 2001 From: aidenvaines-cgi Date: Wed, 1 Apr 2026 13:27:50 +0100 Subject: [PATCH 4/4] CCM-15307 Drop PDF links before Pa11y runs --- docs/.pa11y-ci.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/.pa11y-ci.js b/docs/.pa11y-ci.js index 97e5a650..24fd6547 100644 --- a/docs/.pa11y-ci.js +++ b/docs/.pa11y-ci.js @@ -8,7 +8,10 @@ function getUrlsFromSiteMap() { const sitemap = new XMLParser().parse(file); - return sitemap.urlset.url.map(r => r.loc); + // Filter out PDF files from accessibility testing + return sitemap.urlset.url + .map(r => r.loc) + .filter(url => !url.endsWith('.pdf')); } module.exports = { @@ -33,7 +36,6 @@ module.exports = { standard: 'WCAG2AA', userAgent: 'pa11y-ci', concurrency: 8, - hideElements: 'a[href*=".pdf"]', }, urls: getUrlsFromSiteMap() };;