Skip to content

Potential improvements to merge workflow + UI #222

@lklyne

Description

@lklyne

A couple of ideas / discussion items for the merge workflow

  • Should probably include ability to create branch from the branch list
  • Should include ability to show branch status in the branch list
  • would be nice to see a hierarchy of the branch list from any branch, not just main branch
    • ideally would have some representation of merge status here
    • would be very nice to see a preview of # changes here
  • maybe should include ability to review merge request from the child / merge requestor (not sure if this is a test-ism, but it felt weird to have to navigate away to review the request)
  • should mirror color convention of green / yellow on non-conflicted activities. show green what will be changed and yellow what will be modified.

image

  • Language in button and top right should be exactly the same
    image

Aaron's leftover PR improvements:

  • Show a confirmation dialog when clicking on "review" in the Merge Requests modal or indicate somehow that clicking "review" will lock the plan
  • Consider implementing full width change highlighting
  • Plan page should do something when a user is on the page and someone else locks the plan feat: prevent users from editing locked plan #228
  • The "X branches" indicator/button in the nav could probably use more styling. Maybe drop the opacity and up it on hover?

Metadata

Metadata

Assignees

No one assigned

    Labels

    designIssues related to design tasks

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions