Skip to content

Update to 1.15 in fxdata-build breaks strings #9

@randomouscrap98

Description

@randomouscrap98

If you look at the changes included in a5076ae#diff-0557ece742af41a042a5fd073627b0553b7f2f95dff69ca769fb6e25f6e19e05L217, you'll see that you changed strings from using double quotes exclusively to using single quotes exclusively. I'm not sure what the reason for the change was, but this breaks your "helloWorld" example, since it has a string with double quotes. The system does not read the string as a whole part, but instead reads just the "Hello portion as one string, which then leaves World! to be interpreted as a label (which it of course isn't). Furthermore, the regex as is wouldn't allow for, say, a double quoted string to have double quotes escaped within it, as it would be broken up into multiple string parts.

Edit: actually at this point, I'm not quite sure what that line is supposed to do... I'm going to mess around and see. But point is, I can't get the fxdata-build.py script to work on the ArduboyFX "helloWorld" example

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions