I should really start running tests *before* I commit

Author: Villagers654

frontend/src/modules/discovery/components/BrowseFilters.tsx

@@ -461,7 +461,7 @@ export const BrowseFilters: React.FC<BrowseFiltersProps> = React.memo(({
                             placeholder="12"
                             containerClassName="relative flex-none h-10 w-16"
                             buttonLabel={itemsPerPage}
-                            buttonAriaLabel={`${itemsPerPage} results per page`}
+                            buttonAriaLabel="Results per page"
                             buttonTitle="Results per page"
                             showSelectedCheck={false}
                             buttonClassName="w-full h-full flex items-center justify-center gap-1 border rounded-xl px-2 text-xs font-black transition-all whitespace-nowrap bg-white dark:bg-slate-900 border-slate-200 dark:border-white/10 text-slate-700 dark:text-slate-300 hover:bg-slate-50 dark:hover:bg-white/[0.02] shadow-sm"

frontend/src/modules/discovery/views/Browse.tsx

@@ -62,7 +62,7 @@ export const Browse: React.FC<BrowseViewProps> = ({
     const { initialData } = useSSRData();
 
     const hasComplexParams = searchParams.has('q') || searchParams.has('tags') || searchParams.has('version') || searchParams.has('minDl') || searchParams.has('minFav') || searchParams.has('date') || searchParams.has('category') || (searchParams.get('page') && parseInt(searchParams.get('page')!, 10) > 0);
-    const hasUsableBrowseSSRData = Boolean(initialData?.browseData);
+    const hasUsableBrowseSSRData = Boolean(initialData?.browseData && initialData?.browseDataReady !== false);
     const useSSR = hasUsableBrowseSSRData && !hasComplexParams;
     const initialPreferences = useMemo(() => getInitialBrowsePreferences(), []);
     const [viewStyle, setViewStyle] = useState<BrowseViewStyle>(initialPreferences.viewStyle);

frontend/src/modules/home/views/Home.tsx

@@ -178,13 +178,10 @@ export const Home: React.FC<{
     const initialTrendingProjects = ssrData?.homeTrendingProjects || ssrData?.homeProjects || [];
     const initialNewestProjects = ssrData?.homeNewestProjects || [];
     const hasHomeSSRData = Boolean(
-        ssrData
-        && (
-            'homeMarqueeProjects' in ssrData
-            || 'homeTrendingProjects' in ssrData
-            || 'homeNewestProjects' in ssrData
-            || 'homeProjects' in ssrData
-        )
+        ssrData?.homeDataReady
+        || initialMarqueeProjects.length
+        || initialTrendingProjects.length
+        || initialNewestProjects.length
     );
     const initialProjectSeed = useMemo(
         () => dedupeProjects([...initialTrendingProjects, ...initialNewestProjects]),
@@ -233,7 +230,7 @@ export const Home: React.FC<{
 
         const shouldFetchFallbackNewest = !hasHomeSSRData && !initialNewestProjects.length && initialProjectSeed.length === 0;
         const shouldRefreshNewestProjects = !initialNewestProjects.length && initialProjectSeed.length > 0;
-        const shouldFetchFallbackStats = !ssrData?.stats;
+        const shouldFetchFallbackStats = !hasHomeSSRData || !ssrData?.stats;
         let isCancelled = false;
         const scheduledTasks: Array<() => void> = [];
 

frontend/src/pages/[...all].astro

@@ -162,6 +162,7 @@ if (classification) {
             const newestProjects = newest?.content || [];
 
             initialData = {
+                homeDataReady: true,
                 homeProjects: unique || [],
                 homeMarqueeProjects: marqueeProjects,
                 homeTrendingProjects: unique || [],
@@ -176,7 +177,7 @@ if (classification) {
 
             ssrSuccessfullyCompleted = true;
         } catch {
-            initialData = { homeProjects: [], stats: { totalProjects: 0, totalDownloads: 0, totalUsers: 0 } };
+            initialData = { homeDataReady: false, homeProjects: [], stats: { totalProjects: 0, totalDownloads: 0, totalUsers: 0 } };
         }
     } else if (isStaticBrowseRequest) {
         try {