Packet loss

[BobbyTheCatfish]

In the server part of the addon, packets have the potential to be overwritten. Since it uses the SendSingleData method, if two people change colors at the same time, only one packet will be sent. Using SendCollectionData should prevent this. I haven't looked at the client, but I doubt this would be required there. If you have any questions let me know.

Edit:
This actually does happen. When a third (or more) player joins, the packet data gets overwritten, so that player only receives one color.

[BobbyTheCatfish]

I see you committed a patch for this. There's still a problem in the implementation, and you'll likely find it if you try using the mod at all. You need to change the instantiation method on the client to receive a collection packet.

// Packets.cs
public static IPacketData Instantiate(PacketId id)
{
    return id switch
    {
        PacketId.CloakColorUpdate => new PacketDataCollection<CloakColorPacket>(),
        _ => new PacketDataCollection<CloakColorPacket>(),
    };
}

[Michael4d45]

Hmm, it was working fine when I was testing it. I'll take a look. I tested with 3 players

[Michael4d45]

Is this what you're looking for?

    internal static class ClientAddonReceivePacketFactory
    {
        public static IPacketData Instantiate(PacketId id) =>
            id switch
            {
                PacketId.CloakColorUpdate => new PacketDataCollection<CloakColorPacket>(),
                PacketId.UsernameColorUpdate => new PacketDataCollection<UsernameColorPacket>(),
                PacketId.ServerUsernameColorRules => new ServerUsernameColorRulesPacket(),
                _ => new PacketDataCollection<CloakColorPacket>(),
            };
    }