From 3cea07177b42dd171b94ee39d62f7906ff227fef Mon Sep 17 00:00:00 2001 From: Jody Date: Sun, 14 Jun 2026 13:34:18 -0600 Subject: [PATCH 01/12] Add Firebase database rules --- README.md | 2 +- firebase-rules.json | 48 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 firebase-rules.json diff --git a/README.md b/README.md index c564100..893237f 100644 --- a/README.md +++ b/README.md @@ -156,7 +156,7 @@ VITE_TEACHER_PASSWORD=your_password_here ### Step 7 — Set Firebase security rules 1. Firebase Console → **Realtime Database → Rules** tab -2. Replace everything with the contents of `firebase-rules.json` +2. Replace everything with the contents of [`firebase-rules.json`](firebase-rules.json) 3. Click **Publish** ### Step 8 — Test locally diff --git a/firebase-rules.json b/firebase-rules.json new file mode 100644 index 0000000..7c5c20f --- /dev/null +++ b/firebase-rules.json @@ -0,0 +1,48 @@ +{ + "rules": { + ".read": false, + ".write": false, + "session": { + ".read": "auth != null", + "students": { + "$student": { + ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('date').isString()))", + ".validate": "!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('joinedAt').isNumber() && newData.child('date').isString() && newData.childrenCount() <= 3)" + } + }, + "activePoll": { + ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && newData.child('correctPolicy').isString() && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))", + "responses": { + "$student": { + ".validate": "newData.isNumber() && newData.val() >= 0 && newData.val() <= 5" + } + } + }, + "queue": { + ".write": "auth != null", + ".validate": "!newData.exists() || (newData.hasChildren(['setId', 'setName', 'currentIndex', 'totalPolls', 'sessionKey']) && newData.child('setId').isString() && newData.child('setName').isString() && newData.child('currentIndex').isNumber() && newData.child('totalPolls').isNumber() && newData.child('sessionKey').isString())" + } + }, + "sessionStudents": { + ".read": "auth != null", + "$entry": { + ".write": "auth != null", + ".validate": "!newData.exists() || (newData.hasChildren(['name', 'date', 'joinedAt']) && newData.child('name').isString() && newData.child('date').isString() && newData.child('joinedAt').isNumber() && newData.childrenCount() <= 3)" + } + }, + "pollHistory": { + ".read": "auth != null", + "$poll": { + ".write": "auth != null", + ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'endedAt']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('startedAt').isNumber())" + } + }, + "pollSets": { + ".read": "auth != null", + "$set": { + ".write": "auth != null", + ".validate": "!newData.exists() || (newData.hasChildren(['id', 'name', 'createdAt', 'defaults']) && newData.child('id').isString() && newData.child('name').isString() && newData.child('createdAt').isNumber())" + } + } + } +} From f31e857f1665468256655e64738a188ac66cb954 Mon Sep 17 00:00:00 2001 From: Jody Date: Sun, 14 Jun 2026 13:49:45 -0600 Subject: [PATCH 02/12] Fix Firebase rules validation syntax --- firebase-rules.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firebase-rules.json b/firebase-rules.json index 7c5c20f..7f7c3d1 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -7,7 +7,7 @@ "students": { "$student": { ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('date').isString()))", - ".validate": "!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('joinedAt').isNumber() && newData.child('date').isString() && newData.childrenCount() <= 3)" + ".validate": "!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('joinedAt').isNumber() && newData.child('date').isString())" } }, "activePoll": { @@ -27,7 +27,7 @@ ".read": "auth != null", "$entry": { ".write": "auth != null", - ".validate": "!newData.exists() || (newData.hasChildren(['name', 'date', 'joinedAt']) && newData.child('name').isString() && newData.child('date').isString() && newData.child('joinedAt').isNumber() && newData.childrenCount() <= 3)" + ".validate": "!newData.exists() || (newData.hasChildren(['name', 'date', 'joinedAt']) && newData.child('name').isString() && newData.child('date').isString() && newData.child('joinedAt').isNumber())" } }, "pollHistory": { From 33990b532dc09acb547af88ebfa4a003a661751c Mon Sep 17 00:00:00 2001 From: Jody Date: Sun, 14 Jun 2026 13:59:36 -0600 Subject: [PATCH 03/12] Add Firebase rules validation --- .github/workflows/ci.yml | 39 +++++++++++++++++++++++++++++++++++++++ .gitignore | 1 + firebase.json | 5 +++++ package.json | 2 ++ 4 files changed, 47 insertions(+) create mode 100644 .github/workflows/ci.yml create mode 100644 firebase.json diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..6b13cb6 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,39 @@ +name: CI + +on: + pull_request: + push: + branches: + - main + +jobs: + build-and-validate: + runs-on: ubuntu-latest + + steps: + - name: Check out repository + uses: actions/checkout@v4 + + - name: Set up Node + uses: actions/setup-node@v4 + with: + node-version: 22 + cache: npm + + - name: Set up Java + uses: actions/setup-java@v4 + with: + distribution: temurin + java-version: 21 + + - name: Install dependencies + run: npm ci + + - name: Validate Firebase rules JSON + run: npm run validate:rules:json + + - name: Validate Firebase rules syntax + run: npm run validate:rules + + - name: Build app + run: npm run build diff --git a/.gitignore b/.gitignore index 3b68ffa..daba8bc 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,4 @@ dist/ **/#*# .env.local .env.*.local +database-debug.log diff --git a/firebase.json b/firebase.json new file mode 100644 index 0000000..18282ea --- /dev/null +++ b/firebase.json @@ -0,0 +1,5 @@ +{ + "database": { + "rules": "firebase-rules.json" + } +} diff --git a/package.json b/package.json index f02177d..67de9f9 100644 --- a/package.json +++ b/package.json @@ -5,6 +5,8 @@ "scripts": { "dev": "vite", "build": "vite build", + "validate:rules:json": "node -e \"JSON.parse(require('fs').readFileSync('firebase-rules.json','utf8'))\"", + "validate:rules": "npx firebase-tools@15.19.0 emulators:exec --only database --project demo-classroom-polling \"node -e \\\"console.log('database rules loaded')\\\"\"", "preview": "vite preview", "deploy": "npm run build && npx gh-pages -d dist" }, From b0f46f63057f2e33979f0e757fde3d70c8287262 Mon Sep 17 00:00:00 2001 From: Jody Date: Sun, 14 Jun 2026 14:10:21 -0600 Subject: [PATCH 04/12] Allow server timestamps in join rules --- firebase-rules.json | 4 +-- package.json | 2 +- scripts/validateFirebaseRules.mjs | 52 +++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 3 deletions(-) create mode 100644 scripts/validateFirebaseRules.mjs diff --git a/firebase-rules.json b/firebase-rules.json index 7f7c3d1..9172d2f 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -7,7 +7,7 @@ "students": { "$student": { ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('date').isString()))", - ".validate": "!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('joinedAt').isNumber() && newData.child('date').isString())" + ".validate": "!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && (newData.child('joinedAt').isNumber() || newData.child('joinedAt/.sv').val() == 'timestamp') && newData.child('date').isString())" } }, "activePoll": { @@ -27,7 +27,7 @@ ".read": "auth != null", "$entry": { ".write": "auth != null", - ".validate": "!newData.exists() || (newData.hasChildren(['name', 'date', 'joinedAt']) && newData.child('name').isString() && newData.child('date').isString() && newData.child('joinedAt').isNumber())" + ".validate": "!newData.exists() || (newData.hasChildren(['name', 'date', 'joinedAt']) && newData.child('name').isString() && newData.child('date').isString() && (newData.child('joinedAt').isNumber() || newData.child('joinedAt/.sv').val() == 'timestamp'))" } }, "pollHistory": { diff --git a/package.json b/package.json index 67de9f9..1c4b756 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "dev": "vite", "build": "vite build", "validate:rules:json": "node -e \"JSON.parse(require('fs').readFileSync('firebase-rules.json','utf8'))\"", - "validate:rules": "npx firebase-tools@15.19.0 emulators:exec --only database --project demo-classroom-polling \"node -e \\\"console.log('database rules loaded')\\\"\"", + "validate:rules": "npx firebase-tools@15.19.0 emulators:exec --only database --project demo-classroom-polling \"node scripts/validateFirebaseRules.mjs\"", "preview": "vite preview", "deploy": "npm run build && npx gh-pages -d dist" }, diff --git a/scripts/validateFirebaseRules.mjs b/scripts/validateFirebaseRules.mjs new file mode 100644 index 0000000..10a6e1c --- /dev/null +++ b/scripts/validateFirebaseRules.mjs @@ -0,0 +1,52 @@ +import http from 'node:http'; + +const host = process.env.FIREBASE_DATABASE_EMULATOR_HOST || '127.0.0.1:9000'; +const baseUrl = `http://${host}`; +const authOverride = encodeURIComponent(JSON.stringify({ + uid: 'rules-smoke-test-user', + token: {}, +})); + +async function put(path, body) { + const url = new URL(`${baseUrl}${path}.json`); + url.searchParams.set('auth_variable_override', authOverride); + + const payload = JSON.stringify(body); + + const response = await new Promise((resolve, reject) => { + const request = http.request(url, { + method: 'PUT', + headers: { + 'Content-Type': 'application/json', + 'Content-Length': Buffer.byteLength(payload), + }, + }, resolve); + + request.on('error', reject); + request.end(payload); + }); + + const text = await new Promise((resolve, reject) => { + let data = ''; + response.setEncoding('utf8'); + response.on('data', chunk => { data += chunk; }); + response.on('end', () => resolve(data)); + response.on('error', reject); + }); + + if (response.statusCode < 200 || response.statusCode >= 300) { + throw new Error(`${path} returned ${response.statusCode}: ${text}`); + } +} + +const joinedAt = { '.sv': 'timestamp' }; +const date = '2026-06-14'; + +await put('/session/students/Alice', { joinedAt, date }); +await put('/sessionStudents/2026-06-14_Alice', { + name: 'Alice', + date, + joinedAt, +}); + +console.log('Firebase rules smoke tests passed'); From e3cef79904da49ce3469b0da8ce20e3207a79449 Mon Sep 17 00:00:00 2001 From: Jody Paul Date: Sun, 14 Jun 2026 14:23:04 -0600 Subject: [PATCH 05/12] Valid identification and fix for bug in processing JSON Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- scripts/validateFirebaseRules.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/validateFirebaseRules.mjs b/scripts/validateFirebaseRules.mjs index 10a6e1c..1109c98 100644 --- a/scripts/validateFirebaseRules.mjs +++ b/scripts/validateFirebaseRules.mjs @@ -2,10 +2,10 @@ import http from 'node:http'; const host = process.env.FIREBASE_DATABASE_EMULATOR_HOST || '127.0.0.1:9000'; const baseUrl = `http://${host}`; -const authOverride = encodeURIComponent(JSON.stringify({ +const authOverride = JSON.stringify({ uid: 'rules-smoke-test-user', token: {}, -})); +}); async function put(path, body) { const url = new URL(`${baseUrl}${path}.json`); From 86a4221e19a5dad6cca1152ea113e94b1f56c13e Mon Sep 17 00:00:00 2001 From: Jody Paul Date: Sun, 14 Jun 2026 14:24:05 -0600 Subject: [PATCH 06/12] Remove hard-coded maximum number of choices Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- firebase-rules.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firebase-rules.json b/firebase-rules.json index 9172d2f..5792761 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -14,7 +14,7 @@ ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && newData.child('correctPolicy').isString() && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))", "responses": { "$student": { - ".validate": "newData.isNumber() && newData.val() >= 0 && newData.val() <= 5" + ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && newData.val() < root.child('session/activePoll/options').childrenCount()" } } }, From 6d21a7aaa8070f5db53bc6cc14909116ea690611 Mon Sep 17 00:00:00 2001 From: Jody Paul Date: Sun, 14 Jun 2026 14:26:20 -0600 Subject: [PATCH 07/12] Add validation of necessary values Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- firebase-rules.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firebase-rules.json b/firebase-rules.json index 5792761..5d61fde 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -34,7 +34,7 @@ ".read": "auth != null", "$poll": { ".write": "auth != null", - ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'endedAt']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('startedAt').isNumber())" + ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'endedAt']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && newData.child('endedAt').isNumber())" } }, "pollSets": { From 2dd70b48596fc0be7c05cddb32d22ebbd0050a05 Mon Sep 17 00:00:00 2001 From: Jody Date: Sun, 14 Jun 2026 14:51:17 -0600 Subject: [PATCH 08/12] Allow for arbitrary number of options. Expand validation. --- firebase-rules.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firebase-rules.json b/firebase-rules.json index 5d61fde..3f1d083 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -14,7 +14,7 @@ ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && newData.child('correctPolicy').isString() && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))", "responses": { "$student": { - ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && newData.val() < root.child('session/activePoll/options').childrenCount()" + ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && newData.val() < root.child('session/activePoll/options').numChildren()" } } }, @@ -34,7 +34,7 @@ ".read": "auth != null", "$poll": { ".write": "auth != null", - ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'endedAt']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && newData.child('endedAt').isNumber())" + ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && (!newData.child('endedAt').exists() || newData.child('endedAt').isNumber()))" } }, "pollSets": { From aa4bda52d0a00a76cddfb6c4ebf204065a6c8a7e Mon Sep 17 00:00:00 2001 From: Jody Date: Sun, 14 Jun 2026 15:00:59 -0600 Subject: [PATCH 09/12] Another version to validate children. --- firebase-rules.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firebase-rules.json b/firebase-rules.json index 3f1d083..b60c0a8 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -14,7 +14,7 @@ ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && newData.child('correctPolicy').isString() && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))", "responses": { "$student": { - ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && newData.val() < root.child('session/activePoll/options').numChildren()" + ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && root.child('session/activePoll/options').hasChild(newData.val().asString())" } } }, From 8da4ccf2358f6677f600eb5c8e02903ad6754244 Mon Sep 17 00:00:00 2001 From: Jody Date: Sun, 14 Jun 2026 15:06:59 -0600 Subject: [PATCH 10/12] More corrections to validation methods --- firebase-rules.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firebase-rules.json b/firebase-rules.json index b60c0a8..e6c96f2 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -14,7 +14,7 @@ ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && newData.child('correctPolicy').isString() && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))", "responses": { "$student": { - ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && root.child('session/activePoll/options').hasChild(newData.val().asString())" + ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && root.child('session/activePoll/options').child(newData.val()).exists()" } } }, @@ -34,7 +34,7 @@ ".read": "auth != null", "$poll": { ".write": "auth != null", - ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && (!newData.child('endedAt').exists() || newData.child('endedAt').isNumber()))" + ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && (!newData.child('endedAt').exists() || newData.child('endedAt').isNumber()) && (!newData.child('correctIndex').exists() || (newData.child('correctIndex').isNumber() && newData.child('correctIndex').val() >= 0 && (newData.child('correctIndex').val() % 1 == 0) && newData.child('options').child(newData.child('correctIndex').val()).exists())))" } }, "pollSets": { From 3ede29fc92d036a1d19455a1f83d27be34023e98 Mon Sep 17 00:00:00 2001 From: Jody Paul Date: Sun, 14 Jun 2026 15:16:23 -0600 Subject: [PATCH 11/12] Adds useful restriction on value types Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- firebase-rules.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firebase-rules.json b/firebase-rules.json index e6c96f2..4b052ef 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -11,7 +11,7 @@ } }, "activePoll": { - ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && newData.child('correctPolicy').isString() && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))", + ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))" "responses": { "$student": { ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && root.child('session/activePoll/options').child(newData.val()).exists()" From 0a39c1fc842cd328b435f29ed00712e687a93e92 Mon Sep 17 00:00:00 2001 From: Jody Paul Date: Sun, 14 Jun 2026 15:30:59 -0600 Subject: [PATCH 12/12] Refine validation rules in firebase-rules.json --- firebase-rules.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/firebase-rules.json b/firebase-rules.json index 4b052ef..2be1a67 100644 --- a/firebase-rules.json +++ b/firebase-rules.json @@ -7,11 +7,12 @@ "students": { "$student": { ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('date').isString()))", - ".validate": "!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && (newData.child('joinedAt').isNumber() || newData.child('joinedAt/.sv').val() == 'timestamp') && newData.child('date').isString())" + ".validate": "!newData.exists() || (newData.hasChildren(['joinedAt', 'date']) && newData.child('joinedAt').isNumber() && newData.child('date').isString())" } }, "activePoll": { - ".write": "auth != null && (!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean()))" + ".write": "auth != null", + ".validate": "!newData.exists() || (newData.hasChildren(['id', 'question', 'options', 'duration', 'resultPolicy', 'correctPolicy', 'startedAt', 'ended', 'revealResults', 'revealCorrect']) && newData.child('id').isString() && newData.child('question').isString() && newData.child('options').hasChildren() && newData.child('duration').isNumber() && newData.child('duration').val() >= 1 && newData.child('duration').val() <= 3600 && newData.child('resultPolicy').isString() && (newData.child('resultPolicy').val() == 'on_submit' || newData.child('resultPolicy').val() == 'manual' || newData.child('resultPolicy').val() == 'never') && newData.child('correctPolicy').isString() && (newData.child('correctPolicy').val() == 'with_results' || newData.child('correctPolicy').val() == 'manual' || newData.child('correctPolicy').val() == 'never') && newData.child('startedAt').isNumber() && newData.child('ended').isBoolean() && newData.child('revealResults').isBoolean() && newData.child('revealCorrect').isBoolean() && (!newData.child('correctIndex').exists() || (newData.child('correctIndex').isNumber() && newData.child('correctIndex').val() >= 0 && (newData.child('correctIndex').val() % 1 == 0) && newData.child('options').child(newData.child('correctIndex').val()).exists())))", "responses": { "$student": { ".validate": "newData.isNumber() && newData.val() >= 0 && (newData.val() % 1 == 0) && root.child('session/activePoll/options').child(newData.val()).exists()" @@ -27,7 +28,7 @@ ".read": "auth != null", "$entry": { ".write": "auth != null", - ".validate": "!newData.exists() || (newData.hasChildren(['name', 'date', 'joinedAt']) && newData.child('name').isString() && newData.child('date').isString() && (newData.child('joinedAt').isNumber() || newData.child('joinedAt/.sv').val() == 'timestamp'))" + ".validate": "!newData.exists() || (newData.hasChildren(['name', 'date', 'joinedAt']) && newData.child('name').isString() && newData.child('date').isString() && newData.child('joinedAt').isNumber())" } }, "pollHistory": {